[RFT,0/2] ACPI / PM: Avoid spurious wakeups from non-wakeup GPEs in suspend-to-idle

Message

Rafael J. Wysocki Dec. 17, 2018, 11:19 a.m. UTC

Hi All,

It turns out that on some systems non-wakeup GPEs cause trouble (see the
changelog of patch [1/2]), so they better should be disabled during
suspend-to-idle (at least before entering the main loop of it).  This
is done in patch [1/2].

Patch [2/2] is just a folllow-up.

Thanks,
Rafael

Comments

Mika Westerberg Dec. 17, 2018, 4:50 p.m. UTC | #1

On Mon, Dec 17, 2018 at 12:19:27PM +0100, Rafael J. Wysocki wrote:
> Hi All,

Hi Rafael,

> It turns out that on some systems non-wakeup GPEs cause trouble (see the
> changelog of patch [1/2]), so they better should be disabled during
> suspend-to-idle (at least before entering the main loop of it).  This
> is done in patch [1/2].
> 
> Patch [2/2] is just a folllow-up.

I tested both patches on Lenovo Carbon X1 6th generation and one new
Dell system. Both default to s2idle. I did not see any issues around
s2idle with the two patches applied.

Tested-by: Mika Westerberg <[e-mail]>

Rafael J. Wysocki Dec. 18, 2018, 9:50 a.m. UTC | #2

On Mon, Dec 17, 2018 at 5:50 PM Mika Westerberg
<[e-mail]> wrote:
>
> On Mon, Dec 17, 2018 at 12:19:27PM +0100, Rafael J. Wysocki wrote:
> > Hi All,
>
> Hi Rafael,
>
> > It turns out that on some systems non-wakeup GPEs cause trouble (see the
> > changelog of patch [1/2]), so they better should be disabled during
> > suspend-to-idle (at least before entering the main loop of it).  This
> > is done in patch [1/2].
> >
> > Patch [2/2] is just a folllow-up.
>
> I tested both patches on Lenovo Carbon X1 6th generation and one new
> Dell system. Both default to s2idle. I did not see any issues around
> s2idle with the two patches applied.
>
> Tested-by: Mika Westerberg <[e-mail]>

Thank you!