diff mbox series

python/sepolicy: search() also for dontaudit rules

Message ID 20181212152826.24140-1-plautrba@redhat.com (mailing list archive)
State Not Applicable
Headers show
Series python/sepolicy: search() also for dontaudit rules | expand

Commit Message

Petr Lautrbach Dec. 12, 2018, 3:28 p.m. UTC 
dontaudit rules were accidentally dropped during rewrite to SETools 4 API in
97d5f6a2

Fixes:
>>> import sepolicy
>>> sepolicy.search(['dontaudit'])
[]

Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---

Same patch as https://lore.kernel.org/selinux/20180918134401.22956-1-plautrba@redhat.com/
but with a slightly reworded commit message

 python/sepolicy/sepolicy/__init__.py | 2 ++
 1 file changed, 2 insertions(+)

Comments

Nicolas Iooss Dec. 15, 2018, 3:28 p.m. UTC | #1 
On Wed, Dec 12, 2018 at 4:28 PM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> dontaudit rules were accidentally dropped during rewrite to SETools 4 API in
> 97d5f6a2
>
> Fixes:
> >>> import sepolicy
> >>> sepolicy.search(['dontaudit'])
> []
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>

Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>

> ---
>
> Same patch as https://lore.kernel.org/selinux/20180918134401.22956-1-plautrba@redhat.com/
> but with a slightly reworded commit message
>
>  python/sepolicy/sepolicy/__init__.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/python/sepolicy/sepolicy/__init__.py b/python/sepolicy/sepolicy/__init__.py
> index cd7af7cf..fbeb731d 100644
> --- a/python/sepolicy/sepolicy/__init__.py
> +++ b/python/sepolicy/sepolicy/__init__.py
> @@ -344,6 +344,8 @@ def search(types, seinfo=None):
>          tertypes.append(NEVERALLOW)
>      if AUDITALLOW in types:
>          tertypes.append(AUDITALLOW)
> +    if DONTAUDIT in types:
> +        tertypes.append(DONTAUDIT)
>
>      if len(tertypes) > 0:
>          q = setools.TERuleQuery(_pol,
> --
> 2.19.2
>
Petr Lautrbach Dec. 18, 2018, 12:24 p.m. UTC | #2 
Nicolas Iooss <nicolas.iooss@m4x.org> writes:

> On Wed, Dec 12, 2018 at 4:28 PM Petr Lautrbach <plautrba@redhat.com> wrote:
>>
>> dontaudit rules were accidentally dropped during rewrite to SETools 4 API in
>> 97d5f6a2
>>
>> Fixes:
>> >>> import sepolicy
>> >>> sepolicy.search(['dontaudit'])
>> []
>>
>> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
>

Merged.

>> ---
>>
>> Same patch as https://lore.kernel.org/selinux/20180918134401.22956-1-plautrba@redhat.com/
>> but with a slightly reworded commit message
>>
>>  python/sepolicy/sepolicy/__init__.py | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/python/sepolicy/sepolicy/__init__.py b/python/sepolicy/sepolicy/__init__.py
>> index cd7af7cf..fbeb731d 100644
>> --- a/python/sepolicy/sepolicy/__init__.py
>> +++ b/python/sepolicy/sepolicy/__init__.py
>> @@ -344,6 +344,8 @@ def search(types, seinfo=None):
>>          tertypes.append(NEVERALLOW)
>>      if AUDITALLOW in types:
>>          tertypes.append(AUDITALLOW)
>> +    if DONTAUDIT in types:
>> +        tertypes.append(DONTAUDIT)
>>
>>      if len(tertypes) > 0:
>>          q = setools.TERuleQuery(_pol,
>> --
>> 2.19.2
>>
diff mbox series

Patch

diff --git a/python/sepolicy/sepolicy/__init__.py b/python/sepolicy/sepolicy/__init__.py
index cd7af7cf..fbeb731d 100644
--- a/python/sepolicy/sepolicy/__init__.py
+++ b/python/sepolicy/sepolicy/__init__.py
@@ -344,6 +344,8 @@  def search(types, seinfo=None):
         tertypes.append(NEVERALLOW)
     if AUDITALLOW in types:
         tertypes.append(AUDITALLOW)
+    if DONTAUDIT in types:
+        tertypes.append(DONTAUDIT)
 
     if len(tertypes) > 0:
         q = setools.TERuleQuery(_pol,