| Message ID | 20181218225824.20974-1-andrew.smirnov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: eukrea-tlv320: Do not enable on ARM64 | expand |
Hi Andrey, On Tue, Dec 18, 2018 at 8:58 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > > ARCH_MXC is also used by i.MX8/AArch64 SoC, building the driver for > that platform results in: > > sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such file or directory > #include <asm/mach-types.h> > ^~~~~~~~~~~~~~~~~~ > compilation terminated. > > Since the code in question doesn't seem to have any use on i.MX8, > disable it by adding a !ARM64 as a dependecy. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > > Sorry for the noise if this is fixed already. Yes, I sent a fix for this and it is linux-next already: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/sound/soc/fsl/Kconfig?h=next-20181218&id=add6883619a9e3bf9658eaff1a547354131bbcd9
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 6ec19fb4a934..2e75b5bc5f1d 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -221,7 +221,7 @@ config SND_SOC_PHYCORE_AC97 config SND_SOC_EUKREA_TLV320 tristate "Eukrea TLV320" - depends on ARCH_MXC && I2C + depends on ARCH_MXC && !ARM64 && I2C select SND_SOC_TLV320AIC23_I2C select SND_SOC_IMX_AUDMUX select SND_SOC_IMX_SSI
ARCH_MXC is also used by i.MX8/AArch64 SoC, building the driver for that platform results in: sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such file or directory #include <asm/mach-types.h> ^~~~~~~~~~~~~~~~~~ compilation terminated. Since the code in question doesn't seem to have any use on i.MX8, disable it by adding a !ARM64 as a dependecy. Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- Sorry for the noise if this is fixed already. Thanks, Andrey Smirnov sound/soc/fsl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)