diff mbox series

ARM: dts: da850-evm: Correct the audio codec regulators

Message ID 20181219101258.20763-1-peter.ujfalusi@ti.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: da850-evm: Correct the audio codec regulators | expand

Commit Message

Peter Ujfalusi Dec. 19, 2018, 10:12 a.m. UTC
Add the board level fixed regulators for 3.3V and 1.8V which is used to
power - among other things - the tlv320aic3106 codec.

Apart from removing the following warning during boot:
tlv320aic3x-codec 0-0018: Too high supply voltage(s) AVDD: 5000000, DVDD: 5000000

With the correct voltages the driver can select correct OCMV value to
reduce pop noise.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 arch/arm/boot/dts/da850-evm.dts | 29 +++++++++++++++++++++++++----
 1 file changed, 25 insertions(+), 4 deletions(-)

Comments

Peter Ujfalusi Dec. 19, 2018, 11:37 a.m. UTC | #1
Hi,

On 19/12/2018 12.12, Peter Ujfalusi wrote:
> Add the board level fixed regulators for 3.3V and 1.8V which is used to
> power - among other things - the tlv320aic3106 codec.
> 
> Apart from removing the following warning during boot:
> tlv320aic3x-codec 0-0018: Too high supply voltage(s) AVDD: 5000000, DVDD: 5000000
> 
> With the correct voltages the driver can select correct OCMV value to
> reduce pop noise.

Please ignore this, I'll send an update.

> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm/boot/dts/da850-evm.dts | 29 +++++++++++++++++++++++++----
>  1 file changed, 25 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index f9a5a8212c84..997bede2a48f 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -94,6 +94,28 @@
>  		regulator-boot-on;
>  	};
>  
> +	baseboard_3v3: fixedregulator-3v3 {
> +		/* TPS73701DCQ */
> +		compatible = "regulator-fixed";
> +		regulator-name = "baseboard_3v3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vbat>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	baseboard_1v8: fixedregulator-1v8 {
> +		/* TPS73701DCQ */
> +		compatible = "regulator-fixed";
> +		regulator-name = "baseboard_1v8";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		vin-supply = <&vbat>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
>  	backlight_lcd: backlight-regulator {
>  		compatible = "regulator-fixed";
>  		regulator-name = "lcd_backlight_pwr";
> @@ -210,10 +232,9 @@
>  
>  		/* Regulators */
>  		IOVDD-supply = <&vdcdc2_reg>;
> -		/* Derived from VBAT: Baseboard 3.3V / 1.8V */
> -		AVDD-supply = <&vbat>;
> -		DRVDD-supply = <&vbat>;
> -		DVDD-supply = <&vbat>;
> +		AVDD-supply = <&baseboard_3v3>;
> +		DRVDD-supply = <&baseboard_3v3>;
> +		DVDD-supply = <&baseboard_1v8>;
>  	};
>  	tca6416: gpio@20 {
>  		compatible = "ti,tca6416";
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index f9a5a8212c84..997bede2a48f 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -94,6 +94,28 @@ 
 		regulator-boot-on;
 	};
 
+	baseboard_3v3: fixedregulator-3v3 {
+		/* TPS73701DCQ */
+		compatible = "regulator-fixed";
+		regulator-name = "baseboard_3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vbat>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	baseboard_1v8: fixedregulator-1v8 {
+		/* TPS73701DCQ */
+		compatible = "regulator-fixed";
+		regulator-name = "baseboard_1v8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		vin-supply = <&vbat>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
 	backlight_lcd: backlight-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "lcd_backlight_pwr";
@@ -210,10 +232,9 @@ 
 
 		/* Regulators */
 		IOVDD-supply = <&vdcdc2_reg>;
-		/* Derived from VBAT: Baseboard 3.3V / 1.8V */
-		AVDD-supply = <&vbat>;
-		DRVDD-supply = <&vbat>;
-		DVDD-supply = <&vbat>;
+		AVDD-supply = <&baseboard_3v3>;
+		DRVDD-supply = <&baseboard_3v3>;
+		DVDD-supply = <&baseboard_1v8>;
 	};
 	tca6416: gpio@20 {
 		compatible = "ti,tca6416";