| Message ID | 20181129042522.11767-1-govinds@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bd085be6ba9547795ddcbdc5cc0c78ea0201ba6e |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: Move non-fatal warn logs to dbg level | expand |
On Wed, Nov 28, 2018 at 8:25 PM Govind Singh <govinds@codeaurora.org> wrote: > > During driver load below warn logs are printed in the console. > Since driver may not implement all wmi events sent by fw and > all of them are non-fatal, move this log to debug level to > remove un-necessary warn message on console. > > [ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 > [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569 > > Signed-off-by: Govind Singh <govinds@codeaurora.org> Alternatively, you could add these ignored commands to wmi-tlv.h, and just ignore them specifically. That's better documentation, in case new WMI events come along that *are* important to notice when we ignore them. There are other recent examples of that sort of patch being merged. Brian
Brian Norris <briannorris@chromium.org> writes: > On Wed, Nov 28, 2018 at 8:25 PM Govind Singh <govinds@codeaurora.org> wrote: >> >> During driver load below warn logs are printed in the console. >> Since driver may not implement all wmi events sent by fw and >> all of them are non-fatal, move this log to debug level to >> remove un-necessary warn message on console. >> >> [ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 >> [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569 >> >> Signed-off-by: Govind Singh <govinds@codeaurora.org> > > Alternatively, you could add these ignored commands to wmi-tlv.h, and > just ignore them specifically. That's better documentation, in case > new WMI events come along that *are* important to notice when we > ignore them. There are other recent examples of that sort of patch > being merged. I have actually tried to do that (what Brian describes above) during the last years but the problem is that there are just so many different firmware branches that it's difficult to keep up in ath10k. So in the end these warnings just confused the users and they mistakenly thought this warning message is the cause of their problems. That's why I think it's best to remove this warning.
Govind Singh <govinds@codeaurora.org> wrote: > During driver load below warn logs are printed in the console. > Since driver may not implement all wmi events sent by fw and > all of them are non-fatal, move this log to debug level to > remove un-necessary warn message on console. > > [ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 > [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569 > > Signed-off-by: Govind Singh <govinds@codeaurora.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. bd085be6ba95 ath10k: move non-fatal warn logs to dbg level
On Thu, Dec 20, 2018 at 06:40:43PM +0200, Kalle Valo wrote: > Brian Norris <briannorris@chromium.org> writes: > > Alternatively, you could add these ignored commands to wmi-tlv.h, and > > just ignore them specifically. That's better documentation, in case > > new WMI events come along that *are* important to notice when we > > ignore them. There are other recent examples of that sort of patch > > being merged. > > I have actually tried to do that (what Brian describes above) during the > last years but the problem is that there are just so many different > firmware branches that it's difficult to keep up in ath10k. So in the > end these warnings just confused the users and they mistakenly thought > this warning message is the cause of their problems. That's why I think > it's best to remove this warning. Thanks for the background. To be clear, I'm perfectly fine with this patch too. I was mostly just volunteering an alternative, in case it *was* your intention as maintainer to keep it this way. Regards, Brian
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index ad4114a88170..892bd8c30dd9 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -621,7 +621,7 @@ static void ath10k_wmi_tlv_op_rx(struct ath10k *ar, struct sk_buff *skb) ath10k_wmi_event_mgmt_tx_compl(ar, skb); break; default: - ath10k_warn(ar, "Unknown eventid: %d\n", id); + ath10k_dbg(ar, ATH10K_DBG_WMI, "Unknown eventid: %d\n", id); break; }
During driver load below warn logs are printed in the console. Since driver may not implement all wmi events sent by fw and all of them are non-fatal, move this log to debug level to remove un-necessary warn message on console. [ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569 Signed-off-by: Govind Singh <govinds@codeaurora.org> --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)