[v3,0/3] CRTC background color

Message

Matt Roper Nov. 15, 2018, 10:13 p.m. UTC

Third version of the series previously posted here:
  https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.html

This version incorporates review feedback from Ville and Sean Paul.

The first patch here can be merged whenever it receives review approval.
The second and third patches still need to wait for opensource userspace
to be ready before merging (there's ChromeOS work underway).

Cc: [e-mail]
Cc: Wei C Li <[e-mail]>
Cc: Sean Paul <[e-mail]>
Cc: Ville Syrjälä <[e-mail]>

Matt Roper (3):
  drm/i915: Force background color to black for gen9+ (v2)
  drm: Add CRTC background color property (v2)
  drm/i915/gen9+: Add support for pipe background color (v3)

 drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
 drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
 drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
 drivers/gpu/drm/drm_mode_config.c         |  6 +++++
 drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
 drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
 drivers/gpu/drm/i915/intel_display.c      | 40 +++++++++++++++++++++++++++++++
 include/drm/drm_blend.h                   |  1 +
 include/drm/drm_crtc.h                    | 17 +++++++++++++
 include/drm/drm_mode_config.h             |  5 ++++
 include/uapi/drm/drm_mode.h               | 28 ++++++++++++++++++++++
 11 files changed, 136 insertions(+), 3 deletions(-)

Comments

Stéphane Marchesin Dec. 27, 2018, 11:26 p.m. UTC | #1

Hey,

Is there anything missing on the Chrome side to move forward with this series?

Stéphane

On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <[e-mail]> wrote:
>
> Third version of the series previously posted here:
>   https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.html
>
> This version incorporates review feedback from Ville and Sean Paul.
>
> The first patch here can be merged whenever it receives review approval.
> The second and third patches still need to wait for opensource userspace
> to be ready before merging (there's ChromeOS work underway).
>
> Cc: [e-mail]
> Cc: Wei C Li <[e-mail]>
> Cc: Sean Paul <[e-mail]>
> Cc: Ville Syrjälä <[e-mail]>
>
> Matt Roper (3):
>   drm/i915: Force background color to black for gen9+ (v2)
>   drm: Add CRTC background color property (v2)
>   drm/i915/gen9+: Add support for pipe background color (v3)
>
>  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
>  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
>  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
>  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
>  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
>  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
>  drivers/gpu/drm/i915/intel_display.c      | 40 +++++++++++++++++++++++++++++++
>  include/drm/drm_blend.h                   |  1 +
>  include/drm/drm_crtc.h                    | 17 +++++++++++++
>  include/drm/drm_mode_config.h             |  5 ++++
>  include/uapi/drm/drm_mode.h               | 28 ++++++++++++++++++++++
>  11 files changed, 136 insertions(+), 3 deletions(-)
>
> --
> 2.14.4
>
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Li, Wei C Dec. 27, 2018, 11:49 p.m. UTC | #2

Matt,

Is that possible for you to get some time to review https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 and confirm the FROMLIST change if it looks good to you so we could move forward?

BTW, I've backported your kernel patch into Chrome OS and verified it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google Pixelbook with KBL graphics. 

Thanks,
Wei

-----Original Message-----
From: Stéphane Marchesin [mailto:[e-mail]] 
Sent: Thursday, December 27, 2018 3:27 PM
To: Roper, Matthew D <[e-mail]>
Cc: intel-gfx <[e-mail]>; Li, Wei C <[e-mail]>; dri-devel <[e-mail]>
Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

Hey,

Is there anything missing on the Chrome side to move forward with this series?

Stéphane

On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <[e-mail]> wrote:
>
> Third version of the series previously posted here:
>   
> https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> html
>
> This version incorporates review feedback from Ville and Sean Paul.
>
> The first patch here can be merged whenever it receives review approval.
> The second and third patches still need to wait for opensource 
> userspace to be ready before merging (there's ChromeOS work underway).
>
> Cc: [e-mail]
> Cc: Wei C Li <[e-mail]>
> Cc: Sean Paul <[e-mail]>
> Cc: Ville Syrjälä <[e-mail]>
>
> Matt Roper (3):
>   drm/i915: Force background color to black for gen9+ (v2)
>   drm: Add CRTC background color property (v2)
>   drm/i915/gen9+: Add support for pipe background color (v3)
>
>  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
>  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
>  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
>  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
>  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
>  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
>  drivers/gpu/drm/i915/intel_display.c      | 40 +++++++++++++++++++++++++++++++
>  include/drm/drm_blend.h                   |  1 +
>  include/drm/drm_crtc.h                    | 17 +++++++++++++
>  include/drm/drm_mode_config.h             |  5 ++++
>  include/uapi/drm/drm_mode.h               | 28 ++++++++++++++++++++++
>  11 files changed, 136 insertions(+), 3 deletions(-)
>
> --
> 2.14.4
>
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Stéphane Marchesin Dec. 28, 2018, 12:22 a.m. UTC | #3

On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
>
> Matt,
>
> Is that possible for you to get some time to review https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 and confirm the FROMLIST change if it looks good to you so we could move forward?
>

To be more precise, I am trying to assess what's needed before this
patch goes usptream, and in particular, I'd like to know if we are
blocked on any Chrome-side thing.

Stéphane


> BTW, I've backported your kernel patch into Chrome OS and verified it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google Pixelbook with KBL graphics.
>
> Thanks,
> Wei
>
> -----Original Message-----
> From: Stéphane Marchesin [mailto:[e-mail]]
> Sent: Thursday, December 27, 2018 3:27 PM
> To: Roper, Matthew D <[e-mail]>
> Cc: intel-gfx <[e-mail]>; Li, Wei C <[e-mail]>; dri-devel <[e-mail]>
> Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
>
> Hey,
>
> Is there anything missing on the Chrome side to move forward with this series?
>
> Stéphane
>
> On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <[e-mail]> wrote:
> >
> > Third version of the series previously posted here:
> >
> > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > html
> >
> > This version incorporates review feedback from Ville and Sean Paul.
> >
> > The first patch here can be merged whenever it receives review approval.
> > The second and third patches still need to wait for opensource
> > userspace to be ready before merging (there's ChromeOS work underway).
> >
> > Cc: [e-mail]
> > Cc: Wei C Li <[e-mail]>
> > Cc: Sean Paul <[e-mail]>
> > Cc: Ville Syrjälä <[e-mail]>
> >
> > Matt Roper (3):
> >   drm/i915: Force background color to black for gen9+ (v2)
> >   drm: Add CRTC background color property (v2)
> >   drm/i915/gen9+: Add support for pipe background color (v3)
> >
> >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> >  drivers/gpu/drm/i915/intel_display.c      | 40 +++++++++++++++++++++++++++++++
> >  include/drm/drm_blend.h                   |  1 +
> >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> >  include/drm/drm_mode_config.h             |  5 ++++
> >  include/uapi/drm/drm_mode.h               | 28 ++++++++++++++++++++++
> >  11 files changed, 136 insertions(+), 3 deletions(-)
> >
> > --
> > 2.14.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > [e-mail]
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Matt Roper Dec. 28, 2018, 12:45 a.m. UTC | #4

On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
> >
> > Matt,
> >
> > Is that possible for you to get some time to review https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 and confirm the FROMLIST change if it looks good to you so we could move forward?
> >
> 
> To be more precise, I am trying to assess what's needed before this
> patch goes usptream, and in particular, I'd like to know if we are
> blocked on any Chrome-side thing.
> 
> Stéphane
> 

Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
from the ChromeOS userspace team on the ABI, plus a pointer to where the
final, reviewed userspace patches are that correspond to it (mailing
list link or gerrit or whatever).  I have an old gerrit link to some
in-development chromium/ozone patches for this from November 2nd, but
I'm not sure if there's a newer one now.
 
Aside from satisfying the ABI/userspace requirements, we still need all
the patches to get reviewed by the upstream kernel devs.  An older
version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
been accepted yet.  Actually it looks like I never sent the latest
version of my series that incorporates some additional feedback from
Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
people are still out on holiday vacation at the moment, so if necessary
I'll start pinging IRC for reviews in a week or two when people are back
in office.


Matt

> 
> > BTW, I've backported your kernel patch into Chrome OS and verified it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google Pixelbook with KBL graphics.
> >
> > Thanks,
> > Wei
> >
> > -----Original Message-----
> > From: Stéphane Marchesin [mailto:[e-mail]]
> > Sent: Thursday, December 27, 2018 3:27 PM
> > To: Roper, Matthew D <[e-mail]>
> > Cc: intel-gfx <[e-mail]>; Li, Wei C <[e-mail]>; dri-devel <[e-mail]>
> > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> >
> > Hey,
> >
> > Is there anything missing on the Chrome side to move forward with this series?
> >
> > Stéphane
> >
> > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <[e-mail]> wrote:
> > >
> > > Third version of the series previously posted here:
> > >
> > > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > html
> > >
> > > This version incorporates review feedback from Ville and Sean Paul.
> > >
> > > The first patch here can be merged whenever it receives review approval.
> > > The second and third patches still need to wait for opensource
> > > userspace to be ready before merging (there's ChromeOS work underway).
> > >
> > > Cc: [e-mail]
> > > Cc: Wei C Li <[e-mail]>
> > > Cc: Sean Paul <[e-mail]>
> > > Cc: Ville Syrjälä <[e-mail]>
> > >
> > > Matt Roper (3):
> > >   drm/i915: Force background color to black for gen9+ (v2)
> > >   drm: Add CRTC background color property (v2)
> > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > >
> > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > >  drivers/gpu/drm/i915/intel_display.c      | 40 +++++++++++++++++++++++++++++++
> > >  include/drm/drm_blend.h                   |  1 +
> > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > >  include/drm/drm_mode_config.h             |  5 ++++
> > >  include/uapi/drm/drm_mode.h               | 28 ++++++++++++++++++++++
> > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > >
> > > --
> > > 2.14.4
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > [e-mail]
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Stéphane Marchesin Dec. 28, 2018, 1:09 a.m. UTC | #5

On Thu, Dec 27, 2018 at 4:45 PM Matt Roper <[e-mail]> wrote:
>
> On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
> > >
> > > Matt,
> > >
> > > Is that possible for you to get some time to review https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 and confirm the FROMLIST change if it looks good to you so we could move forward?
> > >
> >
> > To be more precise, I am trying to assess what's needed before this
> > patch goes usptream, and in particular, I'd like to know if we are
> > blocked on any Chrome-side thing.
> >
> > Stéphane
> >
>
> Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> from the ChromeOS userspace team on the ABI, plus a pointer to where the
> final, reviewed userspace patches are that correspond to it (mailing
> list link or gerrit or whatever).  I have an old gerrit link to some
> in-development chromium/ozone patches for this from November 2nd, but
> I'm not sure if there's a newer one now.

IMO from user space the ABI is good. I think the question is more
whether other hw would be fine with it. For example if we notice that
other platforms can only do black as a background color, how can we
make this API standard. Hopefully other folks can chime in here about
other hw capabilities.

Stéphane


>
> Aside from satisfying the ABI/userspace requirements, we still need all
> the patches to get reviewed by the upstream kernel devs.  An older
> version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> been accepted yet.  Actually it looks like I never sent the latest
> version of my series that incorporates some additional feedback from
> Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> people are still out on holiday vacation at the moment, so if necessary
> I'll start pinging IRC for reviews in a week or two when people are back
> in office.
>
>
> Matt
>
> >
> > > BTW, I've backported your kernel patch into Chrome OS and verified it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google Pixelbook with KBL graphics.
> > >
> > > Thanks,
> > > Wei
> > >
> > > -----Original Message-----
> > > From: Stéphane Marchesin [mailto:[e-mail]]
> > > Sent: Thursday, December 27, 2018 3:27 PM
> > > To: Roper, Matthew D <[e-mail]>
> > > Cc: intel-gfx <[e-mail]>; Li, Wei C <[e-mail]>; dri-devel <[e-mail]>
> > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > >
> > > Hey,
> > >
> > > Is there anything missing on the Chrome side to move forward with this series?
> > >
> > > Stéphane
> > >
> > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <[e-mail]> wrote:
> > > >
> > > > Third version of the series previously posted here:
> > > >
> > > > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > > html
> > > >
> > > > This version incorporates review feedback from Ville and Sean Paul.
> > > >
> > > > The first patch here can be merged whenever it receives review approval.
> > > > The second and third patches still need to wait for opensource
> > > > userspace to be ready before merging (there's ChromeOS work underway).
> > > >
> > > > Cc: [e-mail]
> > > > Cc: Wei C Li <[e-mail]>
> > > > Cc: Sean Paul <[e-mail]>
> > > > Cc: Ville Syrjälä <[e-mail]>
> > > >
> > > > Matt Roper (3):
> > > >   drm/i915: Force background color to black for gen9+ (v2)
> > > >   drm: Add CRTC background color property (v2)
> > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > > >
> > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > > >  drivers/gpu/drm/i915/intel_display.c      | 40 +++++++++++++++++++++++++++++++
> > > >  include/drm/drm_blend.h                   |  1 +
> > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > > >  include/drm/drm_mode_config.h             |  5 ++++
> > > >  include/uapi/drm/drm_mode.h               | 28 ++++++++++++++++++++++
> > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > > >
> > > > --
> > > > 2.14.4
> > > >
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > [e-mail]
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> [phone]

Daniel Vetter Dec. 28, 2018, 11:53 a.m. UTC | #6

Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin <[e-mail]> 
geschrieben:
> On Thu, Dec 27, 2018 at 4:45 PM Matt Roper <[e-mail]> 
> wrote:
> >
> > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
> > > >
> > > > Matt,
> > > >
> > > > Is that possible for you to get some time to review 
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 
> and confirm the FROMLIST change if it looks good to you so we could move 
> forward?
> > > >
> > >
> > > To be more precise, I am trying to assess what's needed before this
> > > patch goes usptream, and in particular, I'd like to know if we are
> > > blocked on any Chrome-side thing.
> > >
> > > Stéphane
> > >
> >
> > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> > from the ChromeOS userspace team on the ABI, plus a pointer to where the
> > final, reviewed userspace patches are that correspond to it (mailing
> > list link or gerrit or whatever).  I have an old gerrit link to some
> > in-development chromium/ozone patches for this from November 2nd, but
> > I'm not sure if there's a newer one now.
>
> IMO from user space the ABI is good. I think the question is more
> whether other hw would be fine with it. For example if we notice that
> other platforms can only do black as a background color, how can we
> make this API standard. Hopefully other folks can chime in here about
> other hw capabilities.

black background is already the default, so "no prop" = "black
background". The problem is a bit figuring out whether you can make the
primary plane non-fullscreen, which atm is a TEST_ONLY guessing game for
userspace. We've discussed some "can_scale" and "can_position" properties
for that, but aside from reworking the helpers to check plane updates
nothing happened.
-Daniel
>
> Stéphane
>
>
> >
> > Aside from satisfying the ABI/userspace requirements, we still need all
> > the patches to get reviewed by the upstream kernel devs.  An older
> > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> > been accepted yet.  Actually it looks like I never sent the latest
> > version of my series that incorporates some additional feedback from
> > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> > people are still out on holiday vacation at the moment, so if necessary
> > I'll start pinging IRC for reviews in a week or two when people are back
> > in office.
>


>
> >
> > Matt
> >
> > >
> > > > BTW, I've backported your kernel patch into Chrome OS and verified 
> it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google 
> Pixelbook with KBL graphics.
> > > >
> > > > Thanks,
> > > > Wei
> > > >
> > > > -----Original Message-----
> > > > From: Stéphane Marchesin [mailto:[e-mail]]
> > > > Sent: Thursday, December 27, 2018 3:27 PM
> > > > To: Roper, Matthew D <[e-mail]>
> > > > Cc: intel-gfx <[e-mail]>; Li, Wei C <
> [e-mail]>; dri-devel <[e-mail]>
> > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > > >
> > > > Hey,
> > > >
> > > > Is there anything missing on the Chrome side to move forward with 
> this series?
> > > >
> > > > Stéphane
> > > >
> > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <
> [e-mail]> wrote:
> > > > >
> > > > > Third version of the series previously posted here:
> > > > >
> > > > > 
> https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > > > html
> > > > >
> > > > > This version incorporates review feedback from Ville and Sean Paul.
> > > > >
> > > > > The first patch here can be merged whenever it receives review 
> approval.
> > > > > The second and third patches still need to wait for opensource
> > > > > userspace to be ready before merging (there's ChromeOS work 
> underway).
> > > > >
> > > > > Cc: [e-mail]
> > > > > Cc: Wei C Li <[e-mail]>
> > > > > Cc: Sean Paul <[e-mail]>
> > > > > Cc: Ville Syrjälä <[e-mail]>
> > > > >
> > > > > Matt Roper (3):
> > > > >   drm/i915: Force background color to black for gen9+ (v2)
> > > > >   drm: Add CRTC background color property (v2)
> > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > > > >
> > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > > > >  drivers/gpu/drm/i915/intel_display.c      | 40 
> +++++++++++++++++++++++++++++++
> > > > >  include/drm/drm_blend.h                   |  1 +
> > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > > > >  include/drm/drm_mode_config.h             |  5 ++++
> > > > >  include/uapi/drm/drm_mode.h               | 28 
> ++++++++++++++++++++++
> > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > > > >
> > > > > --
> > > > > 2.14.4
> > > > >
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > [e-mail]
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> > --
> > Matt Roper
> > Graphics Software Engineer
> > IoTG Platform Enabling & Development
> > Intel Corporation
> > [phone]
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin &lt;<a href="mailto:[e-mail]">[e-mail]</a>&gt; geschrieben:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Dec 27, 2018 at 4:45 PM Matt Roper &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt; wrote:<br>
&gt;<br>
&gt; On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:<br>
&gt; &gt; On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt; wrote:<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Matt,<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Is that possible for you to get some time to review <a href="https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366" rel="noreferrer noreferrer" target="_blank">https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366</a> and confirm the FROMLIST change if it looks good to you so we could move forward?<br>
&gt; &gt; &gt;<br>
&gt; &gt;<br>
&gt; &gt; To be more precise, I am trying to assess what&#39;s needed before this<br>
&gt; &gt; patch goes usptream, and in particular, I&#39;d like to know if we are<br>
&gt; &gt; blocked on any Chrome-side thing.<br>
&gt; &gt;<br>
&gt; &gt; Stéphane<br>
&gt; &gt;<br>
&gt;<br>
&gt; Hi Stéphane.  On the Chrome side of things, I believe we need an Ack<br>
&gt; from the ChromeOS userspace team on the ABI, plus a pointer to where the<br>
&gt; final, reviewed userspace patches are that correspond to it (mailing<br>
&gt; list link or gerrit or whatever).  I have an old gerrit link to some<br>
&gt; in-development chromium/ozone patches for this from November 2nd, but<br>
&gt; I&#39;m not sure if there&#39;s a newer one now.<br>
<br>
IMO from user space the ABI is good. I think the question is more<br>
whether other hw would be fine with it. For example if we notice that<br>
other platforms can only do black as a background color, how can we<br>
make this API standard. Hopefully other folks can chime in here about<br>
other hw capabilities.<br>
<br>
Stéphane<br>
<br>
<br>
&gt;<br>
&gt; Aside from satisfying the ABI/userspace requirements, we still need all<br>
&gt; the patches to get reviewed by the upstream kernel devs.  An older<br>
&gt; version of patch #2 has a r-b from Sean, but patches 1 and 3 haven&#39;t<br>
&gt; been accepted yet.  Actually it looks like I never sent the latest<br>
&gt; version of my series that incorporates some additional feedback from<br>
&gt; Brian Starkey to the list; I&#39;ll do that tomorrow.  I think a lot of<br>
&gt; people are still out on holiday vacation at the moment, so if necessary<br>
&gt; I&#39;ll start pinging IRC for reviews in a week or two when people are back<br>
&gt; in office.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt;<br>
&gt;<br>
&gt; Matt<br>
&gt;<br>
&gt; &gt;<br>
&gt; &gt; &gt; BTW, I&#39;ve backported your kernel patch into Chrome OS and verified it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google Pixelbook with KBL graphics.<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Thanks,<br>
&gt; &gt; &gt; Wei<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; -----Original Message-----<br>
&gt; &gt; &gt; From: Stéphane Marchesin [mailto:<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>]<br>
&gt; &gt; &gt; Sent: Thursday, December 27, 2018 3:27 PM<br>
&gt; &gt; &gt; To: Roper, Matthew D &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt;<br>
&gt; &gt; &gt; Cc: intel-gfx &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt;; Li, Wei C &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt;; dri-devel &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt;<br>
&gt; &gt; &gt; Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Hey,<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Is there anything missing on the Chrome side to move forward with this series?<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Stéphane<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; On Thu, Nov 15, 2018 at 2:14 PM Matt Roper &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt; wrote:<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; Third version of the series previously posted here:<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; <a href="https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777</a>.<br>
&gt; &gt; &gt; &gt; html<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; This version incorporates review feedback from Ville and Sean Paul.<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; The first patch here can be merged whenever it receives review approval.<br>
&gt; &gt; &gt; &gt; The second and third patches still need to wait for opensource<br>
&gt; &gt; &gt; &gt; userspace to be ready before merging (there&#39;s ChromeOS work underway).<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; Cc: <a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a><br>
&gt; &gt; &gt; &gt; Cc: Wei C Li &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt;<br>
&gt; &gt; &gt; &gt; Cc: Sean Paul &lt;[e-mail]&gt;<br>
&gt; &gt; &gt; &gt; Cc: Ville Syrjälä &lt;<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a>&gt;<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; Matt Roper (3):<br>
&gt; &gt; &gt; &gt;   drm/i915: Force background color to black for gen9+ (v2)<br>
&gt; &gt; &gt; &gt;   drm: Add CRTC background color property (v2)<br>
&gt; &gt; &gt; &gt;   drm/i915/gen9+: Add support for pipe background color (v3)<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt;  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +<br>
&gt; &gt; &gt; &gt;  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++<br>
&gt; &gt; &gt; &gt;  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---<br>
&gt; &gt; &gt; &gt;  drivers/gpu/drm/drm_mode_config.c         |  6 +++++<br>
&gt; &gt; &gt; &gt;  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++<br>
&gt; &gt; &gt; &gt;  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++<br>
&gt; &gt; &gt; &gt;  drivers/gpu/drm/i915/intel_display.c      | 40 +++++++++++++++++++++++++++++++<br>
&gt; &gt; &gt; &gt;  include/drm/drm_blend.h                   |  1 +<br>
&gt; &gt; &gt; &gt;  include/drm/drm_crtc.h                    | 17 +++++++++++++<br>
&gt; &gt; &gt; &gt;  include/drm/drm_mode_config.h             |  5 ++++<br>
&gt; &gt; &gt; &gt;  include/uapi/drm/drm_mode.h               | 28 ++++++++++++++++++++++<br>
&gt; &gt; &gt; &gt;  11 files changed, 136 insertions(+), 3 deletions(-)<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; --<br>
&gt; &gt; &gt; &gt; 2.14.4<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; _______________________________________________<br>
&gt; &gt; &gt; &gt; Intel-gfx mailing list<br>
&gt; &gt; &gt; &gt; <a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a><br>
&gt; &gt; &gt; &gt; <a href="https://lists.freedesktop.org/mailman/listinfo/intel-gfx" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
&gt;<br>
&gt; --<br>
&gt; Matt Roper<br>
&gt; Graphics Software Engineer<br>
&gt; IoTG Platform Enabling &amp; Development<br>
&gt; Intel Corporation<br>
&gt; [phone]<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:[e-mail]" target="_blank" rel="noreferrer">[e-mail]</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</blockquote></div></div></div>

Matt Roper Dec. 28, 2018, 4:35 p.m. UTC | #7

On Fri, Dec 28, 2018 at 12:53:29PM +0100, Daniel Vetter wrote:
> Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin <[e-mail]> 
> geschrieben:
> > On Thu, Dec 27, 2018 at 4:45 PM Matt Roper <[e-mail]> 
> > wrote:
> > >
> > > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
> > > > >
> > > > > Matt,
> > > > >
> > > > > Is that possible for you to get some time to review 
> > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 
> > and confirm the FROMLIST change if it looks good to you so we could move 
> > forward?
> > > > >
> > > >
> > > > To be more precise, I am trying to assess what's needed before this
> > > > patch goes usptream, and in particular, I'd like to know if we are
> > > > blocked on any Chrome-side thing.
> > > >
> > > > Stéphane
> > > >
> > >
> > > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> > > from the ChromeOS userspace team on the ABI, plus a pointer to where the
> > > final, reviewed userspace patches are that correspond to it (mailing
> > > list link or gerrit or whatever).  I have an old gerrit link to some
> > > in-development chromium/ozone patches for this from November 2nd, but
> > > I'm not sure if there's a newer one now.
> >
> > IMO from user space the ABI is good. I think the question is more
> > whether other hw would be fine with it. For example if we notice that
> > other platforms can only do black as a background color, how can we
> > make this API standard. Hopefully other folks can chime in here about
> > other hw capabilities.
> 
> black background is already the default, so "no prop" = "black
> background". The problem is a bit figuring out whether you can make the
> primary plane non-fullscreen, which atm is a TEST_ONLY guessing game for
> userspace. We've discussed some "can_scale" and "can_position" properties
> for that, but aside from reworking the helpers to check plane updates
> nothing happened.
> -Daniel

Based on feedback from Brian and Eric, it sounds like the thing we need
to get better clarity on is whether all hardware can apply pipe-level
degamma/csc/gamma to the background color the same way it does to plane
content (even for platforms where the background color is always a
non-programmable black).

My initial assumption (which I'll clarify in the kerneldoc) is that
background color should be treated the same way as a plane filled with
that solid color; i.e., it should go through the same pipe-level color
transformations.  Based on Eric's email, it sounds like Raspberry Pi
matches my assumption.  For Intel hardware, we have register bits that
specify whether color management should be applied to the background
color or not (they're not set today for gen9+, which I consider that a
bug since it seems like inconsistent behavior; the first patch of my
series addresses that).

If there are any platforms that don't/can't apply degamma/csc/gamma to
the background color (regardless of whether that background color is
programmable or always fixed at black), we should probably find some way
to make that known to userspace (maybe some extra immutable property?).


Matt

> >
> > Stéphane
> >
> >
> > >
> > > Aside from satisfying the ABI/userspace requirements, we still need all
> > > the patches to get reviewed by the upstream kernel devs.  An older
> > > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> > > been accepted yet.  Actually it looks like I never sent the latest
> > > version of my series that incorporates some additional feedback from
> > > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> > > people are still out on holiday vacation at the moment, so if necessary
> > > I'll start pinging IRC for reviews in a week or two when people are back
> > > in office.
> >
> 
> 
> >
> > >
> > > Matt
> > >
> > > >
> > > > > BTW, I've backported your kernel patch into Chrome OS and verified 
> > it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google 
> > Pixelbook with KBL graphics.
> > > > >
> > > > > Thanks,
> > > > > Wei
> > > > >
> > > > > -----Original Message-----
> > > > > From: Stéphane Marchesin [mailto:[e-mail]]
> > > > > Sent: Thursday, December 27, 2018 3:27 PM
> > > > > To: Roper, Matthew D <[e-mail]>
> > > > > Cc: intel-gfx <[e-mail]>; Li, Wei C <
> > [e-mail]>; dri-devel <[e-mail]>
> > > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > > > >
> > > > > Hey,
> > > > >
> > > > > Is there anything missing on the Chrome side to move forward with 
> > this series?
> > > > >
> > > > > Stéphane
> > > > >
> > > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <
> > [e-mail]> wrote:
> > > > > >
> > > > > > Third version of the series previously posted here:
> > > > > >
> > > > > > 
> > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > > > > html
> > > > > >
> > > > > > This version incorporates review feedback from Ville and Sean Paul.
> > > > > >
> > > > > > The first patch here can be merged whenever it receives review 
> > approval.
> > > > > > The second and third patches still need to wait for opensource
> > > > > > userspace to be ready before merging (there's ChromeOS work 
> > underway).
> > > > > >
> > > > > > Cc: [e-mail]
> > > > > > Cc: Wei C Li <[e-mail]>
> > > > > > Cc: Sean Paul <[e-mail]>
> > > > > > Cc: Ville Syrjälä <[e-mail]>
> > > > > >
> > > > > > Matt Roper (3):
> > > > > >   drm/i915: Force background color to black for gen9+ (v2)
> > > > > >   drm: Add CRTC background color property (v2)
> > > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > > > > >
> > > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > > > > >  drivers/gpu/drm/i915/intel_display.c      | 40 
> > +++++++++++++++++++++++++++++++
> > > > > >  include/drm/drm_blend.h                   |  1 +
> > > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > > > > >  include/drm/drm_mode_config.h             |  5 ++++
> > > > > >  include/uapi/drm/drm_mode.h               | 28 
> > ++++++++++++++++++++++
> > > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > > > > >
> > > > > > --
> > > > > > 2.14.4
> > > > > >
> > > > > > _______________________________________________
> > > > > > Intel-gfx mailing list
> > > > > > [e-mail]
> > > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >
> > > --
> > > Matt Roper
> > > Graphics Software Engineer
> > > IoTG Platform Enabling & Development
> > > Intel Corporation
> > > [phone]
> > _______________________________________________
> > dri-devel mailing list
> > [e-mail]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >

>    Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin
>    <[1][e-mail]> geschrieben:
> 
>      On Thu, Dec 27, 2018 at 4:45 PM Matt Roper
>      <[2][e-mail]> wrote:
>      >
>      > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
>      > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[3][e-mail]>
>      wrote:
>      > > >
>      > > > Matt,
>      > > >
>      > > > Is that possible for you to get some time to review
>      [4]https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
>      and confirm the FROMLIST change if it looks good to you so we could move
>      forward?
>      > > >
>      > >
>      > > To be more precise, I am trying to assess what's needed before this
>      > > patch goes usptream, and in particular, I'd like to know if we are
>      > > blocked on any Chrome-side thing.
>      > >
>      > > Stéphane
>      > >
>      >
>      > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
>      > from the ChromeOS userspace team on the ABI, plus a pointer to where
>      the
>      > final, reviewed userspace patches are that correspond to it (mailing
>      > list link or gerrit or whatever).  I have an old gerrit link to some
>      > in-development chromium/ozone patches for this from November 2nd, but
>      > I'm not sure if there's a newer one now.
> 
>      IMO from user space the ABI is good. I think the question is more
>      whether other hw would be fine with it. For example if we notice that
>      other platforms can only do black as a background color, how can we
>      make this API standard. Hopefully other folks can chime in here about
>      other hw capabilities.
> 
>      Stéphane
> 
>      >
>      > Aside from satisfying the ABI/userspace requirements, we still need
>      all
>      > the patches to get reviewed by the upstream kernel devs.  An older
>      > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
>      > been accepted yet.  Actually it looks like I never sent the latest
>      > version of my series that incorporates some additional feedback from
>      > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
>      > people are still out on holiday vacation at the moment, so if
>      necessary
>      > I'll start pinging IRC for reviews in a week or two when people are
>      back
>      > in office.
> 
>      >
>      >
>      > Matt
>      >
>      > >
>      > > > BTW, I've backported your kernel patch into Chrome OS and verified
>      it using the TEST=drm-tests/atomictest -t crtc_background_color on a
>      Google Pixelbook with KBL graphics.
>      > > >
>      > > > Thanks,
>      > > > Wei
>      > > >
>      > > > -----Original Message-----
>      > > > From: Stéphane Marchesin [mailto:[5][e-mail]]
>      > > > Sent: Thursday, December 27, 2018 3:27 PM
>      > > > To: Roper, Matthew D <[6][e-mail]>
>      > > > Cc: intel-gfx <[7][e-mail]>; Li, Wei C
>      <[8][e-mail]>; dri-devel <[9][e-mail]>
>      > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
>      > > >
>      > > > Hey,
>      > > >
>      > > > Is there anything missing on the Chrome side to move forward with
>      this series?
>      > > >
>      > > > Stéphane
>      > > >
>      > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper
>      <[10][e-mail]> wrote:
>      > > > >
>      > > > > Third version of the series previously posted here:
>      > > > >
>      > > > >
>      [11]https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
>      > > > > html
>      > > > >
>      > > > > This version incorporates review feedback from Ville and Sean
>      Paul.
>      > > > >
>      > > > > The first patch here can be merged whenever it receives review
>      approval.
>      > > > > The second and third patches still need to wait for opensource
>      > > > > userspace to be ready before merging (there's ChromeOS work
>      underway).
>      > > > >
>      > > > > Cc: [12][e-mail]
>      > > > > Cc: Wei C Li <[13][e-mail]>
>      > > > > Cc: Sean Paul <[e-mail]>
>      > > > > Cc: Ville Syrjälä <[14][e-mail]>
>      > > > >
>      > > > > Matt Roper (3):
>      > > > >   drm/i915: Force background color to black for gen9+ (v2)
>      > > > >   drm: Add CRTC background color property (v2)
>      > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
>      > > > >
>      > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
>      > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
>      > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
>      > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
>      > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
>      > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
>      > > > >  drivers/gpu/drm/i915/intel_display.c      | 40
>      +++++++++++++++++++++++++++++++
>      > > > >  include/drm/drm_blend.h                   |  1 +
>      > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
>      > > > >  include/drm/drm_mode_config.h             |  5 ++++
>      > > > >  include/uapi/drm/drm_mode.h               | 28
>      ++++++++++++++++++++++
>      > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
>      > > > >
>      > > > > --
>      > > > > 2.14.4
>      > > > >
>      > > > > _______________________________________________
>      > > > > Intel-gfx mailing list
>      > > > > [15][e-mail]
>      > > > > [16]https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>      >
>      > --
>      > Matt Roper
>      > Graphics Software Engineer
>      > IoTG Platform Enabling & Development
>      > Intel Corporation
>      > [phone]
>      _______________________________________________
>      dri-devel mailing list
>      [17][e-mail]
>      [18]https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> References
> 
>    Visible links
>    1. mailto:[e-mail]
>    2. mailto:[e-mail]
>    3. mailto:[e-mail]
>    4. https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
>    5. mailto:[e-mail]
>    6. mailto:[e-mail]
>    7. mailto:[e-mail]
>    8. mailto:[e-mail]
>    9. mailto:[e-mail]
>   10. mailto:[e-mail]
>   11. https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777
>   12. mailto:[e-mail]
>   13. mailto:[e-mail]
>   14. mailto:[e-mail]
>   15. mailto:[e-mail]
>   16. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>   17. mailto:[e-mail]
>   18. https://lists.freedesktop.org/mailman/listinfo/dri-devel

Daniel Vetter Dec. 28, 2018, 5:14 p.m. UTC | #8

On Fri, Dec 28, 2018 at 5:35 PM Matt Roper <[e-mail]> wrote:
>
> On Fri, Dec 28, 2018 at 12:53:29PM +0100, Daniel Vetter wrote:
> > Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin <[e-mail]>
> > geschrieben:
> > > On Thu, Dec 27, 2018 at 4:45 PM Matt Roper <[e-mail]>
> > > wrote:
> > > >
> > > > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > > > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
> > > > > >
> > > > > > Matt,
> > > > > >
> > > > > > Is that possible for you to get some time to review
> > > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> > > and confirm the FROMLIST change if it looks good to you so we could move
> > > forward?
> > > > > >
> > > > >
> > > > > To be more precise, I am trying to assess what's needed before this
> > > > > patch goes usptream, and in particular, I'd like to know if we are
> > > > > blocked on any Chrome-side thing.
> > > > >
> > > > > Stéphane
> > > > >
> > > >
> > > > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> > > > from the ChromeOS userspace team on the ABI, plus a pointer to where the
> > > > final, reviewed userspace patches are that correspond to it (mailing
> > > > list link or gerrit or whatever).  I have an old gerrit link to some
> > > > in-development chromium/ozone patches for this from November 2nd, but
> > > > I'm not sure if there's a newer one now.
> > >
> > > IMO from user space the ABI is good. I think the question is more
> > > whether other hw would be fine with it. For example if we notice that
> > > other platforms can only do black as a background color, how can we
> > > make this API standard. Hopefully other folks can chime in here about
> > > other hw capabilities.
> >
> > black background is already the default, so "no prop" = "black
> > background". The problem is a bit figuring out whether you can make the
> > primary plane non-fullscreen, which atm is a TEST_ONLY guessing game for
> > userspace. We've discussed some "can_scale" and "can_position" properties
> > for that, but aside from reworking the helpers to check plane updates
> > nothing happened.
> > -Daniel
>
> Based on feedback from Brian and Eric, it sounds like the thing we need
> to get better clarity on is whether all hardware can apply pipe-level
> degamma/csc/gamma to the background color the same way it does to plane
> content (even for platforms where the background color is always a
> non-programmable black).
>
> My initial assumption (which I'll clarify in the kerneldoc) is that
> background color should be treated the same way as a plane filled with
> that solid color; i.e., it should go through the same pipe-level color
> transformations.  Based on Eric's email, it sounds like Raspberry Pi
> matches my assumption.  For Intel hardware, we have register bits that
> specify whether color management should be applied to the background
> color or not (they're not set today for gen9+, which I consider that a
> bug since it seems like inconsistent behavior; the first patch of my
> series addresses that).
>
> If there are any platforms that don't/can't apply degamma/csc/gamma to
> the background color (regardless of whether that background color is
> programmable or always fixed at black), we should probably find some way
> to make that known to userspace (maybe some extra immutable property?).

Nah, I'd say since most hw seems to have the background color before
the CRTC degamma/ctm/gamma stuff we can just require that the odd one
out manually feed the background color through the color stuff before
writing it to hardware. And updating it every time the gamma tables
change again ofc. We could even do a little helper for this and store
the post-color_mgmt background in the crtc_state. Offloading that to
userspace seems silly to me.
-Daniel

>
>
> Matt
>
> > >
> > > Stéphane
> > >
> > >
> > > >
> > > > Aside from satisfying the ABI/userspace requirements, we still need all
> > > > the patches to get reviewed by the upstream kernel devs.  An older
> > > > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> > > > been accepted yet.  Actually it looks like I never sent the latest
> > > > version of my series that incorporates some additional feedback from
> > > > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> > > > people are still out on holiday vacation at the moment, so if necessary
> > > > I'll start pinging IRC for reviews in a week or two when people are back
> > > > in office.
> > >
> >
> >
> > >
> > > >
> > > > Matt
> > > >
> > > > >
> > > > > > BTW, I've backported your kernel patch into Chrome OS and verified
> > > it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google
> > > Pixelbook with KBL graphics.
> > > > > >
> > > > > > Thanks,
> > > > > > Wei
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Stéphane Marchesin [mailto:[e-mail]]
> > > > > > Sent: Thursday, December 27, 2018 3:27 PM
> > > > > > To: Roper, Matthew D <[e-mail]>
> > > > > > Cc: intel-gfx <[e-mail]>; Li, Wei C <
> > > [e-mail]>; dri-devel <[e-mail]>
> > > > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > > > > >
> > > > > > Hey,
> > > > > >
> > > > > > Is there anything missing on the Chrome side to move forward with
> > > this series?
> > > > > >
> > > > > > Stéphane
> > > > > >
> > > > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <
> > > [e-mail]> wrote:
> > > > > > >
> > > > > > > Third version of the series previously posted here:
> > > > > > >
> > > > > > >
> > > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > > > > > html
> > > > > > >
> > > > > > > This version incorporates review feedback from Ville and Sean Paul.
> > > > > > >
> > > > > > > The first patch here can be merged whenever it receives review
> > > approval.
> > > > > > > The second and third patches still need to wait for opensource
> > > > > > > userspace to be ready before merging (there's ChromeOS work
> > > underway).
> > > > > > >
> > > > > > > Cc: [e-mail]
> > > > > > > Cc: Wei C Li <[e-mail]>
> > > > > > > Cc: Sean Paul <[e-mail]>
> > > > > > > Cc: Ville Syrjälä <[e-mail]>
> > > > > > >
> > > > > > > Matt Roper (3):
> > > > > > >   drm/i915: Force background color to black for gen9+ (v2)
> > > > > > >   drm: Add CRTC background color property (v2)
> > > > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > > > > > >
> > > > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > > > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > > > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > > > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > > > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > > > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > > > > > >  drivers/gpu/drm/i915/intel_display.c      | 40
> > > +++++++++++++++++++++++++++++++
> > > > > > >  include/drm/drm_blend.h                   |  1 +
> > > > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > > > > > >  include/drm/drm_mode_config.h             |  5 ++++
> > > > > > >  include/uapi/drm/drm_mode.h               | 28
> > > ++++++++++++++++++++++
> > > > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > > > > > >
> > > > > > > --
> > > > > > > 2.14.4
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > Intel-gfx mailing list
> > > > > > > [e-mail]
> > > > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > >
> > > > --
> > > > Matt Roper
> > > > Graphics Software Engineer
> > > > IoTG Platform Enabling & Development
> > > > Intel Corporation
> > > > [phone]
> > > _______________________________________________
> > > dri-devel mailing list
> > > [e-mail]
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > >
>
> >    Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin
> >    <[1][e-mail]> geschrieben:
> >
> >      On Thu, Dec 27, 2018 at 4:45 PM Matt Roper
> >      <[2][e-mail]> wrote:
> >      >
> >      > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> >      > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[3][e-mail]>
> >      wrote:
> >      > > >
> >      > > > Matt,
> >      > > >
> >      > > > Is that possible for you to get some time to review
> >      [4]https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> >      and confirm the FROMLIST change if it looks good to you so we could move
> >      forward?
> >      > > >
> >      > >
> >      > > To be more precise, I am trying to assess what's needed before this
> >      > > patch goes usptream, and in particular, I'd like to know if we are
> >      > > blocked on any Chrome-side thing.
> >      > >
> >      > > Stéphane
> >      > >
> >      >
> >      > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> >      > from the ChromeOS userspace team on the ABI, plus a pointer to where
> >      the
> >      > final, reviewed userspace patches are that correspond to it (mailing
> >      > list link or gerrit or whatever).  I have an old gerrit link to some
> >      > in-development chromium/ozone patches for this from November 2nd, but
> >      > I'm not sure if there's a newer one now.
> >
> >      IMO from user space the ABI is good. I think the question is more
> >      whether other hw would be fine with it. For example if we notice that
> >      other platforms can only do black as a background color, how can we
> >      make this API standard. Hopefully other folks can chime in here about
> >      other hw capabilities.
> >
> >      Stéphane
> >
> >      >
> >      > Aside from satisfying the ABI/userspace requirements, we still need
> >      all
> >      > the patches to get reviewed by the upstream kernel devs.  An older
> >      > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> >      > been accepted yet.  Actually it looks like I never sent the latest
> >      > version of my series that incorporates some additional feedback from
> >      > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> >      > people are still out on holiday vacation at the moment, so if
> >      necessary
> >      > I'll start pinging IRC for reviews in a week or two when people are
> >      back
> >      > in office.
> >
> >      >
> >      >
> >      > Matt
> >      >
> >      > >
> >      > > > BTW, I've backported your kernel patch into Chrome OS and verified
> >      it using the TEST=drm-tests/atomictest -t crtc_background_color on a
> >      Google Pixelbook with KBL graphics.
> >      > > >
> >      > > > Thanks,
> >      > > > Wei
> >      > > >
> >      > > > -----Original Message-----
> >      > > > From: Stéphane Marchesin [mailto:[5][e-mail]]
> >      > > > Sent: Thursday, December 27, 2018 3:27 PM
> >      > > > To: Roper, Matthew D <[6][e-mail]>
> >      > > > Cc: intel-gfx <[7][e-mail]>; Li, Wei C
> >      <[8][e-mail]>; dri-devel <[9][e-mail]>
> >      > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> >      > > >
> >      > > > Hey,
> >      > > >
> >      > > > Is there anything missing on the Chrome side to move forward with
> >      this series?
> >      > > >
> >      > > > Stéphane
> >      > > >
> >      > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper
> >      <[10][e-mail]> wrote:
> >      > > > >
> >      > > > > Third version of the series previously posted here:
> >      > > > >
> >      > > > >
> >      [11]https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> >      > > > > html
> >      > > > >
> >      > > > > This version incorporates review feedback from Ville and Sean
> >      Paul.
> >      > > > >
> >      > > > > The first patch here can be merged whenever it receives review
> >      approval.
> >      > > > > The second and third patches still need to wait for opensource
> >      > > > > userspace to be ready before merging (there's ChromeOS work
> >      underway).
> >      > > > >
> >      > > > > Cc: [12][e-mail]
> >      > > > > Cc: Wei C Li <[13][e-mail]>
> >      > > > > Cc: Sean Paul <[e-mail]>
> >      > > > > Cc: Ville Syrjälä <[14][e-mail]>
> >      > > > >
> >      > > > > Matt Roper (3):
> >      > > > >   drm/i915: Force background color to black for gen9+ (v2)
> >      > > > >   drm: Add CRTC background color property (v2)
> >      > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> >      > > > >
> >      > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> >      > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> >      > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> >      > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> >      > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> >      > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> >      > > > >  drivers/gpu/drm/i915/intel_display.c      | 40
> >      +++++++++++++++++++++++++++++++
> >      > > > >  include/drm/drm_blend.h                   |  1 +
> >      > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> >      > > > >  include/drm/drm_mode_config.h             |  5 ++++
> >      > > > >  include/uapi/drm/drm_mode.h               | 28
> >      ++++++++++++++++++++++
> >      > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> >      > > > >
> >      > > > > --
> >      > > > > 2.14.4
> >      > > > >
> >      > > > > _______________________________________________
> >      > > > > Intel-gfx mailing list
> >      > > > > [15][e-mail]
> >      > > > > [16]https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >      >
> >      > --
> >      > Matt Roper
> >      > Graphics Software Engineer
> >      > IoTG Platform Enabling & Development
> >      > Intel Corporation
> >      > [phone]
> >      _______________________________________________
> >      dri-devel mailing list
> >      [17][e-mail]
> >      [18]https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> > References
> >
> >    Visible links
> >    1. mailto:[e-mail]
> >    2. mailto:[e-mail]
> >    3. mailto:[e-mail]
> >    4. https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> >    5. mailto:[e-mail]
> >    6. mailto:[e-mail]
> >    7. mailto:[e-mail]
> >    8. mailto:[e-mail]
> >    9. mailto:[e-mail]
> >   10. mailto:[e-mail]
> >   11. https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777
> >   12. mailto:[e-mail]
> >   13. mailto:[e-mail]
> >   14. mailto:[e-mail]
> >   15. mailto:[e-mail]
> >   16. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >   17. mailto:[e-mail]
> >   18. https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
> --
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> [phone]

Matt Roper Dec. 28, 2018, 5:19 p.m. UTC | #9

On Fri, Dec 28, 2018 at 06:14:40PM +0100, Daniel Vetter wrote:
> On Fri, Dec 28, 2018 at 5:35 PM Matt Roper <[e-mail]> wrote:
> >
> > On Fri, Dec 28, 2018 at 12:53:29PM +0100, Daniel Vetter wrote:
> > > Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin <[e-mail]>
> > > geschrieben:
> > > > On Thu, Dec 27, 2018 at 4:45 PM Matt Roper <[e-mail]>
> > > > wrote:
> > > > >
> > > > > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > > > > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
> > > > > > >
> > > > > > > Matt,
> > > > > > >
> > > > > > > Is that possible for you to get some time to review
> > > > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> > > > and confirm the FROMLIST change if it looks good to you so we could move
> > > > forward?
> > > > > > >
> > > > > >
> > > > > > To be more precise, I am trying to assess what's needed before this
> > > > > > patch goes usptream, and in particular, I'd like to know if we are
> > > > > > blocked on any Chrome-side thing.
> > > > > >
> > > > > > Stéphane
> > > > > >
> > > > >
> > > > > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> > > > > from the ChromeOS userspace team on the ABI, plus a pointer to where the
> > > > > final, reviewed userspace patches are that correspond to it (mailing
> > > > > list link or gerrit or whatever).  I have an old gerrit link to some
> > > > > in-development chromium/ozone patches for this from November 2nd, but
> > > > > I'm not sure if there's a newer one now.
> > > >
> > > > IMO from user space the ABI is good. I think the question is more
> > > > whether other hw would be fine with it. For example if we notice that
> > > > other platforms can only do black as a background color, how can we
> > > > make this API standard. Hopefully other folks can chime in here about
> > > > other hw capabilities.
> > >
> > > black background is already the default, so "no prop" = "black
> > > background". The problem is a bit figuring out whether you can make the
> > > primary plane non-fullscreen, which atm is a TEST_ONLY guessing game for
> > > userspace. We've discussed some "can_scale" and "can_position" properties
> > > for that, but aside from reworking the helpers to check plane updates
> > > nothing happened.
> > > -Daniel
> >
> > Based on feedback from Brian and Eric, it sounds like the thing we need
> > to get better clarity on is whether all hardware can apply pipe-level
> > degamma/csc/gamma to the background color the same way it does to plane
> > content (even for platforms where the background color is always a
> > non-programmable black).
> >
> > My initial assumption (which I'll clarify in the kerneldoc) is that
> > background color should be treated the same way as a plane filled with
> > that solid color; i.e., it should go through the same pipe-level color
> > transformations.  Based on Eric's email, it sounds like Raspberry Pi
> > matches my assumption.  For Intel hardware, we have register bits that
> > specify whether color management should be applied to the background
> > color or not (they're not set today for gen9+, which I consider that a
> > bug since it seems like inconsistent behavior; the first patch of my
> > series addresses that).
> >
> > If there are any platforms that don't/can't apply degamma/csc/gamma to
> > the background color (regardless of whether that background color is
> > programmable or always fixed at black), we should probably find some way
> > to make that known to userspace (maybe some extra immutable property?).
> 
> Nah, I'd say since most hw seems to have the background color before
> the CRTC degamma/ctm/gamma stuff we can just require that the odd one
> out manually feed the background color through the color stuff before
> writing it to hardware. And updating it every time the gamma tables
> change again ofc. We could even do a little helper for this and store
> the post-color_mgmt background in the crtc_state. Offloading that to
> userspace seems silly to me.
> -Daniel

I think the only problem would be if we come across hardware that has a
non-programmable (always black) background colors that also doesn't pass
its background black through the gamma/csc pipeline.


Matt

> 
> >
> >
> > Matt
> >
> > > >
> > > > Stéphane
> > > >
> > > >
> > > > >
> > > > > Aside from satisfying the ABI/userspace requirements, we still need all
> > > > > the patches to get reviewed by the upstream kernel devs.  An older
> > > > > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> > > > > been accepted yet.  Actually it looks like I never sent the latest
> > > > > version of my series that incorporates some additional feedback from
> > > > > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> > > > > people are still out on holiday vacation at the moment, so if necessary
> > > > > I'll start pinging IRC for reviews in a week or two when people are back
> > > > > in office.
> > > >
> > >
> > >
> > > >
> > > > >
> > > > > Matt
> > > > >
> > > > > >
> > > > > > > BTW, I've backported your kernel patch into Chrome OS and verified
> > > > it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google
> > > > Pixelbook with KBL graphics.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Wei
> > > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Stéphane Marchesin [mailto:[e-mail]]
> > > > > > > Sent: Thursday, December 27, 2018 3:27 PM
> > > > > > > To: Roper, Matthew D <[e-mail]>
> > > > > > > Cc: intel-gfx <[e-mail]>; Li, Wei C <
> > > > [e-mail]>; dri-devel <[e-mail]>
> > > > > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > > > > > >
> > > > > > > Hey,
> > > > > > >
> > > > > > > Is there anything missing on the Chrome side to move forward with
> > > > this series?
> > > > > > >
> > > > > > > Stéphane
> > > > > > >
> > > > > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <
> > > > [e-mail]> wrote:
> > > > > > > >
> > > > > > > > Third version of the series previously posted here:
> > > > > > > >
> > > > > > > >
> > > > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > > > > > > html
> > > > > > > >
> > > > > > > > This version incorporates review feedback from Ville and Sean Paul.
> > > > > > > >
> > > > > > > > The first patch here can be merged whenever it receives review
> > > > approval.
> > > > > > > > The second and third patches still need to wait for opensource
> > > > > > > > userspace to be ready before merging (there's ChromeOS work
> > > > underway).
> > > > > > > >
> > > > > > > > Cc: [e-mail]
> > > > > > > > Cc: Wei C Li <[e-mail]>
> > > > > > > > Cc: Sean Paul <[e-mail]>
> > > > > > > > Cc: Ville Syrjälä <[e-mail]>
> > > > > > > >
> > > > > > > > Matt Roper (3):
> > > > > > > >   drm/i915: Force background color to black for gen9+ (v2)
> > > > > > > >   drm: Add CRTC background color property (v2)
> > > > > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > > > > > > >
> > > > > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > > > > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > > > > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > > > > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > > > > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > > > > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > > > > > > >  drivers/gpu/drm/i915/intel_display.c      | 40
> > > > +++++++++++++++++++++++++++++++
> > > > > > > >  include/drm/drm_blend.h                   |  1 +
> > > > > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > > > > > > >  include/drm/drm_mode_config.h             |  5 ++++
> > > > > > > >  include/uapi/drm/drm_mode.h               | 28
> > > > ++++++++++++++++++++++
> > > > > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > > > > > > >
> > > > > > > > --
> > > > > > > > 2.14.4
> > > > > > > >
> > > > > > > > _______________________________________________
> > > > > > > > Intel-gfx mailing list
> > > > > > > > [e-mail]
> > > > > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > > >
> > > > > --
> > > > > Matt Roper
> > > > > Graphics Software Engineer
> > > > > IoTG Platform Enabling & Development
> > > > > Intel Corporation
> > > > > [phone]
> > > > _______________________________________________
> > > > dri-devel mailing list
> > > > [e-mail]
> > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > >
> >
> > >    Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin
> > >    <[1][e-mail]> geschrieben:
> > >
> > >      On Thu, Dec 27, 2018 at 4:45 PM Matt Roper
> > >      <[2][e-mail]> wrote:
> > >      >
> > >      > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > >      > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[3][e-mail]>
> > >      wrote:
> > >      > > >
> > >      > > > Matt,
> > >      > > >
> > >      > > > Is that possible for you to get some time to review
> > >      [4]https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> > >      and confirm the FROMLIST change if it looks good to you so we could move
> > >      forward?
> > >      > > >
> > >      > >
> > >      > > To be more precise, I am trying to assess what's needed before this
> > >      > > patch goes usptream, and in particular, I'd like to know if we are
> > >      > > blocked on any Chrome-side thing.
> > >      > >
> > >      > > Stéphane
> > >      > >
> > >      >
> > >      > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> > >      > from the ChromeOS userspace team on the ABI, plus a pointer to where
> > >      the
> > >      > final, reviewed userspace patches are that correspond to it (mailing
> > >      > list link or gerrit or whatever).  I have an old gerrit link to some
> > >      > in-development chromium/ozone patches for this from November 2nd, but
> > >      > I'm not sure if there's a newer one now.
> > >
> > >      IMO from user space the ABI is good. I think the question is more
> > >      whether other hw would be fine with it. For example if we notice that
> > >      other platforms can only do black as a background color, how can we
> > >      make this API standard. Hopefully other folks can chime in here about
> > >      other hw capabilities.
> > >
> > >      Stéphane
> > >
> > >      >
> > >      > Aside from satisfying the ABI/userspace requirements, we still need
> > >      all
> > >      > the patches to get reviewed by the upstream kernel devs.  An older
> > >      > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> > >      > been accepted yet.  Actually it looks like I never sent the latest
> > >      > version of my series that incorporates some additional feedback from
> > >      > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> > >      > people are still out on holiday vacation at the moment, so if
> > >      necessary
> > >      > I'll start pinging IRC for reviews in a week or two when people are
> > >      back
> > >      > in office.
> > >
> > >      >
> > >      >
> > >      > Matt
> > >      >
> > >      > >
> > >      > > > BTW, I've backported your kernel patch into Chrome OS and verified
> > >      it using the TEST=drm-tests/atomictest -t crtc_background_color on a
> > >      Google Pixelbook with KBL graphics.
> > >      > > >
> > >      > > > Thanks,
> > >      > > > Wei
> > >      > > >
> > >      > > > -----Original Message-----
> > >      > > > From: Stéphane Marchesin [mailto:[5][e-mail]]
> > >      > > > Sent: Thursday, December 27, 2018 3:27 PM
> > >      > > > To: Roper, Matthew D <[6][e-mail]>
> > >      > > > Cc: intel-gfx <[7][e-mail]>; Li, Wei C
> > >      <[8][e-mail]>; dri-devel <[9][e-mail]>
> > >      > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > >      > > >
> > >      > > > Hey,
> > >      > > >
> > >      > > > Is there anything missing on the Chrome side to move forward with
> > >      this series?
> > >      > > >
> > >      > > > Stéphane
> > >      > > >
> > >      > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper
> > >      <[10][e-mail]> wrote:
> > >      > > > >
> > >      > > > > Third version of the series previously posted here:
> > >      > > > >
> > >      > > > >
> > >      [11]https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > >      > > > > html
> > >      > > > >
> > >      > > > > This version incorporates review feedback from Ville and Sean
> > >      Paul.
> > >      > > > >
> > >      > > > > The first patch here can be merged whenever it receives review
> > >      approval.
> > >      > > > > The second and third patches still need to wait for opensource
> > >      > > > > userspace to be ready before merging (there's ChromeOS work
> > >      underway).
> > >      > > > >
> > >      > > > > Cc: [12][e-mail]
> > >      > > > > Cc: Wei C Li <[13][e-mail]>
> > >      > > > > Cc: Sean Paul <[e-mail]>
> > >      > > > > Cc: Ville Syrjälä <[14][e-mail]>
> > >      > > > >
> > >      > > > > Matt Roper (3):
> > >      > > > >   drm/i915: Force background color to black for gen9+ (v2)
> > >      > > > >   drm: Add CRTC background color property (v2)
> > >      > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > >      > > > >
> > >      > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > >      > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > >      > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > >      > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > >      > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > >      > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > >      > > > >  drivers/gpu/drm/i915/intel_display.c      | 40
> > >      +++++++++++++++++++++++++++++++
> > >      > > > >  include/drm/drm_blend.h                   |  1 +
> > >      > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > >      > > > >  include/drm/drm_mode_config.h             |  5 ++++
> > >      > > > >  include/uapi/drm/drm_mode.h               | 28
> > >      ++++++++++++++++++++++
> > >      > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > >      > > > >
> > >      > > > > --
> > >      > > > > 2.14.4
> > >      > > > >
> > >      > > > > _______________________________________________
> > >      > > > > Intel-gfx mailing list
> > >      > > > > [15][e-mail]
> > >      > > > > [16]https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >      >
> > >      > --
> > >      > Matt Roper
> > >      > Graphics Software Engineer
> > >      > IoTG Platform Enabling & Development
> > >      > Intel Corporation
> > >      > [phone]
> > >      _______________________________________________
> > >      dri-devel mailing list
> > >      [17][e-mail]
> > >      [18]https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > >
> > > References
> > >
> > >    Visible links
> > >    1. mailto:[e-mail]
> > >    2. mailto:[e-mail]
> > >    3. mailto:[e-mail]
> > >    4. https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> > >    5. mailto:[e-mail]
> > >    6. mailto:[e-mail]
> > >    7. mailto:[e-mail]
> > >    8. mailto:[e-mail]
> > >    9. mailto:[e-mail]
> > >   10. mailto:[e-mail]
> > >   11. https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777
> > >   12. mailto:[e-mail]
> > >   13. mailto:[e-mail]
> > >   14. mailto:[e-mail]
> > >   15. mailto:[e-mail]
> > >   16. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > >   17. mailto:[e-mail]
> > >   18. https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> >
> > --
> > Matt Roper
> > Graphics Software Engineer
> > IoTG Platform Enabling & Development
> > Intel Corporation
> > [phone]
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> [phone] - http://blog.ffwll.ch

Daniel Vetter Dec. 28, 2018, 9 p.m. UTC | #10

On Fri, Dec 28, 2018 at 6:19 PM Matt Roper <[e-mail]> wrote:
>
> On Fri, Dec 28, 2018 at 06:14:40PM +0100, Daniel Vetter wrote:
> > On Fri, Dec 28, 2018 at 5:35 PM Matt Roper <[e-mail]> wrote:
> > >
> > > On Fri, Dec 28, 2018 at 12:53:29PM +0100, Daniel Vetter wrote:
> > > > Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin <[e-mail]>
> > > > geschrieben:
> > > > > On Thu, Dec 27, 2018 at 4:45 PM Matt Roper <[e-mail]>
> > > > > wrote:
> > > > > >
> > > > > > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > > > > > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[e-mail]> wrote:
> > > > > > > >
> > > > > > > > Matt,
> > > > > > > >
> > > > > > > > Is that possible for you to get some time to review
> > > > > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> > > > > and confirm the FROMLIST change if it looks good to you so we could move
> > > > > forward?
> > > > > > > >
> > > > > > >
> > > > > > > To be more precise, I am trying to assess what's needed before this
> > > > > > > patch goes usptream, and in particular, I'd like to know if we are
> > > > > > > blocked on any Chrome-side thing.
> > > > > > >
> > > > > > > Stéphane
> > > > > > >
> > > > > >
> > > > > > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> > > > > > from the ChromeOS userspace team on the ABI, plus a pointer to where the
> > > > > > final, reviewed userspace patches are that correspond to it (mailing
> > > > > > list link or gerrit or whatever).  I have an old gerrit link to some
> > > > > > in-development chromium/ozone patches for this from November 2nd, but
> > > > > > I'm not sure if there's a newer one now.
> > > > >
> > > > > IMO from user space the ABI is good. I think the question is more
> > > > > whether other hw would be fine with it. For example if we notice that
> > > > > other platforms can only do black as a background color, how can we
> > > > > make this API standard. Hopefully other folks can chime in here about
> > > > > other hw capabilities.
> > > >
> > > > black background is already the default, so "no prop" = "black
> > > > background". The problem is a bit figuring out whether you can make the
> > > > primary plane non-fullscreen, which atm is a TEST_ONLY guessing game for
> > > > userspace. We've discussed some "can_scale" and "can_position" properties
> > > > for that, but aside from reworking the helpers to check plane updates
> > > > nothing happened.
> > > > -Daniel
> > >
> > > Based on feedback from Brian and Eric, it sounds like the thing we need
> > > to get better clarity on is whether all hardware can apply pipe-level
> > > degamma/csc/gamma to the background color the same way it does to plane
> > > content (even for platforms where the background color is always a
> > > non-programmable black).
> > >
> > > My initial assumption (which I'll clarify in the kerneldoc) is that
> > > background color should be treated the same way as a plane filled with
> > > that solid color; i.e., it should go through the same pipe-level color
> > > transformations.  Based on Eric's email, it sounds like Raspberry Pi
> > > matches my assumption.  For Intel hardware, we have register bits that
> > > specify whether color management should be applied to the background
> > > color or not (they're not set today for gen9+, which I consider that a
> > > bug since it seems like inconsistent behavior; the first patch of my
> > > series addresses that).
> > >
> > > If there are any platforms that don't/can't apply degamma/csc/gamma to
> > > the background color (regardless of whether that background color is
> > > programmable or always fixed at black), we should probably find some way
> > > to make that known to userspace (maybe some extra immutable property?).
> >
> > Nah, I'd say since most hw seems to have the background color before
> > the CRTC degamma/ctm/gamma stuff we can just require that the odd one
> > out manually feed the background color through the color stuff before
> > writing it to hardware. And updating it every time the gamma tables
> > change again ofc. We could even do a little helper for this and store
> > the post-color_mgmt background in the crtc_state. Offloading that to
> > userspace seems silly to me.
> > -Daniel
>
> I think the only problem would be if we come across hardware that has a
> non-programmable (always black) background colors that also doesn't pass
> its background black through the gamma/csc pipeline.

That just sounds broken. I guess in that case you don't get to use
both the color mgmt pipeline and have a non-fullscreen primary plane.
Mea culpa, build better hw :-)
-Daniel

>
>
> Matt
>
> >
> > >
> > >
> > > Matt
> > >
> > > > >
> > > > > Stéphane
> > > > >
> > > > >
> > > > > >
> > > > > > Aside from satisfying the ABI/userspace requirements, we still need all
> > > > > > the patches to get reviewed by the upstream kernel devs.  An older
> > > > > > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> > > > > > been accepted yet.  Actually it looks like I never sent the latest
> > > > > > version of my series that incorporates some additional feedback from
> > > > > > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> > > > > > people are still out on holiday vacation at the moment, so if necessary
> > > > > > I'll start pinging IRC for reviews in a week or two when people are back
> > > > > > in office.
> > > > >
> > > >
> > > >
> > > > >
> > > > > >
> > > > > > Matt
> > > > > >
> > > > > > >
> > > > > > > > BTW, I've backported your kernel patch into Chrome OS and verified
> > > > > it using the TEST=drm-tests/atomictest -t crtc_background_color on a Google
> > > > > Pixelbook with KBL graphics.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Wei
> > > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Stéphane Marchesin [mailto:[e-mail]]
> > > > > > > > Sent: Thursday, December 27, 2018 3:27 PM
> > > > > > > > To: Roper, Matthew D <[e-mail]>
> > > > > > > > Cc: intel-gfx <[e-mail]>; Li, Wei C <
> > > > > [e-mail]>; dri-devel <[e-mail]>
> > > > > > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > > > > > > >
> > > > > > > > Hey,
> > > > > > > >
> > > > > > > > Is there anything missing on the Chrome side to move forward with
> > > > > this series?
> > > > > > > >
> > > > > > > > Stéphane
> > > > > > > >
> > > > > > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper <
> > > > > [e-mail]> wrote:
> > > > > > > > >
> > > > > > > > > Third version of the series previously posted here:
> > > > > > > > >
> > > > > > > > >
> > > > > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > > > > > > > html
> > > > > > > > >
> > > > > > > > > This version incorporates review feedback from Ville and Sean Paul.
> > > > > > > > >
> > > > > > > > > The first patch here can be merged whenever it receives review
> > > > > approval.
> > > > > > > > > The second and third patches still need to wait for opensource
> > > > > > > > > userspace to be ready before merging (there's ChromeOS work
> > > > > underway).
> > > > > > > > >
> > > > > > > > > Cc: [e-mail]
> > > > > > > > > Cc: Wei C Li <[e-mail]>
> > > > > > > > > Cc: Sean Paul <[e-mail]>
> > > > > > > > > Cc: Ville Syrjälä <[e-mail]>
> > > > > > > > >
> > > > > > > > > Matt Roper (3):
> > > > > > > > >   drm/i915: Force background color to black for gen9+ (v2)
> > > > > > > > >   drm: Add CRTC background color property (v2)
> > > > > > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > > > > > > > >
> > > > > > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > > > > > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > > > > > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > > > > > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > > > > > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > > > > > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > > > > > > > >  drivers/gpu/drm/i915/intel_display.c      | 40
> > > > > +++++++++++++++++++++++++++++++
> > > > > > > > >  include/drm/drm_blend.h                   |  1 +
> > > > > > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > > > > > > > >  include/drm/drm_mode_config.h             |  5 ++++
> > > > > > > > >  include/uapi/drm/drm_mode.h               | 28
> > > > > ++++++++++++++++++++++
> > > > > > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > 2.14.4
> > > > > > > > >
> > > > > > > > > _______________________________________________
> > > > > > > > > Intel-gfx mailing list
> > > > > > > > > [e-mail]
> > > > > > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > > > >
> > > > > > --
> > > > > > Matt Roper
> > > > > > Graphics Software Engineer
> > > > > > IoTG Platform Enabling & Development
> > > > > > Intel Corporation
> > > > > > [phone]
> > > > > _______________________________________________
> > > > > dri-devel mailing list
> > > > > [e-mail]
> > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > > >
> > >
> > > >    Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin
> > > >    <[1][e-mail]> geschrieben:
> > > >
> > > >      On Thu, Dec 27, 2018 at 4:45 PM Matt Roper
> > > >      <[2][e-mail]> wrote:
> > > >      >
> > > >      > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote:
> > > >      > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C <[3][e-mail]>
> > > >      wrote:
> > > >      > > >
> > > >      > > > Matt,
> > > >      > > >
> > > >      > > > Is that possible for you to get some time to review
> > > >      [4]https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> > > >      and confirm the FROMLIST change if it looks good to you so we could move
> > > >      forward?
> > > >      > > >
> > > >      > >
> > > >      > > To be more precise, I am trying to assess what's needed before this
> > > >      > > patch goes usptream, and in particular, I'd like to know if we are
> > > >      > > blocked on any Chrome-side thing.
> > > >      > >
> > > >      > > Stéphane
> > > >      > >
> > > >      >
> > > >      > Hi Stéphane.  On the Chrome side of things, I believe we need an Ack
> > > >      > from the ChromeOS userspace team on the ABI, plus a pointer to where
> > > >      the
> > > >      > final, reviewed userspace patches are that correspond to it (mailing
> > > >      > list link or gerrit or whatever).  I have an old gerrit link to some
> > > >      > in-development chromium/ozone patches for this from November 2nd, but
> > > >      > I'm not sure if there's a newer one now.
> > > >
> > > >      IMO from user space the ABI is good. I think the question is more
> > > >      whether other hw would be fine with it. For example if we notice that
> > > >      other platforms can only do black as a background color, how can we
> > > >      make this API standard. Hopefully other folks can chime in here about
> > > >      other hw capabilities.
> > > >
> > > >      Stéphane
> > > >
> > > >      >
> > > >      > Aside from satisfying the ABI/userspace requirements, we still need
> > > >      all
> > > >      > the patches to get reviewed by the upstream kernel devs.  An older
> > > >      > version of patch #2 has a r-b from Sean, but patches 1 and 3 haven't
> > > >      > been accepted yet.  Actually it looks like I never sent the latest
> > > >      > version of my series that incorporates some additional feedback from
> > > >      > Brian Starkey to the list; I'll do that tomorrow.  I think a lot of
> > > >      > people are still out on holiday vacation at the moment, so if
> > > >      necessary
> > > >      > I'll start pinging IRC for reviews in a week or two when people are
> > > >      back
> > > >      > in office.
> > > >
> > > >      >
> > > >      >
> > > >      > Matt
> > > >      >
> > > >      > >
> > > >      > > > BTW, I've backported your kernel patch into Chrome OS and verified
> > > >      it using the TEST=drm-tests/atomictest -t crtc_background_color on a
> > > >      Google Pixelbook with KBL graphics.
> > > >      > > >
> > > >      > > > Thanks,
> > > >      > > > Wei
> > > >      > > >
> > > >      > > > -----Original Message-----
> > > >      > > > From: Stéphane Marchesin [mailto:[5][e-mail]]
> > > >      > > > Sent: Thursday, December 27, 2018 3:27 PM
> > > >      > > > To: Roper, Matthew D <[6][e-mail]>
> > > >      > > > Cc: intel-gfx <[7][e-mail]>; Li, Wei C
> > > >      <[8][e-mail]>; dri-devel <[9][e-mail]>
> > > >      > > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color
> > > >      > > >
> > > >      > > > Hey,
> > > >      > > >
> > > >      > > > Is there anything missing on the Chrome side to move forward with
> > > >      this series?
> > > >      > > >
> > > >      > > > Stéphane
> > > >      > > >
> > > >      > > > On Thu, Nov 15, 2018 at 2:14 PM Matt Roper
> > > >      <[10][e-mail]> wrote:
> > > >      > > > >
> > > >      > > > > Third version of the series previously posted here:
> > > >      > > > >
> > > >      > > > >
> > > >      [11]https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.
> > > >      > > > > html
> > > >      > > > >
> > > >      > > > > This version incorporates review feedback from Ville and Sean
> > > >      Paul.
> > > >      > > > >
> > > >      > > > > The first patch here can be merged whenever it receives review
> > > >      approval.
> > > >      > > > > The second and third patches still need to wait for opensource
> > > >      > > > > userspace to be ready before merging (there's ChromeOS work
> > > >      underway).
> > > >      > > > >
> > > >      > > > > Cc: [12][e-mail]
> > > >      > > > > Cc: Wei C Li <[13][e-mail]>
> > > >      > > > > Cc: Sean Paul <[e-mail]>
> > > >      > > > > Cc: Ville Syrjälä <[14][e-mail]>
> > > >      > > > >
> > > >      > > > > Matt Roper (3):
> > > >      > > > >   drm/i915: Force background color to black for gen9+ (v2)
> > > >      > > > >   drm: Add CRTC background color property (v2)
> > > >      > > > >   drm/i915/gen9+: Add support for pipe background color (v3)
> > > >      > > > >
> > > >      > > > >  drivers/gpu/drm/drm_atomic_state_helper.c |  1 +
> > > >      > > > >  drivers/gpu/drm/drm_atomic_uapi.c         |  5 ++++
> > > >      > > > >  drivers/gpu/drm/drm_blend.c               | 21 +++++++++++++---
> > > >      > > > >  drivers/gpu/drm/drm_mode_config.c         |  6 +++++
> > > >      > > > >  drivers/gpu/drm/i915/i915_debugfs.c       |  9 +++++++
> > > >      > > > >  drivers/gpu/drm/i915/i915_reg.h           |  6 +++++
> > > >      > > > >  drivers/gpu/drm/i915/intel_display.c      | 40
> > > >      +++++++++++++++++++++++++++++++
> > > >      > > > >  include/drm/drm_blend.h                   |  1 +
> > > >      > > > >  include/drm/drm_crtc.h                    | 17 +++++++++++++
> > > >      > > > >  include/drm/drm_mode_config.h             |  5 ++++
> > > >      > > > >  include/uapi/drm/drm_mode.h               | 28
> > > >      ++++++++++++++++++++++
> > > >      > > > >  11 files changed, 136 insertions(+), 3 deletions(-)
> > > >      > > > >
> > > >      > > > > --
> > > >      > > > > 2.14.4
> > > >      > > > >
> > > >      > > > > _______________________________________________
> > > >      > > > > Intel-gfx mailing list
> > > >      > > > > [15][e-mail]
> > > >      > > > > [16]https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > >      >
> > > >      > --
> > > >      > Matt Roper
> > > >      > Graphics Software Engineer
> > > >      > IoTG Platform Enabling & Development
> > > >      > Intel Corporation
> > > >      > [phone]
> > > >      _______________________________________________
> > > >      dri-devel mailing list
> > > >      [17][e-mail]
> > > >      [18]https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > >
> > > > References
> > > >
> > > >    Visible links
> > > >    1. mailto:[e-mail]
> > > >    2. mailto:[e-mail]
> > > >    3. mailto:[e-mail]
> > > >    4. https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366
> > > >    5. mailto:[e-mail]
> > > >    6. mailto:[e-mail]
> > > >    7. mailto:[e-mail]
> > > >    8. mailto:[e-mail]
> > > >    9. mailto:[e-mail]
> > > >   10. mailto:[e-mail]
> > > >   11. https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777
> > > >   12. mailto:[e-mail]
> > > >   13. mailto:[e-mail]
> > > >   14. mailto:[e-mail]
> > > >   15. mailto:[e-mail]
> > > >   16. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > >   17. mailto:[e-mail]
> > > >   18. https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > >
> > >
> > > --
> > > Matt Roper
> > > Graphics Software Engineer
> > > IoTG Platform Enabling & Development
> > > Intel Corporation
> > > [phone]
> >
> >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > [phone] - http://blog.ffwll.ch
>
> --
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> [phone]