| Message ID | 20190102095154.25839-1-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4aac2bf0760d359af44e423dc01e10880d9d18b0 |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | [v2] arm64: defconfig: Enable R-Car thermal driver | expand |
On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@verge.net.au> wrote: > Enable the R-Car thermal driver as a built-in. > > This driver is used in conjunction with the R-Car V3M (r8a77970), > E3 (r8a77990) and D3 (r8a77995) SoCs. > [v2] Enable as a built-in rather than a module as this seems > safer from the point of view of protecting equipment from > overheating. Shouldn't the above paragraph be moved below the ---? > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@verge.net.au> wrote: > > Enable the R-Car thermal driver as a built-in. > > > > This driver is used in conjunction with the R-Car V3M (r8a77970), > > E3 (r8a77990) and D3 (r8a77995) SoCs. > > > [v2] Enable as a built-in rather than a module as this seems > > safer from the point of view of protecting equipment from > > overheating. > > Shouldn't the above paragraph be moved below the ---? I have recently come to believe that its a matter of taste. And I think in this case it captures important information that is worthy of inclusion in the changelog. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
Hi Simon, On Fri, Jan 4, 2019 at 9:57 AM Simon Horman <horms@verge.net.au> wrote: > On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote: > > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@verge.net.au> wrote: > > > Enable the R-Car thermal driver as a built-in. > > > > > > This driver is used in conjunction with the R-Car V3M (r8a77970), > > > E3 (r8a77990) and D3 (r8a77995) SoCs. > > > > > [v2] Enable as a built-in rather than a module as this seems > > > safer from the point of view of protecting equipment from > > > overheating. > > > > Shouldn't the above paragraph be moved below the ---? > > I have recently come to believe that its a matter of taste. And I think in > this case it captures important information that is worthy of inclusion in > the changelog. The rationale behind doing it this way could still be appended to the first line of the body of the patch decription. Gr{oetje,eeting}s, Geert
On Fri, Jan 04, 2019 at 10:01:13AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Jan 4, 2019 at 9:57 AM Simon Horman <horms@verge.net.au> wrote: > > On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote: > > > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@verge.net.au> wrote: > > > > Enable the R-Car thermal driver as a built-in. > > > > > > > > This driver is used in conjunction with the R-Car V3M (r8a77970), > > > > E3 (r8a77990) and D3 (r8a77995) SoCs. > > > > > > > [v2] Enable as a built-in rather than a module as this seems > > > > safer from the point of view of protecting equipment from > > > > overheating. > > > > > > Shouldn't the above paragraph be moved below the ---? > > > > I have recently come to believe that its a matter of taste. And I think in > > this case it captures important information that is worthy of inclusion in > > the changelog. > > The rationale behind doing it this way could still be appended to the > first line of the body of the patch decription. Sorry, I'm having a little trouble parsing that. Do you mean that it could be appended to the body of the changelog at apply-time?
Hi Simon, On Fri, Jan 4, 2019 at 10:12 AM Simon Horman <horms@verge.net.au> wrote: > On Fri, Jan 04, 2019 at 10:01:13AM +0100, Geert Uytterhoeven wrote: > > On Fri, Jan 4, 2019 at 9:57 AM Simon Horman <horms@verge.net.au> wrote: > > > On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote: > > > > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@verge.net.au> wrote: > > > > > Enable the R-Car thermal driver as a built-in. > > > > > > > > > > This driver is used in conjunction with the R-Car V3M (r8a77970), > > > > > E3 (r8a77990) and D3 (r8a77995) SoCs. > > > > > > > > > [v2] Enable as a built-in rather than a module as this seems > > > > > safer from the point of view of protecting equipment from > > > > > overheating. > > > > > > > > Shouldn't the above paragraph be moved below the ---? > > > > > > I have recently come to believe that its a matter of taste. And I think in > > > this case it captures important information that is worthy of inclusion in > > > the changelog. > > > > The rationale behind doing it this way could still be appended to the > > first line of the body of the patch decription. > > Sorry, I'm having a little trouble parsing that. Do you mean that it could > be appended to the body of the changelog at apply-time? I mean the rationale could have been part of the patch description, i.e. above the ---, e.g.: Subject: [PATCH v2] arm64: defconfig: Enable R-Car thermal driver Enable the R-Car thermal driver as a built-in. Built-in seems safer than modular from the point of view of protecting equipment from overheating. This driver is used in conjunction with the R-Car V3M (r8a77970), E3 (r8a77990) and D3 (r8a77995) SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2: - Switch from built-in to modular. arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) Gr{oetje,eeting}s, Geert
On Fri, Jan 04, 2019 at 10:17:15AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Jan 4, 2019 at 10:12 AM Simon Horman <horms@verge.net.au> wrote: > > On Fri, Jan 04, 2019 at 10:01:13AM +0100, Geert Uytterhoeven wrote: > > > On Fri, Jan 4, 2019 at 9:57 AM Simon Horman <horms@verge.net.au> wrote: > > > > On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote: > > > > > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman <horms+renesas@verge.net.au> wrote: > > > > > > Enable the R-Car thermal driver as a built-in. > > > > > > > > > > > > This driver is used in conjunction with the R-Car V3M (r8a77970), > > > > > > E3 (r8a77990) and D3 (r8a77995) SoCs. > > > > > > > > > > > [v2] Enable as a built-in rather than a module as this seems > > > > > > safer from the point of view of protecting equipment from > > > > > > overheating. > > > > > > > > > > Shouldn't the above paragraph be moved below the ---? > > > > > > > > I have recently come to believe that its a matter of taste. And I think in > > > > this case it captures important information that is worthy of inclusion in > > > > the changelog. > > > > > > The rationale behind doing it this way could still be appended to the > > > first line of the body of the patch decription. > > > > Sorry, I'm having a little trouble parsing that. Do you mean that it could > > be appended to the body of the changelog at apply-time? > > I mean the rationale could have been part of the patch description, i.e. > above the ---, e.g.: Thanks, I understand now. > > Subject: [PATCH v2] arm64: defconfig: Enable R-Car thermal driver > > Enable the R-Car thermal driver as a built-in. > Built-in seems safer than modular from the point of view of protecting > equipment from overheating. > > This driver is used in conjunction with the R-Car V3M (r8a77970), > E3 (r8a77990) and D3 (r8a77995) SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > v2: > - Switch from built-in to modular. > > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index a0801002b537..4530f50f06e5 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -377,6 +377,7 @@ CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y CONFIG_CPU_THERMAL=y CONFIG_THERMAL_EMULATION=y CONFIG_ROCKCHIP_THERMAL=m +CONFIG_RCAR_THERMAL=y CONFIG_RCAR_GEN3_THERMAL=y CONFIG_ARMADA_THERMAL=y CONFIG_BRCMSTB_THERMAL=m
Enable the R-Car thermal driver as a built-in. This driver is used in conjunction with the R-Car V3M (r8a77970), E3 (r8a77990) and D3 (r8a77995) SoCs. [v2] Enable as a built-in rather than a module as this seems safer from the point of view of protecting equipment from overheating. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) Based on renesas-devel-20190102-v4.20