| Message ID | 20190102184301.4222-1-aaro.koskinen@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | MIPS: OCTEON: mark RGMII interface disabled on OCTEON III | expand |
Hello, Aaro Koskinen wrote: > Commit 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx > interface detection") added RGMII interface detection for OCTEON III, > but it results in the following logs: > > [ 7.165984] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe > [ 7.173017] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe > > The current RGMII routines are valid only for older OCTEONS that > use GMX/ASX hardware blocks. On later chips AGL should be used, > but support for that is missing in the mainline. Until that is added, > mark the interface as disabled. > > Fixes: 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx interface detection") > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Applied to mips-fixes. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.burton@mips.com to report it. ]
diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon/executive/cvmx-helper.c index a76bbcc30f95..38e0444e57e8 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-helper.c +++ b/arch/mips/cavium-octeon/executive/cvmx-helper.c @@ -266,7 +266,8 @@ static cvmx_helper_interface_mode_t __cvmx_get_mode_cn7xxx(int interface) case 3: return CVMX_HELPER_INTERFACE_MODE_LOOP; case 4: - return CVMX_HELPER_INTERFACE_MODE_RGMII; + /* TODO: Implement support for AGL (RGMII). */ + return CVMX_HELPER_INTERFACE_MODE_DISABLED; default: return CVMX_HELPER_INTERFACE_MODE_DISABLED; }
Commit 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx interface detection") added RGMII interface detection for OCTEON III, but it results in the following logs: [ 7.165984] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe [ 7.173017] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe The current RGMII routines are valid only for older OCTEONS that use GMX/ASX hardware blocks. On later chips AGL should be used, but support for that is missing in the mainline. Until that is added, mark the interface as disabled. Fixes: 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx interface detection") Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)