diff mbox series

[3/7] RDMA/bnxt_re: Skip backing store allocation for 57500 series

Message ID 1546236607-15948-4-git-send-email-devesh.sharma@broadcom.com (mailing list archive)
State Superseded
Headers show
Series Add support Broadcom's 57500 series of adapters | expand

Commit Message

Devesh Sharma Dec. 31, 2018, 6:10 a.m. UTC 
The backing store to keep HW context data structures
is allocated and initialized by L2 driver. For 57500
chip RoCE driver do not require to allocate and initialize
additional memory. Changing to skip duplicate allocation
and initialization for 57500 adapters. Driver continues as
before for older chips.

This patch is also takes care of stats context memory alignment
to 128 boundary, a requirement for the 57500 series of chip.
Older chips do care of alignment, thus the change is unconditional.

Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/main.c       |  3 ++-
 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c |  6 ++++--
 drivers/infiniband/hw/bnxt_re/qplib_res.c  | 10 +++++++---
 drivers/infiniband/hw/bnxt_re/qplib_res.h  |  2 +-
 4 files changed, 14 insertions(+), 7 deletions(-)

Comments

Jason Gunthorpe Jan. 2, 2019, 8:57 p.m. UTC | #1 
On Mon, Dec 31, 2018 at 01:10:03AM -0500, Devesh Sharma wrote:
> The backing store to keep HW context data structures
> is allocated and initialized by L2 driver. For 57500
> chip RoCE driver do not require to allocate and initialize
> additional memory. Changing to skip duplicate allocation
> and initialization for 57500 adapters. Driver continues as
> before for older chips.
> 
> This patch is also takes care of stats context memory alignment
> to 128 boundary, a requirement for the 57500 series of chip.
> Older chips do care of alignment, thus the change is unconditional.

'do not care' ?

Jason
Devesh Sharma Jan. 3, 2019, 6:01 a.m. UTC | #2 
On Thu, Jan 3, 2019 at 2:27 AM Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> On Mon, Dec 31, 2018 at 01:10:03AM -0500, Devesh Sharma wrote:
> > The backing store to keep HW context data structures
> > is allocated and initialized by L2 driver. For 57500
> > chip RoCE driver do not require to allocate and initialize
> > additional memory. Changing to skip duplicate allocation
> > and initialization for 57500 adapters. Driver continues as
> > before for older chips.
> >
> > This patch is also takes care of stats context memory alignment
> > to 128 boundary, a requirement for the 57500 series of chip.
> > Older chips do care of alignment, thus the change is unconditional.
>
> 'do not care' ?
>
Another miss, realized after posting, will fix it
> Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index dd3f56a..63b97d9 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1405,7 +1405,8 @@  static int bnxt_re_ib_reg(struct bnxt_re_dev *rdev)
 	if (!rdev->is_virtfn)
 		bnxt_re_set_resource_limits(rdev);
 
-	rc = bnxt_qplib_alloc_ctx(rdev->en_dev->pdev, &rdev->qplib_ctx, 0);
+	rc = bnxt_qplib_alloc_ctx(rdev->en_dev->pdev, &rdev->qplib_ctx, 0,
+				  bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx));
 	if (rc) {
 		pr_err("Failed to allocate QPLIB context: %#x\n", rc);
 		goto disable_rcfw;
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
index e8472f3..d534824 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
@@ -481,11 +481,13 @@  int bnxt_qplib_init_rcfw(struct bnxt_qplib_rcfw *rcfw,
 	req.log2_dbr_pg_size = cpu_to_le16(PAGE_SHIFT -
 					   RCFW_DBR_BASE_PAGE_SHIFT);
 	/*
-	 * VFs need not setup the HW context area, PF
+	 * Gen P5 devices doesn't require this allocation
+	 * as the L2 driver does the same for RoCE also.
+	 * Also, VFs need not setup the HW context area, PF
 	 * shall setup this area for VF. Skipping the
 	 * HW programming
 	 */
-	if (is_virtfn)
+	if (is_virtfn || bnxt_qplib_is_chip_gen_p5(rcfw->res->cctx))
 		goto skip_ctx_setup;
 
 	level = ctx->qpc_tbl.level;
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index 59eeac5..00e466a 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -330,13 +330,13 @@  void bnxt_qplib_free_ctx(struct pci_dev *pdev,
  */
 int bnxt_qplib_alloc_ctx(struct pci_dev *pdev,
 			 struct bnxt_qplib_ctx *ctx,
-			 bool virt_fn)
+			 bool virt_fn, bool is_p5)
 {
 	int i, j, k, rc = 0;
 	int fnz_idx = -1;
 	__le64 **pbl_ptr;
 
-	if (virt_fn)
+	if (virt_fn || is_p5)
 		goto stats_alloc;
 
 	/* QPC Tables */
@@ -762,7 +762,11 @@  static int bnxt_qplib_alloc_stats_ctx(struct pci_dev *pdev,
 {
 	memset(stats, 0, sizeof(*stats));
 	stats->fw_id = -1;
-	stats->size = sizeof(struct ctx_hw_stats);
+	/* 128 byte aligned context memory is required only for 57500.
+	 * However making this unconditional, it does not harm previous
+	 * generation.
+	 */
+	stats->size = ALIGN(sizeof(struct ctx_hw_stats), 128);
 	stats->dma = dma_alloc_coherent(&pdev->dev, stats->size,
 					&stats->dma_map, GFP_KERNEL);
 	if (!stats->dma) {
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.h b/drivers/infiniband/hw/bnxt_re/qplib_res.h
index fa0fc8a..b2ee1b2 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.h
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.h
@@ -250,5 +250,5 @@  void bnxt_qplib_free_ctx(struct pci_dev *pdev,
 			 struct bnxt_qplib_ctx *ctx);
 int bnxt_qplib_alloc_ctx(struct pci_dev *pdev,
 			 struct bnxt_qplib_ctx *ctx,
-			 bool virt_fn);
+			 bool virt_fn, bool is_p5);
 #endif /* __BNXT_QPLIB_RES_H__ */