[kmod,0/2] testsuite: abstraction to compare file descriptor

Message

Yauheni Kaliuta Jan. 4, 2019, 9:41 p.m. UTC

Factor out common code to handle comparation of stdout/stderr to the
template.

The first patch is made to make reviewing of the change of the
original logic easier.

Yauheni Kaliuta (2):
  testsuite: track number of descriptors instead of their state
  testsuite: factor out fd related parameters to a structure

 testsuite/testsuite.c | 362 +++++++++++++++++++++++++-----------------
 1 file changed, 219 insertions(+), 143 deletions(-)

Comments

Lucas De Marchi Jan. 4, 2019, 10:40 p.m. UTC | #1

On Fri, Jan 04, 2019 at 11:41:32PM +0200, Yauheni Kaliuta wrote:
> Factor out common code to handle comparation of stdout/stderr to the
> template.
> 
> The first patch is made to make reviewing of the change of the
> original logic easier.

LGTM, thanks. I'll push them soon if they pass CI.

Lucas De Marchi

> 
> Yauheni Kaliuta (2):
>   testsuite: track number of descriptors instead of their state
>   testsuite: factor out fd related parameters to a structure
> 
>  testsuite/testsuite.c | 362 +++++++++++++++++++++++++-----------------
>  1 file changed, 219 insertions(+), 143 deletions(-)
> 
> -- 
> 2.20.0
>