| Message ID | 20190108191840.16007-1-jernej.skrabec@siol.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: sun8i: h3: Add ethernet0 alias to Beelink X2 | expand |
On Tue, Jan 08, 2019 at 08:18:40PM +0100, Jernej Skrabec wrote: > Because "ethernet0" alias is missing, U-Boot doesn't generate board > specific MAC address. Effect of this is random MAC address every boot > and thus new IP address is assigned to the board. > > Fix this by adding alias. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Applied, thanks! Maxime
On Wed, Jan 9, 2019 at 6:12 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Tue, Jan 08, 2019 at 08:18:40PM +0100, Jernej Skrabec wrote: > > Because "ethernet0" alias is missing, U-Boot doesn't generate board > > specific MAC address. Effect of this is random MAC address every boot > > and thus new IP address is assigned to the board. > > > > Fix this by adding alias. > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > Applied, thanks! > Maxime Might we add a fixes tag, so the patch gets backported? ChenYu
On Wed, Jan 09, 2019 at 06:13:24PM +0800, Chen-Yu Tsai wrote: > On Wed, Jan 9, 2019 at 6:12 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > On Tue, Jan 08, 2019 at 08:18:40PM +0100, Jernej Skrabec wrote: > > > Because "ethernet0" alias is missing, U-Boot doesn't generate board > > > specific MAC address. Effect of this is random MAC address every boot > > > and thus new IP address is assigned to the board. > > > > > > Fix this by adding alias. > > > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > > > Applied, thanks! > > Maxime > > Might we add a fixes tag, so the patch gets backported? It's done, thanks for the suggestion! Maxime
diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts index 5d23667dc2d2..671600d6bb53 100644 --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts @@ -54,6 +54,7 @@ aliases { serial0 = &uart0; /* ethernet0 is the H3 emac, defined in sun8i-h3.dtsi */ + ethernet0 = &emac; ethernet1 = &sdiowifi; };
Because "ethernet0" alias is missing, U-Boot doesn't generate board specific MAC address. Effect of this is random MAC address every boot and thus new IP address is assigned to the board. Fix this by adding alias. Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> --- arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 1 + 1 file changed, 1 insertion(+)