| Message ID | 1540540280-26612-1-git-send-email-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add support for MBIGEN generating message based SPIs | expand |
Hi Marc, Sorry for ping you... On 2018/10/26 15:51, Yang Yingliang wrote: > Now MBIGENs have pins that used to generate SPIs, > with > 5052875 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI controller"), > we can support MBIGEN to generate message based SPIs by writing > GICD_SETSPIR. This patchset add support for MBIGEN generating > message based SPIs and a bugfix for MBI driver. What's you suggestion for this patch set? We would like your input for next steps. > > > Patch #1 is a bugfix for MBI driver. At least this patch can be merged first as it's an obvious bug, without this patch, the MBI dirver can't work I think because the mutex lock is not initialized. Thanks Hanjun
Hi Hanjun, On 09/01/2019 10:18, Hanjun Guo wrote: > Hi Marc, > > Sorry for ping you... > > On 2018/10/26 15:51, Yang Yingliang wrote: >> Now MBIGENs have pins that used to generate SPIs, >> with >> 5052875 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI controller"), >> we can support MBIGEN to generate message based SPIs by writing >> GICD_SETSPIR. This patchset add support for MBIGEN generating >> message based SPIs and a bugfix for MBI driver. > > What's you suggestion for this patch set? We would like your input > for next steps. > >> >> >> Patch #1 is a bugfix for MBI driver. > > At least this patch can be merged first as it's an obvious bug, > without this patch, the MBI dirver can't work I think because > the mutex lock is not initialized. I dropped the ball on that one. Let me have a quick look. Thanks, M.
Now MBIGENs have pins that used to generate SPIs, with 5052875 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI controller"), we can support MBIGEN to generate message based SPIs by writing GICD_SETSPIR. This patchset add support for MBIGEN generating message based SPIs and a bugfix for MBI driver. Patch #1 is a bugfix for MBI driver. Pathc #2 ~ #4 is support for MBIGEN generating message based SPIs. v2: Move the doorbell address comments to the top. Yang Yingliang (4): irqchip/gic-v3-mbi: fix uninitialized mbi_lock irqchip/mbigen: rename register marcros irqchip/mbigen: add support for a MBIGEN generating SPIs dt-bindings/irqchip/mbigen: add example of MBIGEN generate SPIs .../interrupt-controller/hisilicon,mbigen-v2.txt | 17 +++++++- drivers/irqchip/irq-gic-v3-mbi.c | 2 +- drivers/irqchip/irq-mbigen.c | 47 +++++++++++++++------- 3 files changed, 50 insertions(+), 16 deletions(-)