[0/3] crypto: authenc - fix key parsing

Message

Eric Biggers Dec. 17, 2018, 7:23 a.m. UTC

Fix incorrect validation of the key passed to "authenc" AEADs that
allowed crashing the kernel via AF_ALG.  The real fix is in patch 1, but
two drivers had to be converted to use crypto_authenc_extractkeys() too.

Please note: for the bcm and ccree driver changes I haven't re-run the
self-tests, as I don't have that hardware.  Please do so if you can.

Eric Biggers (3):
  crypto: authenc - fix parsing key with misaligned rta_len
  crypto: bcm - convert to use crypto_authenc_extractkeys()
  crypto: ccree - convert to use crypto_authenc_extractkeys()

 crypto/authenc.c               | 14 ++++++++---
 drivers/crypto/Kconfig         |  1 +
 drivers/crypto/bcm/cipher.c    | 44 ++++++++++------------------------
 drivers/crypto/ccree/cc_aead.c | 40 +++++++++++++++----------------
 4 files changed, 44 insertions(+), 55 deletions(-)

Comments

Herbert Xu Jan. 10, 2019, 2:03 p.m. UTC | #1

On Sun, Dec 16, 2018 at 11:23:21PM -0800, Eric Biggers wrote:
> Fix incorrect validation of the key passed to "authenc" AEADs that
> allowed crashing the kernel via AF_ALG.  The real fix is in patch 1, but
> two drivers had to be converted to use crypto_authenc_extractkeys() too.
> 
> Please note: for the bcm and ccree driver changes I haven't re-run the
> self-tests, as I don't have that hardware.  Please do so if you can.
> 
> Eric Biggers (3):
>   crypto: authenc - fix parsing key with misaligned rta_len
>   crypto: bcm - convert to use crypto_authenc_extractkeys()
>   crypto: ccree - convert to use crypto_authenc_extractkeys()
> 
>  crypto/authenc.c               | 14 ++++++++---
>  drivers/crypto/Kconfig         |  1 +
>  drivers/crypto/bcm/cipher.c    | 44 ++++++++++------------------------
>  drivers/crypto/ccree/cc_aead.c | 40 +++++++++++++++----------------
>  4 files changed, 44 insertions(+), 55 deletions(-)

All applied.  Thanks.