| Message ID | eb98d6f510cd93e45d7832837acd4e5811f3d20e.1543374820.git.gustavo@embeddedor.com (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
| Series | scsi: Mark expected switch fall-throughs | expand |
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/scsi/esas2r/esas2r_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c > index 46b2c83ba21f..950cd92df2ff 100644 > --- a/drivers/scsi/esas2r/esas2r_init.c > +++ b/drivers/scsi/esas2r/esas2r_init.c > @@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a, > a->init_msg = ESAS2R_INIT_MSG_GET_INIT; > break; > } > + /* fall through */ > > case ESAS2R_INIT_MSG_GET_INIT: > if (msg == ESAS2R_INIT_MSG_GET_INIT) { > @@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a, > esas2r_hdebug("FAILED"); > } > } > - /* fall through */ > + /* fall through */ > > default: > rq->req_stat = RS_SUCCESS; >
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping: > > Who can ack or review this patch, please? > > Thanks > -- > Gustavo > > On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/scsi/esas2r/esas2r_init.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c >> index 46b2c83ba21f..950cd92df2ff 100644 >> --- a/drivers/scsi/esas2r/esas2r_init.c >> +++ b/drivers/scsi/esas2r/esas2r_init.c >> @@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a, >> a->init_msg = ESAS2R_INIT_MSG_GET_INIT; >> break; >> } >> + /* fall through */ >> case ESAS2R_INIT_MSG_GET_INIT: >> if (msg == ESAS2R_INIT_MSG_GET_INIT) { >> @@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a, >> esas2r_hdebug("FAILED"); >> } >> } >> - /* fall through */ >> + /* fall through */ >> default: >> rq->req_stat = RS_SUCCESS; >>
Acked-by: Bradley Grove <bgrove@atto.com> On 1/10/2019 3:08 PM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping (second one): > > Who can ack/review/take this patch, please? > > Thanks > -- > Gustavo > > On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: >> Hi, >> >> Friendly ping: >> >> Who can ack or review this patch, please? >> >> Thanks >> -- >> Gustavo >> >> On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >>> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >>> --- >>> drivers/scsi/esas2r/esas2r_init.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/scsi/esas2r/esas2r_init.c >>> b/drivers/scsi/esas2r/esas2r_init.c >>> index 46b2c83ba21f..950cd92df2ff 100644 >>> --- a/drivers/scsi/esas2r/esas2r_init.c >>> +++ b/drivers/scsi/esas2r/esas2r_init.c >>> @@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct >>> esas2r_adapter *a, >>> a->init_msg = ESAS2R_INIT_MSG_GET_INIT; >>> break; >>> } >>> + /* fall through */ >>> case ESAS2R_INIT_MSG_GET_INIT: >>> if (msg == ESAS2R_INIT_MSG_GET_INIT) { >>> @@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct >>> esas2r_adapter *a, >>> esas2r_hdebug("FAILED"); >>> } >>> } >>> - /* fall through */ >>> + /* fall through */ >>> default: >>> rq->req_stat = RS_SUCCESS; >>> This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.
Gustavo, > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. Applied to 5.1/scsi-queue.
diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c index 46b2c83ba21f..950cd92df2ff 100644 --- a/drivers/scsi/esas2r/esas2r_init.c +++ b/drivers/scsi/esas2r/esas2r_init.c @@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a, a->init_msg = ESAS2R_INIT_MSG_GET_INIT; break; } + /* fall through */ case ESAS2R_INIT_MSG_GET_INIT: if (msg == ESAS2R_INIT_MSG_GET_INIT) { @@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a, esas2r_hdebug("FAILED"); } } - /* fall through */ + /* fall through */ default: rq->req_stat = RS_SUCCESS;
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/scsi/esas2r/esas2r_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)