| Message ID | 09026c2661bf3c4bcf41dbb265cf1dae2c3487fd.1543374820.git.gustavo@embeddedor.com (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
| Series | scsi: Mark expected switch fall-throughs | expand |
On 28/11/18 06:32, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> ACK-by: Boaz Harrosh <ooo@electrozaur.com> > --- > drivers/scsi/osd/osd_initiator.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c > index 60cf7c5eb880..cb26f26d5ec1 100644 > --- a/drivers/scsi/osd/osd_initiator.c > +++ b/drivers/scsi/osd/osd_initiator.c > @@ -1849,6 +1849,7 @@ int osd_req_decode_sense_full(struct osd_request *or, > 32, 1, dump, sizeof(dump), true); > OSD_SENSE_PRINT2("response_integrity [%s]\n", dump); > } > + /* fall through */ > case osd_sense_attribute_identification: > { > struct osd_sense_attributes_data_descriptor > @@ -1879,7 +1880,7 @@ int osd_req_decode_sense_full(struct osd_request *or, > attr_page, attr_id); > } > } > - /*These are not legal for OSD*/ > + /* fall through - These are not legal for OSD */ > case scsi_sense_field_replaceable_unit: > OSD_SENSE_PRINT2("scsi_sense_field_replaceable_unit\n"); > break; >
On 12/18/18 11:13 AM, Boaz Harrosh wrote: > On 28/11/18 06:32, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > ACK-by: Boaz Harrosh <ooo@electrozaur.com> > Thank you, Boaz. -- Gustavo
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/scsi/osd/osd_initiator.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c > index 60cf7c5eb880..cb26f26d5ec1 100644 > --- a/drivers/scsi/osd/osd_initiator.c > +++ b/drivers/scsi/osd/osd_initiator.c > @@ -1849,6 +1849,7 @@ int osd_req_decode_sense_full(struct osd_request *or, > 32, 1, dump, sizeof(dump), true); > OSD_SENSE_PRINT2("response_integrity [%s]\n", dump); > } > + /* fall through */ > case osd_sense_attribute_identification: > { > struct osd_sense_attributes_data_descriptor > @@ -1879,7 +1880,7 @@ int osd_req_decode_sense_full(struct osd_request *or, > attr_page, attr_id); > } > } > - /*These are not legal for OSD*/ > + /* fall through - These are not legal for OSD */ > case scsi_sense_field_replaceable_unit: > OSD_SENSE_PRINT2("scsi_sense_field_replaceable_unit\n"); > break; >
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 6:07 PM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping: > > Who can ack or review this patch, please? > > Thanks > -- > Gustavo > > On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/scsi/osd/osd_initiator.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c >> index 60cf7c5eb880..cb26f26d5ec1 100644 >> --- a/drivers/scsi/osd/osd_initiator.c >> +++ b/drivers/scsi/osd/osd_initiator.c >> @@ -1849,6 +1849,7 @@ int osd_req_decode_sense_full(struct osd_request *or, >> 32, 1, dump, sizeof(dump), true); >> OSD_SENSE_PRINT2("response_integrity [%s]\n", dump); >> } >> + /* fall through */ >> case osd_sense_attribute_identification: >> { >> struct osd_sense_attributes_data_descriptor >> @@ -1879,7 +1880,7 @@ int osd_req_decode_sense_full(struct osd_request *or, >> attr_page, attr_id); >> } >> } >> - /*These are not legal for OSD*/ >> + /* fall through - These are not legal for OSD */ >> case scsi_sense_field_replaceable_unit: >> OSD_SENSE_PRINT2("scsi_sense_field_replaceable_unit\n"); >> break; >>
diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index 60cf7c5eb880..cb26f26d5ec1 100644 --- a/drivers/scsi/osd/osd_initiator.c +++ b/drivers/scsi/osd/osd_initiator.c @@ -1849,6 +1849,7 @@ int osd_req_decode_sense_full(struct osd_request *or, 32, 1, dump, sizeof(dump), true); OSD_SENSE_PRINT2("response_integrity [%s]\n", dump); } + /* fall through */ case osd_sense_attribute_identification: { struct osd_sense_attributes_data_descriptor @@ -1879,7 +1880,7 @@ int osd_req_decode_sense_full(struct osd_request *or, attr_page, attr_id); } } - /*These are not legal for OSD*/ + /* fall through - These are not legal for OSD */ case scsi_sense_field_replaceable_unit: OSD_SENSE_PRINT2("scsi_sense_field_replaceable_unit\n"); break;
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/scsi/osd/osd_initiator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)