mbox series

[00/11] Small modifications and bug fixes toward KS 1.0

Message ID 20181121151356.16901-1-ykaradzhov@vmware.com (mailing list archive)
Headers show
Series Small modifications and bug fixes toward KS 1.0 | expand

Message

Yordan Karadzhov Nov. 21, 2018, 3:14 p.m. UTC
This series of patches contains various independent modifications and
bug fixes needed before releasing KernelShark 1.0.

Yordan Karadzhov (11):
  kernel-shark-qt: Protect all calls of tep_read_number_field()
  kernel-shark-qt: Fix the returned error value of
    kshark_get_event_id_easy()
  kernel-shark-qt: Avoid race condition in kshark_get_event_name_easy()
  kernel-shark-qt: Optimize the search in the text data
  kernel-shark-qt: Add iterator index to the search panel
  kernel-shark-qt: Update search iterator when marker is changed
  kernel-shark-qt: Optimize the search in a case of a small data-set
  kernel-shark qt: No error when Record authentication dialog is closed
  kernel-shark-qt: Remove all system=ftrace events from Record dialog
  kernel-shark-qt: Updata Event filter mask when applaing filters to
    Graph
  kernel-shark-qt: Reprocess all CPU collections when the filtering
    changes

 kernel-shark-qt/src/KsCaptureDialog.cpp    |   1 +
 kernel-shark-qt/src/KsMainWindow.cpp       |   8 ++
 kernel-shark-qt/src/KsModels.cpp           |  28 ++--
 kernel-shark-qt/src/KsModels.hpp           |   4 +-
 kernel-shark-qt/src/KsTraceViewer.cpp      | 152 +++++++++++++++------
 kernel-shark-qt/src/KsTraceViewer.hpp      |   9 +-
 kernel-shark-qt/src/KsUtils.cpp            |   6 +
 kernel-shark-qt/src/KsWidgetsLib.cpp       |  10 ++
 kernel-shark-qt/src/KsWidgetsLib.hpp       |   2 +
 kernel-shark-qt/src/libkshark.c            |  15 +-
 kernel-shark-qt/src/plugins/sched_events.c |  52 ++++---
 11 files changed, 204 insertions(+), 83 deletions(-)

Comments

Steven Rostedt Nov. 27, 2018, 11:02 p.m. UTC | #1
On Wed, 21 Nov 2018 15:14:17 +0000
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:

> This series of patches contains various independent modifications and
> bug fixes needed before releasing KernelShark 1.0.
> 
> Yordan Karadzhov (11):
>   kernel-shark-qt: Protect all calls of tep_read_number_field()
>   kernel-shark-qt: Fix the returned error value of
>     kshark_get_event_id_easy()
>   kernel-shark-qt: Avoid race condition in kshark_get_event_name_easy()
>   kernel-shark-qt: Optimize the search in the text data
>   kernel-shark-qt: Add iterator index to the search panel
>   kernel-shark-qt: Update search iterator when marker is changed
>   kernel-shark-qt: Optimize the search in a case of a small data-set
>   kernel-shark qt: No error when Record authentication dialog is closed
>   kernel-shark-qt: Remove all system=ftrace events from Record dialog

I applied patches 2, 4, 5, 6, 7, and 9 which are:

 kernel-shark-qt: Fix the returned error value of kshark_get_event_id_easy()
 kernel-shark-qt: Optimize the search in the text data
 kernel-shark-qt: Add iterator index to the search panel
 kernel-shark-qt: Update search iterator when marker is changed
 kernel-shark-qt: Optimize the search in a case of a small data-set
 kernel-shark-qt: Remove all system=ftrace events from Record dialog

The rest I commented on.

>   kernel-shark-qt: Updata Event filter mask when applaing filters to
>     Graph
>   kernel-shark-qt: Reprocess all CPU collections when the filtering
>     changes

The above two I never received ?

-- Steve

> 
>  kernel-shark-qt/src/KsCaptureDialog.cpp    |   1 +
>  kernel-shark-qt/src/KsMainWindow.cpp       |   8 ++
>  kernel-shark-qt/src/KsModels.cpp           |  28 ++--
>  kernel-shark-qt/src/KsModels.hpp           |   4 +-
>  kernel-shark-qt/src/KsTraceViewer.cpp      | 152 +++++++++++++++------
>  kernel-shark-qt/src/KsTraceViewer.hpp      |   9 +-
>  kernel-shark-qt/src/KsUtils.cpp            |   6 +
>  kernel-shark-qt/src/KsWidgetsLib.cpp       |  10 ++
>  kernel-shark-qt/src/KsWidgetsLib.hpp       |   2 +
>  kernel-shark-qt/src/libkshark.c            |  15 +-
>  kernel-shark-qt/src/plugins/sched_events.c |  52 ++++---
>  11 files changed, 204 insertions(+), 83 deletions(-)
>