| Message ID | 20181128151530.21965-12-ykaradzhov@vmware.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 39218018a1b512d3ef287a438d9b1a9b7121b8aa |
| Headers | show |
| Series | More modifications and bug fixes toward KS 1.0 | expand |
On Wed, 28 Nov 2018 15:16:20 +0000 Yordan Karadzhov <ykaradzhov@vmware.com> wrote: > The CPU/Task graphs are plotted in sorted order. The graph > having smallest CPU id/Pid will be plotted first (on top). I'm fine with this. But I'm wondering if we want to allow the user to move the plots in the future, if that would be a big design change or not. -- Steve > > Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com> > --- > kernel-shark-qt/src/KsTraceGraph.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel-shark-qt/src/KsTraceGraph.cpp b/kernel-shark-qt/src/KsTraceGraph.cpp > index 09b322a..0b5a8b1 100644 > --- a/kernel-shark-qt/src/KsTraceGraph.cpp > +++ b/kernel-shark-qt/src/KsTraceGraph.cpp > @@ -439,6 +439,7 @@ void KsTraceGraph::addCPUPlot(int cpu) > return; > > _glWindow._cpuList.append(cpu); > + qSort(_glWindow._cpuList); > _selfUpdate(); > } > > @@ -449,6 +450,7 @@ void KsTraceGraph::addTaskPlot(int pid) > return; > > _glWindow._taskList.append(pid); > + qSort(_glWindow._taskList); > _selfUpdate(); > } >
On 28.11.18 г. 19:12 ч., Steven Rostedt wrote: > On Wed, 28 Nov 2018 15:16:20 +0000 > Yordan Karadzhov<ykaradzhov@vmware.com> wrote: > >> The CPU/Task graphs are plotted in sorted order. The graph >> having smallest CPU id/Pid will be plotted first (on top). > I'm fine with this. But I'm wondering if we want to allow the user to > move the plots in the future, if that would be a big design change or > not. > Hi Steve, Currently we use the OpenGL widget as one big white canvas and all graphs are drawn on it. If we want to be able to move graphs with the mouse we have to make each graph a widget. However this will greatly complicate everything. Maybe we can think for some kind of menu which can change the order of the graphs before drawing? Thanks! Yordan > -- Steve >
diff --git a/kernel-shark-qt/src/KsTraceGraph.cpp b/kernel-shark-qt/src/KsTraceGraph.cpp index 09b322a..0b5a8b1 100644 --- a/kernel-shark-qt/src/KsTraceGraph.cpp +++ b/kernel-shark-qt/src/KsTraceGraph.cpp @@ -439,6 +439,7 @@ void KsTraceGraph::addCPUPlot(int cpu) return; _glWindow._cpuList.append(cpu); + qSort(_glWindow._cpuList); _selfUpdate(); } @@ -449,6 +450,7 @@ void KsTraceGraph::addTaskPlot(int pid) return; _glWindow._taskList.append(pid); + qSort(_glWindow._taskList); _selfUpdate(); }
The CPU/Task graphs are plotted in sorted order. The graph having smallest CPU id/Pid will be plotted first (on top). Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com> --- kernel-shark-qt/src/KsTraceGraph.cpp | 2 ++ 1 file changed, 2 insertions(+)