| Message ID | 20190110230626.4130-1-atull@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | fpga: altera_freeze_bridge: remove restriction to socfpga | expand |
Hi Alan, On Thu, Jan 10, 2019 at 3:06 PM Alan Tull <atull@kernel.org> wrote: > > The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA > since it can be used on other platforms such as Stratix10. > > Signed-off-by: Alan Tull <atull@kernel.org> > --- > drivers/fpga/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 0bb7b5c..0bdbd3d 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -104,7 +104,7 @@ config SOCFPGA_FPGA_BRIDGE > > config ALTERA_FREEZE_BRIDGE > tristate "Altera FPGA Freeze Bridge" > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > + depends on FPGA_BRIDGE Doesn't that need a dependency on HAS_IOMEM at least, then? > help > Say Y to enable drivers for Altera FPGA Freeze bridges. A > freeze bridge is a bridge that exists in the FPGA fabric to > -- > 2.7.4 > Thanks, Moritz
On Fri, Jan 11, 2019 at 12:42 PM Moritz Fischer <moritz.fischer@ettus.com> wrote: Hi Moritz, > > Hi Alan, > > On Thu, Jan 10, 2019 at 3:06 PM Alan Tull <atull@kernel.org> wrote: > > > > The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA > > since it can be used on other platforms such as Stratix10. > > > > Signed-off-by: Alan Tull <atull@kernel.org> > > --- > > drivers/fpga/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > > index 0bb7b5c..0bdbd3d 100644 > > --- a/drivers/fpga/Kconfig > > +++ b/drivers/fpga/Kconfig > > @@ -104,7 +104,7 @@ config SOCFPGA_FPGA_BRIDGE > > > > config ALTERA_FREEZE_BRIDGE > > tristate "Altera FPGA Freeze Bridge" > > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > > + depends on FPGA_BRIDGE > > Doesn't that need a dependency on HAS_IOMEM at least, then? Right you are! Thanks! Alan > > help > > Say Y to enable drivers for Altera FPGA Freeze bridges. A > > freeze bridge is a bridge that exists in the FPGA fabric to > > -- > > 2.7.4 > > > > Thanks, > Moritz
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index 0bb7b5c..0bdbd3d 100644 --- a/drivers/fpga/Kconfig +++ b/drivers/fpga/Kconfig @@ -104,7 +104,7 @@ config SOCFPGA_FPGA_BRIDGE config ALTERA_FREEZE_BRIDGE tristate "Altera FPGA Freeze Bridge" - depends on ARCH_SOCFPGA && FPGA_BRIDGE + depends on FPGA_BRIDGE help Say Y to enable drivers for Altera FPGA Freeze bridges. A freeze bridge is a bridge that exists in the FPGA fabric to
The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10. Signed-off-by: Alan Tull <atull@kernel.org> --- drivers/fpga/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)