| Message ID | 20190111225339.6939-4-vishal.l.verma@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add missing firmware_status checks | expand |
On Fri, Jan 11, 2019 at 2:53 PM Vishal Verma <vishal.l.verma@intel.com> wrote: > > The ndctl monitor command was neglecting to check the 'firmware_status' > field that is set by the platform firmware to indicate failure. Use > the new ndctl_cmd_submit_xlat facility to include the firmware_status > check as part of the command submission. > > Cc: QI Fuli <qi.fuli@jp.fujitsu.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > --- > ndctl/monitor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ndctl/monitor.c b/ndctl/monitor.c > index 233f2bb..01af338 100644 > --- a/ndctl/monitor.c > +++ b/ndctl/monitor.c > @@ -226,7 +226,7 @@ static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm) > err(&monitor, "%s: no smart threshold command support\n", name); > goto out; > } > - if (ndctl_cmd_submit(st_cmd)) { > + if (ndctl_cmd_submit_xlat(st_cmd)) { Same comment about fixing this up to explicitly check for '< 0'. > err(&monitor, "%s: smart threshold command failed\n", name); > goto out; > } > @@ -246,7 +246,7 @@ static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm) > alarm |= ND_SMART_CTEMP_TRIP; > ndctl_cmd_smart_threshold_set_alarm_control(sst_cmd, alarm); > > - rc = ndctl_cmd_submit(sst_cmd); > + rc = ndctl_cmd_submit_xlat(sst_cmd); > if (rc) { Ditto.
diff --git a/ndctl/monitor.c b/ndctl/monitor.c index 233f2bb..01af338 100644 --- a/ndctl/monitor.c +++ b/ndctl/monitor.c @@ -226,7 +226,7 @@ static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm) err(&monitor, "%s: no smart threshold command support\n", name); goto out; } - if (ndctl_cmd_submit(st_cmd)) { + if (ndctl_cmd_submit_xlat(st_cmd)) { err(&monitor, "%s: smart threshold command failed\n", name); goto out; } @@ -246,7 +246,7 @@ static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm) alarm |= ND_SMART_CTEMP_TRIP; ndctl_cmd_smart_threshold_set_alarm_control(sst_cmd, alarm); - rc = ndctl_cmd_submit(sst_cmd); + rc = ndctl_cmd_submit_xlat(sst_cmd); if (rc) { err(&monitor, "%s: smart set threshold command failed\n", name); goto out;
The ndctl monitor command was neglecting to check the 'firmware_status' field that is set by the platform firmware to indicate failure. Use the new ndctl_cmd_submit_xlat facility to include the firmware_status check as part of the command submission. Cc: QI Fuli <qi.fuli@jp.fujitsu.com> Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- ndctl/monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)