| Message ID | a118ae0eeeb3cdcd4846bc1031ea89ca62af1e00.1543374820.git.gustavo@embeddedor.com (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
| Series | scsi: Mark expected switch fall-throughs | expand |
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that, in this particular case, I replaced "allow fall-through" > with a "fall through" annotation, which is what GCC is expecting to > find. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/scsi/qla4xxx/ql4_os.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c > index 1c702cd22359..7fd3491ea2d9 100644 > --- a/drivers/scsi/qla4xxx/ql4_os.c > +++ b/drivers/scsi/qla4xxx/ql4_os.c > @@ -2876,7 +2876,7 @@ static int qla4xxx_session_get_param(struct iscsi_cls_session *cls_sess, > chap_tbl.secret_len); > } > } > - /* allow fall-through */ > + /* fall through */ > default: > return iscsi_session_get_param(cls_sess, param, buf); > } >
On 11/28/18, 10:03 AM, "linux-scsi-owner@vger.kernel.org on behalf of Gustavo A. R. Silva" <linux-scsi-owner@vger.kernel.org on behalf of gustavo@embeddedor.com> wrote: >External Email > >In preparation to enabling -Wimplicit-fallthrough, mark switch cases >where we are expecting to fall through. > >Notice that, in this particular case, I replaced "allow fall-through" >with a "fall through" annotation, which is what GCC is expecting to >find. > >Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >--- > drivers/scsi/qla4xxx/ql4_os.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c >index 1c702cd22359..7fd3491ea2d9 100644 >--- a/drivers/scsi/qla4xxx/ql4_os.c >+++ b/drivers/scsi/qla4xxx/ql4_os.c >@@ -2876,7 +2876,7 @@ static int qla4xxx_session_get_param(struct >iscsi_cls_session *cls_sess, > chap_tbl.secret_len); > } > } >- /* allow fall-through */ >+ /* fall through */ > default: > return iscsi_session_get_param(cls_sess, param, buf); > } >-- >2.17.1 Thanks. Acked-by: Nilesh Javali <njavali@marvell.com>
Nilesh, >>In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>where we are expecting to fall through. >> >>Notice that, in this particular case, I replaced "allow fall-through" >>with a "fall through" annotation, which is what GCC is expecting to >>find. Applied to 5.1/scsi-queue. Thanks, Gustavo.
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 1c702cd22359..7fd3491ea2d9 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -2876,7 +2876,7 @@ static int qla4xxx_session_get_param(struct iscsi_cls_session *cls_sess, chap_tbl.secret_len); } } - /* allow fall-through */ + /* fall through */ default: return iscsi_session_get_param(cls_sess, param, buf); }
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "allow fall-through" with a "fall through" annotation, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/scsi/qla4xxx/ql4_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)