mbox series

[v2,0/5] drm/tinydrm: Use damage helper for dirtyfb

Message ID 20190111201206.45018-1-noralf@tronnes.org (mailing list archive)
Headers show
Series drm/tinydrm: Use damage helper for dirtyfb | expand

Message

Noralf Trønnes Jan. 11, 2019, 8:12 p.m. UTC 
Changes:
- Improve drm_gem_fb_create_with_dirty() docs (Daniel)
- Remove unnecessary clearing of damage clips
- Rebase on Sam's drmP.h series
- Remove fb NULL check in mipi_dbi_enable_flush() (kbuild test robot)
- Update todo.rst (Sam)

Maxime has done a backmerge so the damage helper is now in
drm-misc-next.

Noralf.

Noralf Trønnes (5):
  drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty()
  drm/damage-helper: Add drm_atomic_helper_damage_merged()
  drm/tinydrm: Use struct drm_rect
  drm/tinydrm: Use damage helper for dirtyfb
  drm/todo: Tick off some tinydrm entries

 Documentation/gpu/todo.rst                    |  35 -----
 drivers/gpu/drm/drm_damage_helper.c           |  41 ++++++
 drivers/gpu/drm/drm_gem_framebuffer_helper.c  |  50 ++++++-
 drivers/gpu/drm/tinydrm/core/tinydrm-core.c   |  21 +--
 .../gpu/drm/tinydrm/core/tinydrm-helpers.c    | 100 +------------
 drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c   |  30 ----
 drivers/gpu/drm/tinydrm/hx8357d.c             |   2 +-
 drivers/gpu/drm/tinydrm/ili9225.c             | 138 +++++++-----------
 drivers/gpu/drm/tinydrm/ili9341.c             |   2 +-
 drivers/gpu/drm/tinydrm/mi0283qt.c            |   2 +-
 drivers/gpu/drm/tinydrm/mipi-dbi.c            |  89 ++++++-----
 drivers/gpu/drm/tinydrm/repaper.c             |  42 +++---
 drivers/gpu/drm/tinydrm/st7586.c              |  73 ++++-----
 drivers/gpu/drm/tinydrm/st7735r.c             |   2 +-
 include/drm/drm_damage_helper.h               |   3 +
 include/drm/drm_gem_framebuffer_helper.h      |   3 +
 include/drm/tinydrm/mipi-dbi.h                |   5 +-
 include/drm/tinydrm/tinydrm-helpers.h         |  20 +--
 include/drm/tinydrm/tinydrm.h                 |  26 ----
 19 files changed, 282 insertions(+), 402 deletions(-)

Comments

Sam Ravnborg Jan. 12, 2019, 9:43 p.m. UTC | #1 
Hi Noralf.

On Fri, Jan 11, 2019 at 09:12:01PM +0100, Noralf Trønnes wrote:
> Changes:
> - Improve drm_gem_fb_create_with_dirty() docs (Daniel)
> - Remove unnecessary clearing of damage clips
> - Rebase on Sam's drmP.h series
> - Remove fb NULL check in mipi_dbi_enable_flush() (kbuild test robot)
> - Update todo.rst (Sam)
> 
> Maxime has done a backmerge so the damage helper is now in
> drm-misc-next.

I applied this set on top of drm-misc-next + my drmP.h removal patches.
To fix the build I had to add a few includes see below.

Other than that it looked good.
I was about to complain about "Use struct drm_rect" patch,
but looking at patch "Use damage helper for dirtyfb" it all made
sense again.

The full series can get my:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

But please consider applying the fixes below to avoid breaking
the build due to the drmP.h crunch.

I also removed drm_vblank.h from tinydrm-pipe.c as it
is no longer used - also part of patch below.

	Sam

diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
index a4796ddb08f0..323564329535 100644
--- a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
+++ b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
@@ -13,7 +13,6 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modes.h>
 #include <drm/drm_print.h>
-#include <drm/drm_vblank.h>
 #include <drm/tinydrm/tinydrm.h>
 
 struct tinydrm_connector {
diff --git a/drivers/gpu/drm/tinydrm/ili9225.c b/drivers/gpu/drm/tinydrm/ili9225.c
index aa1376a22bda..8b118b476301 100644
--- a/drivers/gpu/drm/tinydrm/ili9225.c
+++ b/drivers/gpu/drm/tinydrm/ili9225.c
@@ -27,6 +27,7 @@
 #include <drm/drm_gem_cma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_rect.h>
+#include <drm/drm_vblank.h>
 #include <drm/tinydrm/mipi-dbi.h>
 #include <drm/tinydrm/tinydrm-helpers.h>
 
diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
index 680692a83f94..8604db734756 100644
--- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
+++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
@@ -24,6 +24,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_rect.h>
+#include <drm/drm_vblank.h>
 #include <drm/tinydrm/mipi-dbi.h>
 #include <drm/tinydrm/tinydrm-helpers.h>
 #include <video/mipi_display.h>
diff --git a/drivers/gpu/drm/tinydrm/repaper.c b/drivers/gpu/drm/tinydrm/repaper.c
index f9cacf49f16b..b037c6540cf3 100644
--- a/drivers/gpu/drm/tinydrm/repaper.c
+++ b/drivers/gpu/drm/tinydrm/repaper.c
@@ -32,6 +32,7 @@
 #include <drm/drm_gem_cma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_rect.h>
+#include <drm/drm_vblank.h>
 #include <drm/tinydrm/tinydrm.h>
 #include <drm/tinydrm/tinydrm-helpers.h>
 
diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tinydrm/st7586.c
index 50e370ce5a59..d39417b74e8b 100644
--- a/drivers/gpu/drm/tinydrm/st7586.c
+++ b/drivers/gpu/drm/tinydrm/st7586.c
@@ -23,6 +23,7 @@
 #include <drm/drm_gem_cma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_rect.h>
+#include <drm/drm_vblank.h>
 #include <drm/tinydrm/mipi-dbi.h>
 #include <drm/tinydrm/tinydrm-helpers.h>