diff mbox series

[net] net: phy: meson-gxl: Use the genphy_soft_reset callback

Message ID 20190113002255.15310-1-timotej.lazar@araneo.si (mailing list archive)
State Not Applicable
Headers show
Series [net] net: phy: meson-gxl: Use the genphy_soft_reset callback | expand

Commit Message

Timotej Lazar Jan. 13, 2019, 12:22 a.m. UTC
Since the referenced commit, Ethernet fails to come up at boot on the
board meson-gxl-s905x-libretech-cc. Fix this by re-enabling the
genphy_soft_reset callback for the Amlogic Meson GXL PHY driver.

Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
Signed-off-by: Timotej Lazar <timotej.lazar@araneo.si>
---
 drivers/net/phy/meson-gxl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Florian Fainelli Jan. 13, 2019, 5:11 a.m. UTC | #1
On January 12, 2019 4:22:55 PM PST, Timotej Lazar <timotej.lazar@araneo.si> wrote:
>Since the referenced commit, Ethernet fails to come up at boot on the
>board meson-gxl-s905x-libretech-cc. Fix this by re-enabling the
>genphy_soft_reset callback for the Amlogic Meson GXL PHY driver.
>
>Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
>Signed-off-by: Timotej Lazar <timotej.lazar@araneo.si>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
David Miller Jan. 16, 2019, 6:28 a.m. UTC | #2
From: Timotej Lazar <timotej.lazar@araneo.si>
Date: Sun, 13 Jan 2019 01:22:55 +0100

> Since the referenced commit, Ethernet fails to come up at boot on the
> board meson-gxl-s905x-libretech-cc. Fix this by re-enabling the
> genphy_soft_reset callback for the Amlogic Meson GXL PHY driver.
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Signed-off-by: Timotej Lazar <timotej.lazar@araneo.si>

Applied and queued up for -stable.
diff mbox series

Patch

diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index b03bcf2c388a..3ddaf9595697 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -233,6 +233,7 @@  static struct phy_driver meson_gxl_phy[] = {
 		.name		= "Meson GXL Internal PHY",
 		.features	= PHY_BASIC_FEATURES,
 		.flags		= PHY_IS_INTERNAL,
+		.soft_reset     = genphy_soft_reset,
 		.config_init	= meson_gxl_config_init,
 		.aneg_done      = genphy_aneg_done,
 		.read_status	= meson_gxl_read_status,