| Message ID | 20190111233159.218342-1-evgreen@chromium.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 326a859b28141bcd3445be0606647250742283a6 |
| Headers | show |
| Series | scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom | expand |
Evan, > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that > this was the only possible PHY driver Qualcomm's UFS controller > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, > and phy-qcom-ufs is unused. > > Remove the select, since for SDM845 it adds useless drivers to the > build. Applied to 5.1/scsi-queue.
Hi, On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen <martin.petersen@oracle.com> wrote: > > > Evan, > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that > > this was the only possible PHY driver Qualcomm's UFS controller > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, > > and phy-qcom-ufs is unused. > > > > Remove the select, since for SDM845 it adds useless drivers to the > > build. > > Applied to 5.1/scsi-queue. Should this be accompanied by a change to arch/arm64/configs/defconfig that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any non-SDM845 devices to test on, but I'm sorta assuming they will all break without the defconfig update? Added a few more people (and linux-arm-msm list) to this thread in case this matters to anyone. -Doug
On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen > <martin.petersen@oracle.com> wrote: > > > > > > Evan, > > > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that > > > this was the only possible PHY driver Qualcomm's UFS controller > > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, > > > and phy-qcom-ufs is unused. > > > > > > Remove the select, since for SDM845 it adds useless drivers to the > > > build. > > > > Applied to 5.1/scsi-queue. > > Should this be accompanied by a change to arch/arm64/configs/defconfig > that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any > non-SDM845 devices to test on, but I'm sorta assuming they will all > break without the defconfig update? Right, thanks for pointing that out. I'll send out another patch to tweak the defconfig. -Evan
On Mon, Jan 14, 2019 at 10:41 AM Evan Green <evgreen@chromium.org> wrote: > > On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson <dianders@chromium.org> wrote: > > > > Hi, > > > > On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen > > <martin.petersen@oracle.com> wrote: > > > > > > > > > Evan, > > > > > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that > > > > this was the only possible PHY driver Qualcomm's UFS controller > > > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, > > > > and phy-qcom-ufs is unused. > > > > > > > > Remove the select, since for SDM845 it adds useless drivers to the > > > > build. > > > > > > Applied to 5.1/scsi-queue. > > > > Should this be accompanied by a change to arch/arm64/configs/defconfig > > that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any > > non-SDM845 devices to test on, but I'm sorta assuming they will all > > break without the defconfig update? > > Right, thanks for pointing that out. I'll send out another patch to > tweak the defconfig. Sent out at: https://lore.kernel.org/lkml/20190114190112.167922-1-evgreen@chromium.org/T/#u
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index 2ddbb26d9c265..6db37cf306b05 100644 --- a/drivers/scsi/ufs/Kconfig +++ b/drivers/scsi/ufs/Kconfig @@ -99,7 +99,6 @@ config SCSI_UFS_DWC_TC_PLATFORM config SCSI_UFS_QCOM tristate "QCOM specific hooks to UFS controller platform driver" depends on SCSI_UFSHCD_PLATFORM && ARCH_QCOM - select PHY_QCOM_UFS help This selects the QCOM specific additions to UFSHCD platform driver. UFS host on QCOM needs some vendor specific configuration before
CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that this was the only possible PHY driver Qualcomm's UFS controller would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, and phy-qcom-ufs is unused. Remove the select, since for SDM845 it adds useless drivers to the build. Signed-off-by: Evan Green <evgreen@chromium.org> --- drivers/scsi/ufs/Kconfig | 1 - 1 file changed, 1 deletion(-)