| Message ID | 20190108194538.28669-1-antonynpavlov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RISC-V: asm/page.h: fix spelling mistake "CONFIG_64BITS" -> "CONFIG_64BIT" | expand |
On Tue, Jan 08, 2019 at 10:45:38PM +0300, Antony Pavlov wrote: > There is no CONFIG_64BITS Kconfig macro. > Please see arch/riscv/Kconfig for details, e.g. > > linux$ git grep -HnA 1 "config 64BIT" arch/riscv/Kconfig > arch/riscv/Kconfig:6:config 64BIT > arch/riscv/Kconfig-7- bool > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> This looks correct. But I wonder why we even bother with the explicit width and don't just use "%lx" directly without the macro.
On Tue, 15 Jan 2019 05:57:30 PST (-0800), Christoph Hellwig wrote: > On Tue, Jan 08, 2019 at 10:45:38PM +0300, Antony Pavlov wrote: >> There is no CONFIG_64BITS Kconfig macro. >> Please see arch/riscv/Kconfig for details, e.g. >> >> linux$ git grep -HnA 1 "config 64BIT" arch/riscv/Kconfig >> arch/riscv/Kconfig:6:config 64BIT >> arch/riscv/Kconfig-7- bool >> >> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> > > This looks correct. But I wonder why we even bother with the explicit > width and don't just use "%lx" directly without the macro. I don't think there's any hard reason for it, but from grepping around it appears other arches (arm64 and all the one-liners) pad it with either zeros or spaces. I'm happy with the patch, as at least it's not broken :)
diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h index 06cfbb3aacbb0..2a546a52f02a0 100644 --- a/arch/riscv/include/asm/page.h +++ b/arch/riscv/include/asm/page.h @@ -80,7 +80,7 @@ typedef struct page *pgtable_t; #define __pgd(x) ((pgd_t) { (x) }) #define __pgprot(x) ((pgprot_t) { (x) }) -#ifdef CONFIG_64BITS +#ifdef CONFIG_64BIT #define PTE_FMT "%016lx" #else #define PTE_FMT "%08lx"
There is no CONFIG_64BITS Kconfig macro. Please see arch/riscv/Kconfig for details, e.g. linux$ git grep -HnA 1 "config 64BIT" arch/riscv/Kconfig arch/riscv/Kconfig:6:config 64BIT arch/riscv/Kconfig-7- bool Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> --- arch/riscv/include/asm/page.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)