[v8,5/7] ARM: dts: ls1021a: Remove fsl,qspi-has-second-chip as it is not used

Commit Message

Frieder Schrempf Jan. 7, 2019, 9:29 a.m. UTC

From: Frieder Schrempf <[e-mail]>

After switching to the new FSL QSPI driver the property
'fsl,qspi-has-second-chip' is not needed anymore.

The driver now uses the 'reg' property to determine the bus and
the chipselect.

Signed-off-by: Frieder Schrempf <[e-mail]>
---
 arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 1 -
 1 file changed, 1 deletion(-)

Comments

Shawn Guo Jan. 13, 2019, 3:31 a.m. UTC | #1

On Mon, Jan 07, 2019 at 09:29:54AM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <[e-mail]>
> 
> After switching to the new FSL QSPI driver the property
> 'fsl,qspi-has-second-chip' is not needed anymore.
> 
> The driver now uses the 'reg' property to determine the bus and
> the chipselect.
> 
> Signed-off-by: Frieder Schrempf <[e-mail]>

Applied, thanks.

Frieder Schrempf Jan. 14, 2019, 8:18 a.m. UTC | #2

Hi Shawn,

On 13.01.19 04:31, Shawn Guo wrote:
> On Mon, Jan 07, 2019 at 09:29:54AM +0000, Schrempf Frieder wrote:
>> From: Frieder Schrempf <[e-mail]>
>>
>> After switching to the new FSL QSPI driver the property
>> 'fsl,qspi-has-second-chip' is not needed anymore.
>>
>> The driver now uses the 'reg' property to determine the bus and
>> the chipselect.
>>
>> Signed-off-by: Frieder Schrempf <[e-mail]>
> 
> Applied, thanks.

I just noticed, that this and the arm64 patch depend on the driver 
changes for 5.1 that go through the SPI tree. So I guess we can't be 
sure that this will be merged in the right order and we need to delay 
this cleanup to 5.2, or am I wrong?

Thanks,
Frieder

Shawn Guo Jan. 15, 2019, 3:18 p.m. UTC | #3

On Mon, Jan 14, 2019 at 08:18:49AM +0000, Schrempf Frieder wrote:
> Hi Shawn,
> 
> On 13.01.19 04:31, Shawn Guo wrote:
> > On Mon, Jan 07, 2019 at 09:29:54AM +0000, Schrempf Frieder wrote:
> >> From: Frieder Schrempf <[e-mail]>
> >>
> >> After switching to the new FSL QSPI driver the property
> >> 'fsl,qspi-has-second-chip' is not needed anymore.
> >>
> >> The driver now uses the 'reg' property to determine the bus and
> >> the chipselect.
> >>
> >> Signed-off-by: Frieder Schrempf <[e-mail]>
> > 
> > Applied, thanks.
> 
> I just noticed, that this and the arm64 patch depend on the driver 
> changes for 5.1 that go through the SPI tree. So I guess we can't be 
> sure that this will be merged in the right order and we need to delay 
> this cleanup to 5.2, or am I wrong?

You are right.  I just dropped the both patches.  Ping me or resend when
they are ready to go.

Shawn

Frieder Schrempf Jan. 15, 2019, 3:24 p.m. UTC | #4

On 15.01.19 16:18, Shawn Guo wrote:
> On Mon, Jan 14, 2019 at 08:18:49AM +0000, Schrempf Frieder wrote:
>> Hi Shawn,
>>
>> On 13.01.19 04:31, Shawn Guo wrote:
>>> On Mon, Jan 07, 2019 at 09:29:54AM +0000, Schrempf Frieder wrote:
>>>> From: Frieder Schrempf <[e-mail]>
>>>>
>>>> After switching to the new FSL QSPI driver the property
>>>> 'fsl,qspi-has-second-chip' is not needed anymore.
>>>>
>>>> The driver now uses the 'reg' property to determine the bus and
>>>> the chipselect.
>>>>
>>>> Signed-off-by: Frieder Schrempf <[e-mail]>
>>>
>>> Applied, thanks.
>>
>> I just noticed, that this and the arm64 patch depend on the driver
>> changes for 5.1 that go through the SPI tree. So I guess we can't be
>> sure that this will be merged in the right order and we need to delay
>> this cleanup to 5.2, or am I wrong?
> 
> You are right.  I just dropped the both patches.  Ping me or resend when
> they are ready to go.

Thanks, will do so.

Frieder

Patch

diff --git a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
index 6a83f30029ea..d3a1a73ae97e 100644
--- a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
+++ b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
@@ -203,7 +203,6 @@ 
 };
 
 &qspi {
-	fsl,qspi-has-second-chip;
 	status = "okay";
 
 	flash: flash@0 {