| Message ID | 20190109203911.7887-2-logang@deltatee.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sparsemem support for RISC-V | expand |
On Wed, Jan 09, 2019 at 01:39:10PM -0700, Logan Gunthorpe wrote: > Cleanup the open coded for_each_memblock() loop that is equivalent > to the new memblocks_present() helper. Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de> Probably no need to keep this in a series with the RISC-V code, this can be queued up by the sh folks independently.
On 2019-01-15 6:58 a.m., Christoph Hellwig wrote: > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Probably no need to keep this in a series with the RISC-V code, this can > be queued up by the sh folks independently. Oh, yeah, sorry, I obviously didn't pay enough attention to this when I resent it. I sent the similar Arm changes to the appropriate list and, yes, the sh ones should go to that maintainer. @Palmer: if you can just look at taking the second patch, I'll resubmit the first one to the appropriate list. Thanks, Logan
diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c index a8e5c0e00fca..dc0ff41d602d 100644 --- a/arch/sh/mm/init.c +++ b/arch/sh/mm/init.c @@ -234,12 +234,7 @@ static void __init do_init_bootmem(void) plat_mem_setup(); - for_each_memblock(memory, reg) { - int nid = memblock_get_region_node(reg); - - memory_present(nid, memblock_region_memory_base_pfn(reg), - memblock_region_memory_end_pfn(reg)); - } + memblocks_present(); sparse_init(); }
Cleanup the open coded for_each_memblock() loop that is equivalent to the new memblocks_present() helper. Signed-off-by: Logan Gunthorpe <logang@deltatee.com> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Rich Felker <dalias@libc.org> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Rob Herring <robh@kernel.org> --- arch/sh/mm/init.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)