| Message ID | 154759163682.1953028.16995572958827750312.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | acpi/nfit: Fix command-supported detection | expand |
Dan Williams <dan.j.williams@intel.com> writes: > Changes since v2 [1]: > * Don't allow ND_CMD_CALL to bypass dsm_mask restrictions (Jeff) > > [1]: https://lists.01.org/pipermail/linux-nvdimm/2019-January/019498.html > > --- > > One last resend to make sure all the last bits of thrash have settled. LGTM. Thanks! Jeff
Changes since v2 [1]: * Don't allow ND_CMD_CALL to bypass dsm_mask restrictions (Jeff) [1]: https://lists.01.org/pipermail/linux-nvdimm/2019-January/019498.html --- One last resend to make sure all the last bits of thrash have settled. Quote patch2 changelog: The _DSM function number validation only happens to succeed when the generic Linux command number translation corresponds with a DSM-family-specific function number. This breaks NVDIMM-N implementations that correctly implement _LSR, _LSW, and _LSI, but do not happen to publish support for DSM function numbers 4, 5, and 6. Recall that the support for _LS{I,R,W} family of methods results in the DIMM being marked as supporting those command numbers at acpi_nfit_register_dimms() time. The DSM function mask is only used for ND_CMD_CALL support of non-NVDIMM_FAMILY_INTEL devices. --- Dan Williams (2): acpi/nfit: Block function zero DSMs acpi/nfit: Fix command-supported detection drivers/acpi/nfit/core.c | 59 +++++++++++++++++++++++++++++++++++----------- 1 file changed, 45 insertions(+), 14 deletions(-)