| Message ID | 20190117100212.2336-1-antoine.tenart@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: mscc: PTP offloading support | expand |
On Thu, Jan 17, 2019 at 11:02:04AM +0100, Antoine Tenart wrote: > This series adds support for the PTP offloading support in the Mscc > Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are > supported. > > In order to make use of the PTP offloading support, two new register > banks were described in the Ocelot device tree. The use of those > registers by the Mscc Ocelot Ethernet switch driver is made optional for > dt compatibility reasons. For the same reason a new interrupt is > described, and its use is also made optinal for compatibility reasons. > All of this is done ine patches 1-5. > > The PTP offloading support itself is added in patch 8. The subject lines and this description are misleading. You are not offloading the Precision Time Protocol. Instead, this series implements a normal PHC driver. Please change the text to avoid the phrase, "PTP offloading". Thanks, Richard
On 1/17/2019 2:02 AM, Antoine Tenart wrote: > Hi all, > > This series adds support for the PTP offloading support in the Mscc > Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are > supported. > > In order to make use of the PTP offloading support, two new register > banks were described in the Ocelot device tree. The use of those > registers by the Mscc Ocelot Ethernet switch driver is made optional for > dt compatibility reasons. For the same reason a new interrupt is > described, and its use is also made optinal for compatibility reasons. > All of this is done ine patches 1-5. > > The PTP offloading support itself is added in patch 8. > > While doing this support, a few reworks were done in the Ocelot switch > driver, in patches 6-7. > > Patches 2 and 4 should probably go through the MIPS tree. Looks like you missed copying netdev on this patch series, do you mind re-sending there as well? > > Thanks! > Antoine > > Antoine Tenart (8): > Documentation/bindings: net: ocelot: document the VCAP and PTP banks > MIPS: dts: mscc: describe VCAP and PTP register ranges > Documentation/bindings: net: ocelot: document the PTP ready IRQ > MIPS: dts: mscc: describe the PTP ready interrupt > net: mscc: describe the VCAP and PTP register ranges > net: mscc: improve the frame header parsing readability > net: mscc: remove the frame_info cpuq member > net: mscc: PTP offloading support > > .../devicetree/bindings/net/mscc-ocelot.txt | 22 +- > arch/mips/boot/dts/mscc/ocelot.dtsi | 14 +- > drivers/net/ethernet/mscc/ocelot.c | 509 +++++++++++++++++- > drivers/net/ethernet/mscc/ocelot.h | 55 +- > drivers/net/ethernet/mscc/ocelot_board.c | 150 +++++- > drivers/net/ethernet/mscc/ocelot_ptp.h | 41 ++ > drivers/net/ethernet/mscc/ocelot_regs.c | 22 + > drivers/net/ethernet/mscc/ocelot_vcap.h | 104 ++++ > 8 files changed, 877 insertions(+), 40 deletions(-) > create mode 100644 drivers/net/ethernet/mscc/ocelot_ptp.h > create mode 100644 drivers/net/ethernet/mscc/ocelot_vcap.h >
Hi Florian, On Thu, Jan 17, 2019 at 09:07:05PM -0800, Florian Fainelli wrote: > On 1/17/2019 2:02 AM, Antoine Tenart wrote: > > > > This series adds support for the PTP offloading support in the Mscc > > Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are > > supported. > > > > In order to make use of the PTP offloading support, two new register > > banks were described in the Ocelot device tree. The use of those > > registers by the Mscc Ocelot Ethernet switch driver is made optional for > > dt compatibility reasons. For the same reason a new interrupt is > > described, and its use is also made optinal for compatibility reasons. > > All of this is done ine patches 1-5. > > > > The PTP offloading support itself is added in patch 8. > > > > While doing this support, a few reworks were done in the Ocelot switch > > driver, in patches 6-7. > > > > Patches 2 and 4 should probably go through the MIPS tree. > > Looks like you missed copying netdev on this patch series, do you mind > re-sending there as well? I just checked and netdev is Cc'ed. I'll prepare a v2 to take in account the comments, so I'll sent it again anyway. Thanks! Antoine
Hi Richard, On Thu, Jan 17, 2019 at 06:13:42PM -0800, Richard Cochran wrote: > On Thu, Jan 17, 2019 at 11:02:04AM +0100, Antoine Tenart wrote: > > This series adds support for the PTP offloading support in the Mscc > > Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are > > supported. > > > > In order to make use of the PTP offloading support, two new register > > banks were described in the Ocelot device tree. The use of those > > registers by the Mscc Ocelot Ethernet switch driver is made optional for > > dt compatibility reasons. For the same reason a new interrupt is > > described, and its use is also made optinal for compatibility reasons. > > All of this is done ine patches 1-5. > > > > The PTP offloading support itself is added in patch 8. > > The subject lines and this description are misleading. You are not > offloading the Precision Time Protocol. Instead, this series > implements a normal PHC driver. > > Please change the text to avoid the phrase, "PTP offloading". Will do. Thanks! Antoine
On 1/18/19 12:58 AM, Antoine Tenart wrote: > Hi Florian, > > On Thu, Jan 17, 2019 at 09:07:05PM -0800, Florian Fainelli wrote: >> On 1/17/2019 2:02 AM, Antoine Tenart wrote: >>> >>> This series adds support for the PTP offloading support in the Mscc >>> Ocelot Ethernet switch driver. Both PTP 1-step and 2-step modes are >>> supported. >>> >>> In order to make use of the PTP offloading support, two new register >>> banks were described in the Ocelot device tree. The use of those >>> registers by the Mscc Ocelot Ethernet switch driver is made optional for >>> dt compatibility reasons. For the same reason a new interrupt is >>> described, and its use is also made optinal for compatibility reasons. >>> All of this is done ine patches 1-5. >>> >>> The PTP offloading support itself is added in patch 8. >>> >>> While doing this support, a few reworks were done in the Ocelot switch >>> driver, in patches 6-7. >>> >>> Patches 2 and 4 should probably go through the MIPS tree. >> >> Looks like you missed copying netdev on this patch series, do you mind >> re-sending there as well? > > I just checked and netdev is Cc'ed. I'll prepare a v2 to take in account > the comments, so I'll sent it again anyway. Indeed, my bad.