| Message ID | 1547808495-19509-3-git-send-email-uli+renesas@fpond.eu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 055d15a88f66b096ca4df7cde83a80b80cd22dff |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | ARM: shmobile: r8a7779: HSCIF support | expand |
Hi Uli, On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote: > Based on Rev. 1.00 of the R-Car H1 datasheet. > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> Thanks for the update! > --- a/arch/arm/boot/dts/r8a7779.dtsi > +++ b/arch/arm/boot/dts/r8a7779.dtsi > + hscif1: serial@ffe49000 { > + compatible = "renesas,hscif-r8a7779", > + "renesas,rcar-gen1-hscif", "renesas,hscif"; > + reg = <0xffe49000 96>; > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp0_clks R8A7779_CLK_HSCIF1, Missing closing ">". With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Fri, Jan 18, 2019 at 11:48:15AM +0100, Ulrich Hecht wrote: > Based on Rev. 1.00 of the R-Car H1 datasheet. > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote: > Hi Uli, > > On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote: > > Based on Rev. 1.00 of the R-Car H1 datasheet. > > > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> > > Thanks for the update! > > > --- a/arch/arm/boot/dts/r8a7779.dtsi > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > > + hscif1: serial@ffe49000 { > > + compatible = "renesas,hscif-r8a7779", > > + "renesas,rcar-gen1-hscif", "renesas,hscif"; > > + reg = <0xffe49000 96>; > > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&mstp0_clks R8A7779_CLK_HSCIF1, > > Missing closing ">". > > With the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, applied with that fixed. Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding?
Hi Simon, On Fri, Jan 18, 2019 at 1:18 PM Simon Horman <horms@verge.net.au> wrote: > On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote: > > On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote: > > > --- a/arch/arm/boot/dts/r8a7779.dtsi > > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > > > > + hscif1: serial@ffe49000 { > > > + compatible = "renesas,hscif-r8a7779", > > > + "renesas,rcar-gen1-hscif", "renesas,hscif"; > > > + reg = <0xffe49000 96>; > > > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > > > + clocks = <&mstp0_clks R8A7779_CLK_HSCIF1, > > > > Missing closing ">". > > > > With the above fixed: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Thanks, applied with that fixed. Thanks! > Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding? I believe you were CCed by Greg's bot for patch "dt-bindings: serial: sh-sci: Document r8a7778/9 HSCIF bindings" added to tty-testing Gr{oetje,eeting}s, Geert
On Fri, Jan 18, 2019 at 01:48:41PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Jan 18, 2019 at 1:18 PM Simon Horman <horms@verge.net.au> wrote: > > On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote: > > > On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote: > > > > --- a/arch/arm/boot/dts/r8a7779.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > > > > > > + hscif1: serial@ffe49000 { > > > > + compatible = "renesas,hscif-r8a7779", > > > > + "renesas,rcar-gen1-hscif", "renesas,hscif"; > > > > + reg = <0xffe49000 96>; > > > > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > > > > + clocks = <&mstp0_clks R8A7779_CLK_HSCIF1, > > > > > > Missing closing ">". > > > > > > With the above fixed: > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Thanks, applied with that fixed. > > Thanks! > > > Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding? > > I believe you were CCed by Greg's bot for > > patch "dt-bindings: serial: sh-sci: Document r8a7778/9 HSCIF > bindings" added to tty-testing Thanks, indeed I was.
diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi index 3bc133d..34e468c 100644 --- a/arch/arm/boot/dts/r8a7779.dtsi +++ b/arch/arm/boot/dts/r8a7779.dtsi @@ -287,6 +287,32 @@ status = "disabled"; }; + hscif0: serial@ffe48000 { + compatible = "renesas,hscif-r8a7779", + "renesas,rcar-gen1-hscif", "renesas,hscif"; + reg = <0xffe48000 96>; + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp0_clks R8A7779_CLK_HSCIF0>, + <&cpg_clocks R8A7779_CLK_S>, + <&scif_clk>; + clock-names = "fck", "brg_int", "scif_clk"; + power-domains = <&cpg_clocks>; + status = "disabled"; + }; + + hscif1: serial@ffe49000 { + compatible = "renesas,hscif-r8a7779", + "renesas,rcar-gen1-hscif", "renesas,hscif"; + reg = <0xffe49000 96>; + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp0_clks R8A7779_CLK_HSCIF1, + <&cpg_clocks R8A7779_CLK_S>, + <&scif_clk>; + clock-names = "fck", "brg_int", "scif_clk"; + power-domains = <&cpg_clocks>; + status = "disabled"; + }; + pfc: pin-controller@fffc0000 { compatible = "renesas,pfc-r8a7779"; reg = <0xfffc0000 0x23c>;
Based on Rev. 1.00 of the R-Car H1 datasheet. Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> --- arch/arm/boot/dts/r8a7779.dtsi | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)