mbox series

[v2,0/3] adt7316 regmap implementation

Message ID 20190119183932.14321-1-shreeya.patel23498@gmail.com (mailing list archive)
Headers show
Series adt7316 regmap implementation | expand

Message

Shreeya Patel Jan. 19, 2019, 6:39 p.m. UTC 
This patchset consist of some initial patches for heading
towards the regmap implementation and also the final patch
which enables the driver to use regmap API thus removing
the redundant and common code.

Shreeya Patel (3):
  Staging: iio: adt7316: Remove irq from bus structure
  Staging: iio: adt7316: Remove multi read and write functions
  Staging: iio: adt7316: Add regmap support

 drivers/staging/iio/addac/adt7316-i2c.c | 101 ++--------------
 drivers/staging/iio/addac/adt7316-spi.c |  95 +++------------
 drivers/staging/iio/addac/adt7316.c     | 147 ++++++++++++------------
 drivers/staging/iio/addac/adt7316.h     |  15 +--
 4 files changed, 103 insertions(+), 255 deletions(-)

Comments

Jonathan Cameron Jan. 19, 2019, 7:04 p.m. UTC | #1 
On Sun, 20 Jan 2019 00:09:29 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:

> This patchset consist of some initial patches for heading
> towards the regmap implementation and also the final patch
> which enables the driver to use regmap API thus removing
> the redundant and common code.
> 
> Shreeya Patel (3):
>   Staging: iio: adt7316: Remove irq from bus structure
>   Staging: iio: adt7316: Remove multi read and write functions
>   Staging: iio: adt7316: Add regmap support
> 
>  drivers/staging/iio/addac/adt7316-i2c.c | 101 ++--------------
>  drivers/staging/iio/addac/adt7316-spi.c |  95 +++------------
>  drivers/staging/iio/addac/adt7316.c     | 147 ++++++++++++------------
>  drivers/staging/iio/addac/adt7316.h     |  15 +--
>  4 files changed, 103 insertions(+), 255 deletions(-)
> 

Hi Shreeya,

I'm not seeing a change log for any of these. Please make sure to
add one so we know what changed since V1.  Saves a lot of trying
to remember things from a while back!

Thanks,

Jonathan
Shreeya Patel Jan. 19, 2019, 7:09 p.m. UTC | #2 
On Sat, 2019-01-19 at 19:04 +0000, Jonathan Cameron wrote:
> On Sun, 20 Jan 2019 00:09:29 +0530
> Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> 
> > This patchset consist of some initial patches for heading
> > towards the regmap implementation and also the final patch
> > which enables the driver to use regmap API thus removing
> > the redundant and common code.
> > 
> > Shreeya Patel (3):
> >   Staging: iio: adt7316: Remove irq from bus structure
> >   Staging: iio: adt7316: Remove multi read and write functions
> >   Staging: iio: adt7316: Add regmap support
> > 
> >  drivers/staging/iio/addac/adt7316-i2c.c | 101 ++--------------
> >  drivers/staging/iio/addac/adt7316-spi.c |  95 +++------------
> >  drivers/staging/iio/addac/adt7316.c     | 147 ++++++++++++------
> > ------
> >  drivers/staging/iio/addac/adt7316.h     |  15 +--
> >  4 files changed, 103 insertions(+), 255 deletions(-)
> > 
> 
> Hi Shreeya,
> 
> I'm not seeing a change log for any of these. Please make sure to
> add one so we know what changed since V1.  Saves a lot of trying
> to remember things from a while back!
> 

Sorry, I forgot to add it. I remembered it when I had already sent the
patches. 
I'll also cc Jeremy in V3.

Thanks

> Thanks,
> 
> Jonathan