diff mbox series

ARM: dts: imx6qdl-apalis: add phy-supply

Message ID 20190118133218.19917-1-stefan@agner.ch (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx6qdl-apalis: add phy-supply | expand

Commit Message

Stefan Agner Jan. 18, 2019, 1:32 p.m. UTC 
Use the VDD I/O rail as phy-supply regulator. Technically, the
regulator has multiple rails, but currently the driver only
supports a single phy-supply. The VDD I/O rail has the highest
power consumption when software power down is used and hence
the highest saving potential.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Schenker Jan. 21, 2019, 8:35 a.m. UTC | #1 
On Fri, 2019-01-18 at 14:32 +0100, Stefan Agner wrote:
> Use the VDD I/O rail as phy-supply regulator. Technically, the
> regulator has multiple rails, but currently the driver only
> supports a single phy-supply. The VDD I/O rail has the highest
> power consumption when software power down is used and hence
> the highest saving potential.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com>

> ---
>  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 0b47aecf336a..cf66f9ececbd 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -241,6 +241,7 @@
>  	phy-handle = <&ethphy>;
>  	phy-reset-duration = <10>;
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> +	phy-supply = <&vgen5_reg>;
>  	status = "okay";
>  
>  	mdio {
Stefan Agner Jan. 21, 2019, 2:30 p.m. UTC | #2 
On 18.01.2019 14:32, Stefan Agner wrote:
> Use the VDD I/O rail as phy-supply regulator. Technically, the
> regulator has multiple rails, but currently the driver only
> supports a single phy-supply. The VDD I/O rail has the highest
> power consumption when software power down is used and hence
> the highest saving potential.

Please don't merge this patch. The vgen5_reg is also used as a pull-up
for USB ID pin, it would not be safe for the FEC driver to disable this
rail.

--
Stefan


> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 0b47aecf336a..cf66f9ececbd 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -241,6 +241,7 @@
>  	phy-handle = <&ethphy>;
>  	phy-reset-duration = <10>;
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> +	phy-supply = <&vgen5_reg>;
>  	status = "okay";
>  
>  	mdio {
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 0b47aecf336a..cf66f9ececbd 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
@@ -241,6 +241,7 @@ 
 	phy-handle = <&ethphy>;
 	phy-reset-duration = <10>;
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+	phy-supply = <&vgen5_reg>;
 	status = "okay";
 
 	mdio {