| Message ID | 20190121231958.28255-2-okaya@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [for,next,1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 | expand |
On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. > > PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been > mentioned in the Kconfig. > > Add an explicit dependency here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- > arch/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 568f339595ed..0519da6f8ee4 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -199,7 +199,7 @@ config X86 > select IRQ_FORCED_THREADING > select NEED_SG_DMA_LENGTH > select PCI_DOMAINS if PCI > - select PCI_LOCKLESS_CONFIG > + select PCI_LOCKLESS_CONFIG if PCI > select PERF_EVENTS > select RTC_LIB > select RTC_MC146818_LIB > -- AFAICT, this is not really fixing a random config build issue but only correcting the dependency, right?
On 1/22/19, Borislav Petkov <bp@alien8.de> wrote: > On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote: >> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without >> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were >> satisfied implicitly through dependencies on CONFIG_ACPI have to be >> specified directly. >> >> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been >> mentioned in the Kconfig. >> >> Add an explicit dependency here. >> >> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI >> set") >> Signed-off-by: Sinan Kaya <okaya@kernel.org> >> --- >> arch/x86/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index 568f339595ed..0519da6f8ee4 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -199,7 +199,7 @@ config X86 >> select IRQ_FORCED_THREADING >> select NEED_SG_DMA_LENGTH >> select PCI_DOMAINS if PCI >> - select PCI_LOCKLESS_CONFIG >> + select PCI_LOCKLESS_CONFIG if PCI >> select PERF_EVENTS >> select RTC_LIB >> select RTC_MC146818_LIB >> -- > > AFAICT, this is not really fixing a random config build issue but only > correcting the dependency, right? > This is fixing a warning found by randconfig on this thread 'linux-next: Tree for Jan 16 (PCI config warning?)' > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply. >
On Tuesday, January 22, 2019 12:19:58 AM CET Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. > > PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been > mentioned in the Kconfig. > > Add an explicit dependency here. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- > arch/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 568f339595ed..0519da6f8ee4 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -199,7 +199,7 @@ config X86 > select IRQ_FORCED_THREADING > select NEED_SG_DMA_LENGTH > select PCI_DOMAINS if PCI > - select PCI_LOCKLESS_CONFIG > + select PCI_LOCKLESS_CONFIG if PCI > select PERF_EVENTS > select RTC_LIB > select RTC_MC146818_LIB > Is anyone taking this or should I?
On 1/24/2019 5:51 AM, Rafael J. Wysocki wrote: >> > Is anyone taking this or should I? > > > This got applied: https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 568f339595ed..0519da6f8ee4 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -199,7 +199,7 @@ config X86 select IRQ_FORCED_THREADING select NEED_SG_DMA_LENGTH select PCI_DOMAINS if PCI - select PCI_LOCKLESS_CONFIG + select PCI_LOCKLESS_CONFIG if PCI select PERF_EVENTS select RTC_LIB select RTC_MC146818_LIB
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been mentioned in the Kconfig. Add an explicit dependency here. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya@kernel.org> --- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)