| Message ID | 20190116112855.13824-1-laurentiu.tudor@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] i2c: imx: fix dma_request_chan error handling | expand |
Hello, On Wed, Jan 16, 2019 at 01:28:54PM +0200, Laurentiu Tudor wrote: > Use the correct error pointer when extracting the error code. > > Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request") > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On Wed, Jan 16, 2019 at 01:28:54PM +0200, Laurentiu Tudor wrote: > Use the correct error pointer when extracting the error code. > > Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request") This is not the sha1 in my tree. Maybe you rebased? I applied another patch meanwhile fixing the same issue. Still thanks! > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> > --- > drivers/i2c/busses/i2c-imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index 09b124547669..42fed40198a0 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -287,7 +287,7 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, > > dma->chan_tx = dma_request_chan(dev, "tx"); > if (IS_ERR(dma->chan_tx)) { > - ret = PTR_ERR(dma->chan_rx); > + ret = PTR_ERR(dma->chan_tx); > if (ret != -ENODEV && ret != -EPROBE_DEFER) > dev_err(dev, "can't request DMA tx channel (%d)\n", ret); > goto fail_al; > -- > 2.17.1 >
Hi Wolfram, > -----Original Message----- > From: Wolfram Sang [mailto:wsa@the-dreams.de] > Sent: Wednesday, January 23, 2019 12:52 AM > > On Wed, Jan 16, 2019 at 01:28:54PM +0200, Laurentiu Tudor wrote: > > Use the correct error pointer when extracting the error code. > > > > Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma > i2c_imx_dma_request") > > This is not the sha1 in my tree. Maybe you rebased? I applied another > patch meanwhile fixing the same issue. Still thanks! I don't know, perhaps I was on some transient snapshot. Anyway, good that in the end it's fixed. --- Best Regards, Laurentiu > > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> > > --- > > drivers/i2c/busses/i2c-imx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > > index 09b124547669..42fed40198a0 100644 > > --- a/drivers/i2c/busses/i2c-imx.c > > +++ b/drivers/i2c/busses/i2c-imx.c > > @@ -287,7 +287,7 @@ static int i2c_imx_dma_request(struct imx_i2c_struct > *i2c_imx, > > > > dma->chan_tx = dma_request_chan(dev, "tx"); > > if (IS_ERR(dma->chan_tx)) { > > - ret = PTR_ERR(dma->chan_rx); > > + ret = PTR_ERR(dma->chan_tx); > > if (ret != -ENODEV && ret != -EPROBE_DEFER) > > dev_err(dev, "can't request DMA tx channel (%d)\n", > ret); > > goto fail_al; > > -- > > 2.17.1 > >
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 09b124547669..42fed40198a0 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -287,7 +287,7 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, dma->chan_tx = dma_request_chan(dev, "tx"); if (IS_ERR(dma->chan_tx)) { - ret = PTR_ERR(dma->chan_rx); + ret = PTR_ERR(dma->chan_tx); if (ret != -ENODEV && ret != -EPROBE_DEFER) dev_err(dev, "can't request DMA tx channel (%d)\n", ret); goto fail_al;
Use the correct error pointer when extracting the error code. Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request") Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> --- drivers/i2c/busses/i2c-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)