| Message ID | 20190121120203.13644-1-jack@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] loop: Add test for changing capacity when filesystem is mounted | expand |
Looks good to me. Reviewed-by:- Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>. From: linux-block-owner@vger.kernel.org <linux-block-owner@vger.kernel.org> on behalf of Jan Kara <jack@suse.cz> Sent: Monday, January 21, 2019 4:02 AM To: Omar Sandoval Cc: linux-block@vger.kernel.org; Jan Kara Subject: [PATCH v2] loop: Add test for changing capacity when filesystem is mounted Add test for changing capacity of a loop device when a filesystem with non-default block size is mounted on it. This is a regression test for "blockdev: Fix livelocks on loop device". Signed-off-by: Jan Kara <jack@suse.cz> --- tests/loop/007 | 39 +++++++++++++++++++++++++++++++++++++++ tests/loop/007.out | 2 ++ 2 files changed, 41 insertions(+) create mode 100755 tests/loop/007 create mode 100644 tests/loop/007.out diff --git a/tests/loop/007 b/tests/loop/007 new file mode 100755 index 000000000000..97e6468de4e5 --- /dev/null +++ b/tests/loop/007 @@ -0,0 +1,39 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-3.0+ +# Copyright (C) 2019 Jan Kara +# +# Test loop device capacity change handling with filesystem mounted on top. +# +# Regression test for commit 04906b2f542c "blockdev: Fix livelocks on loop +# device". +# + +. tests/loop/rc + +DESCRIPTION="update loop device capacity with filesystem" + +QUICK=1 + +requires() { + _have_program mkfs.ext4 +} + +test() { + echo "Running ${TEST_NAME}" + + local mount_dir="/mnt/blktests/" + + truncate -s 1G "$TMPDIR/img" + mkdir -p "$mount_dir" + local loop_device="$(losetup -P -f --show "$TMPDIR/img")" + mkfs.ext4 -b 1024 "$loop_device" &>/dev/null + mount -t ext4 "$loop_device" "$mount_dir" + losetup -c "$loop_device" + # This hangs if rereading capacity changed block size + ls -l "$mount_dir" >/dev/null + umount "$mount_dir" + losetup -d "$loop_device" + rm -fr "$mount_dir" "$TMPDIR/img" + + echo "Test complete" +} diff --git a/tests/loop/007.out b/tests/loop/007.out new file mode 100644 index 000000000000..32752934d48a --- /dev/null +++ b/tests/loop/007.out @@ -0,0 +1,2 @@ +Running loop/007 +Test complete
On Mon, Jan 21, 2019 at 01:02:03PM +0100, Jan Kara wrote: > Add test for changing capacity of a loop device when a filesystem with > non-default block size is mounted on it. This is a regression test for > "blockdev: Fix livelocks on loop device". > > Signed-off-by: Jan Kara <jack@suse.cz> Thanks, Jan, applied.
diff --git a/tests/loop/007 b/tests/loop/007 new file mode 100755 index 000000000000..97e6468de4e5 --- /dev/null +++ b/tests/loop/007 @@ -0,0 +1,39 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-3.0+ +# Copyright (C) 2019 Jan Kara +# +# Test loop device capacity change handling with filesystem mounted on top. +# +# Regression test for commit 04906b2f542c "blockdev: Fix livelocks on loop +# device". +# + +. tests/loop/rc + +DESCRIPTION="update loop device capacity with filesystem" + +QUICK=1 + +requires() { + _have_program mkfs.ext4 +} + +test() { + echo "Running ${TEST_NAME}" + + local mount_dir="/mnt/blktests/" + + truncate -s 1G "$TMPDIR/img" + mkdir -p "$mount_dir" + local loop_device="$(losetup -P -f --show "$TMPDIR/img")" + mkfs.ext4 -b 1024 "$loop_device" &>/dev/null + mount -t ext4 "$loop_device" "$mount_dir" + losetup -c "$loop_device" + # This hangs if rereading capacity changed block size + ls -l "$mount_dir" >/dev/null + umount "$mount_dir" + losetup -d "$loop_device" + rm -fr "$mount_dir" "$TMPDIR/img" + + echo "Test complete" +} diff --git a/tests/loop/007.out b/tests/loop/007.out new file mode 100644 index 000000000000..32752934d48a --- /dev/null +++ b/tests/loop/007.out @@ -0,0 +1,2 @@ +Running loop/007 +Test complete
Add test for changing capacity of a loop device when a filesystem with non-default block size is mounted on it. This is a regression test for "blockdev: Fix livelocks on loop device". Signed-off-by: Jan Kara <jack@suse.cz> --- tests/loop/007 | 39 +++++++++++++++++++++++++++++++++++++++ tests/loop/007.out | 2 ++ 2 files changed, 41 insertions(+) create mode 100755 tests/loop/007 create mode 100644 tests/loop/007.out