| Message ID | 1548252470-17920-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: defconfig: Enable BCM2835_POWER for bcm2835 and multi_v7 | expand |
Hi Stefan, On 2019-01-23 6:07 a.m., Stefan Wahren wrote: > Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the > PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. > > Otherwise the driver won't probe and HDMI output stays black: > vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm/configs/bcm2835_defconfig | 1 + > arch/arm/configs/multi_v7_defconfig | 1 + > 2 files changed, 2 insertions(+) Seems more fool proof to add a default ARCH_BCM3825 in the Kconfig instead of modifying multiple defconfig files. And that way users with custom defconfig files for 2835 will get the config change automatically. > > diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig > index bb6a35f..28aacdd 100644 > --- a/arch/arm/configs/bcm2835_defconfig > +++ b/arch/arm/configs/bcm2835_defconfig > @@ -132,6 +132,7 @@ CONFIG_SND_BCM2835=m > CONFIG_MAILBOX=y > CONFIG_BCM2835_MBOX=y > # CONFIG_IOMMU_SUPPORT is not set > +CONFIG_BCM2835_POWER=y > CONFIG_RASPBERRYPI_POWER=y > CONFIG_PWM=y > CONFIG_PWM_BCM2835=y > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index ffaf5c0..7deb404 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -900,6 +900,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y > CONFIG_REMOTEPROC=m > CONFIG_ST_REMOTEPROC=m > CONFIG_RPMSG_VIRTIO=m > +CONFIG_BCM2835_POWER=y > CONFIG_RASPBERRYPI_POWER=y > CONFIG_QCOM_GSBI=y > CONFIG_QCOM_PM=y Regards, Scott
Hi Scott, > Scott Branden <scott.branden@broadcom.com> hat am 23. Januar 2019 um 17:41 geschrieben: > > > Hi Stefan, > > On 2019-01-23 6:07 a.m., Stefan Wahren wrote: > > Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the > > PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. > > > > Otherwise the driver won't probe and HDMI output stays black: > > vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver > > > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > > --- > > arch/arm/configs/bcm2835_defconfig | 1 + > > arch/arm/configs/multi_v7_defconfig | 1 + > > 2 files changed, 2 insertions(+) > > Seems more fool proof to add a default ARCH_BCM3825 in the Kconfig > > instead of modifying multiple defconfig files. > > And that way users with custom defconfig files for 2835 will get the > config change automatically. i already thought about this, but it didn't worked for arm64. Maybe i missed something.
Hi Stefan, On 2019-01-23 9:22 a.m., Stefan Wahren wrote: > Hi Scott, > >> Scott Branden <scott.branden@broadcom.com> hat am 23. Januar 2019 um 17:41 geschrieben: >> >> >> Hi Stefan, >> >> On 2019-01-23 6:07 a.m., Stefan Wahren wrote: >>> Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the >>> PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. >>> >>> Otherwise the driver won't probe and HDMI output stays black: >>> vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver >>> >>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> >>> --- >>> arch/arm/configs/bcm2835_defconfig | 1 + >>> arch/arm/configs/multi_v7_defconfig | 1 + >>> 2 files changed, 2 insertions(+) >> Seems more fool proof to add a default ARCH_BCM3825 in the Kconfig >> >> instead of modifying multiple defconfig files. >> >> And that way users with custom defconfig files for 2835 will get the >> config change automatically. > i already thought about this, but it didn't worked for arm64. Maybe i missed something. ARCH_BCM2835 exists in arch/arm64/Kconfig.platforms and is set in arch/arm64/configs/defconfig. So I don't see why it wouldn't work?
diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig index bb6a35f..28aacdd 100644 --- a/arch/arm/configs/bcm2835_defconfig +++ b/arch/arm/configs/bcm2835_defconfig @@ -132,6 +132,7 @@ CONFIG_SND_BCM2835=m CONFIG_MAILBOX=y CONFIG_BCM2835_MBOX=y # CONFIG_IOMMU_SUPPORT is not set +CONFIG_BCM2835_POWER=y CONFIG_RASPBERRYPI_POWER=y CONFIG_PWM=y CONFIG_PWM_BCM2835=y diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index ffaf5c0..7deb404 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -900,6 +900,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y CONFIG_REMOTEPROC=m CONFIG_ST_REMOTEPROC=m CONFIG_RPMSG_VIRTIO=m +CONFIG_BCM2835_POWER=y CONFIG_RASPBERRYPI_POWER=y CONFIG_QCOM_GSBI=y CONFIG_QCOM_PM=y
Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. Otherwise the driver won't probe and HDMI output stays black: vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/configs/bcm2835_defconfig | 1 + arch/arm/configs/multi_v7_defconfig | 1 + 2 files changed, 2 insertions(+)