| Message ID | 1548282236-3962-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: BCM2835: Enable PM driver | expand |
Hi Stefan, On 2019-01-23 2:23 p.m., Stefan Wahren wrote: > Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the > PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. > > Otherwise the driver won't probe and HDMI output stays black: > vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm/mach-bcm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Hi, please ignore the preceding defconfig changes. > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 4ef1e55..b7dbfbc 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -165,6 +165,7 @@ config ARCH_BCM2835 > select HAVE_ARM_ARCH_TIMER if ARCH_MULTI_V7 > select TIMER_OF > select BCM2835_TIMER > + select BCM2835_POWER The use of select is discouraged (as then the driver can never be turned off). If raspberry pi can be used without BCM2835_POWER then select should not be used. Should the change should just be made in "config BCM2835_POWER" to add "default ARCH_BCM2835" ? > select PINCTRL > select PINCTRL_BCM2835 > select MFD_CORE Regards, Scott
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 4ef1e55..b7dbfbc 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -165,6 +165,7 @@ config ARCH_BCM2835 select HAVE_ARM_ARCH_TIMER if ARCH_MULTI_V7 select TIMER_OF select BCM2835_TIMER + select BCM2835_POWER select PINCTRL select PINCTRL_BCM2835 select MFD_CORE
Since commit 52a4adbaebcc ("ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware.") VC4 on BCM2835 requires the power driver. Otherwise the driver won't probe and HDMI output stays black: vc4_v3d 20c00000.v3d: ignoring dependency for device, assuming no driver Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/mach-bcm/Kconfig | 1 + 1 file changed, 1 insertion(+) Hi, please ignore the preceding defconfig changes.