| Message ID | 20190124142755.GA31059@bhar.linux (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers: iio: industrialio-core: add check when kzalloc fails | expand |
On Thu, Jan 24, 2019 at 4:28 PM Bharath Vedartham <linux.bhar@gmail.com> wrote: > > add code to handle the case when kzalloc fails to allocate memory to dev > > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com> > --- > drivers/iio/industrialio-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index 4f5cd9f..93caa6b 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -1475,6 +1475,8 @@ struct iio_dev *iio_device_alloc(int sizeof_priv) > } > dev_set_name(&dev->dev, "iio:device%d", dev->id); > INIT_LIST_HEAD(&dev->buffer_list); > + } else { > + return NULL; I'd argue that this is a bit redundant, because `dev` is NULL, the return below (return dev) will also return NULL. Alex > } > > return dev; > -- > 2.7.4 >
On Fri, Jan 25, 2019 at 08:55:27AM +0200, Alexandru Ardelean wrote: > On Thu, Jan 24, 2019 at 4:28 PM Bharath Vedartham <linux.bhar@gmail.com> wrote: > > > > add code to handle the case when kzalloc fails to allocate memory to dev > > > > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com> > > --- > > drivers/iio/industrialio-core.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > > index 4f5cd9f..93caa6b 100644 > > --- a/drivers/iio/industrialio-core.c > > +++ b/drivers/iio/industrialio-core.c > > @@ -1475,6 +1475,8 @@ struct iio_dev *iio_device_alloc(int sizeof_priv) > > } > > dev_set_name(&dev->dev, "iio:device%d", dev->id); > > INIT_LIST_HEAD(&dev->buffer_list); > > + } else { > > + return NULL; > > I'd argue that this is a bit redundant, because `dev` is NULL, the > return below (return dev) will also return NULL. +1 Also, subject title is incorrect. Always use: $ git log --oneline drivers/iio/industrialio-core.c Use the most frequently tag/subject from the output of above command. "iio: core: ...." would be fine.
On Fri, Jan 25, 2019 at 04:23:13PM +0530, Himanshu Jha wrote: > On Fri, Jan 25, 2019 at 08:55:27AM +0200, Alexandru Ardelean wrote: > > On Thu, Jan 24, 2019 at 4:28 PM Bharath Vedartham <linux.bhar@gmail.com> wrote: > > > > > > add code to handle the case when kzalloc fails to allocate memory to dev > > > > > > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com> > > > --- > > > drivers/iio/industrialio-core.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > > > index 4f5cd9f..93caa6b 100644 > > > --- a/drivers/iio/industrialio-core.c > > > +++ b/drivers/iio/industrialio-core.c > > > @@ -1475,6 +1475,8 @@ struct iio_dev *iio_device_alloc(int sizeof_priv) > > > } > > > dev_set_name(&dev->dev, "iio:device%d", dev->id); > > > INIT_LIST_HEAD(&dev->buffer_list); > > > + } else { > > > + return NULL; > > > > I'd argue that this is a bit redundant, because `dev` is NULL, the > > return below (return dev) will also return NULL. Agreed. I will read the code more carefully from next time. Thank you :) > > +1 > > Also, subject title is incorrect. > > Always use: > > $ git log --oneline drivers/iio/industrialio-core.c > > Use the most frequently tag/subject from the output of above > command. > > "iio: core: ...." would be fine. > > > -- > Himanshu Jha > Undergraduate Student > Department of Electronics & Communication > Guru Tegh Bahadur Institute of Technology Yes will do that from next time. I was of the understanding that this header was good enough. Thank you, Bharath
On Thu, 24 Jan 2019 19:58:00 +0530, Bharath Vedartham said: > add code to handle the case when kzalloc fails to allocate memory to dev > > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com> > dev_set_name(&dev->dev, "iio:device%d", dev->id); > INIT_LIST_HEAD(&dev->buffer_list); > + } else { > + return NULL; > } > > return dev; Not needed, as the 'if (dev)' statement fails, dev is already null.
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c index 4f5cd9f..93caa6b 100644 --- a/drivers/iio/industrialio-core.c +++ b/drivers/iio/industrialio-core.c @@ -1475,6 +1475,8 @@ struct iio_dev *iio_device_alloc(int sizeof_priv) } dev_set_name(&dev->dev, "iio:device%d", dev->id); INIT_LIST_HEAD(&dev->buffer_list); + } else { + return NULL; } return dev;
add code to handle the case when kzalloc fails to allocate memory to dev Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com> --- drivers/iio/industrialio-core.c | 2 ++ 1 file changed, 2 insertions(+)