diff mbox series

restorecond: Install DBUS service file with 644 permissions

Message ID 20190122114724.1766-1-plautrba@redhat.com (mailing list archive)
State Accepted
Headers show
Series restorecond: Install DBUS service file with 644 permissions | expand

Commit Message

Petr Lautrbach Jan. 22, 2019, 11:47 a.m. UTC 
The original 600 permissions make the service file unreadable for dbus daemon.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1626462

Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---
 restorecond/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Smalley Jan. 23, 2019, 2:19 p.m. UTC | #1 
On 1/22/19 6:47 AM, Petr Lautrbach wrote:
> The original 600 permissions make the service file unreadable for dbus daemon.
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1626462
> 
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>

Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

> ---
>   restorecond/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/restorecond/Makefile b/restorecond/Makefile
> index 8a0ada1f..6155ca4a 100644
> --- a/restorecond/Makefile
> +++ b/restorecond/Makefile
> @@ -50,7 +50,7 @@ install: all
>   	-mkdir -p $(DESTDIR)$(AUTOSTARTDIR)
>   	install -m 644 restorecond.desktop $(DESTDIR)$(AUTOSTARTDIR)/restorecond.desktop
>   	-mkdir -p $(DESTDIR)$(DBUSSERVICEDIR)
> -	install -m 600 org.selinux.Restorecond.service  $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
> +	install -m 644 org.selinux.Restorecond.service  $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
>   	-mkdir -p $(DESTDIR)$(SYSTEMDDIR)/system
>   	install -m 644 restorecond.service $(DESTDIR)$(SYSTEMDDIR)/system/
>   relabel: install
>
Petr Lautrbach Jan. 25, 2019, 2:05 p.m. UTC | #2 
Stephen Smalley <sds@tycho.nsa.gov> writes:

> On 1/22/19 6:47 AM, Petr Lautrbach wrote:
>> The original 600 permissions make the service file unreadable for dbus daemon.
>>
>> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1626462
>>
>> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

Merged.

>> ---
>>   restorecond/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/restorecond/Makefile b/restorecond/Makefile
>> index 8a0ada1f..6155ca4a 100644
>> --- a/restorecond/Makefile
>> +++ b/restorecond/Makefile
>> @@ -50,7 +50,7 @@ install: all
>>   	-mkdir -p $(DESTDIR)$(AUTOSTARTDIR)
>>   	install -m 644 restorecond.desktop $(DESTDIR)$(AUTOSTARTDIR)/restorecond.desktop
>>   	-mkdir -p $(DESTDIR)$(DBUSSERVICEDIR)
>> -	install -m 600 org.selinux.Restorecond.service  $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
>> +	install -m 644 org.selinux.Restorecond.service  $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
>>   	-mkdir -p $(DESTDIR)$(SYSTEMDDIR)/system
>>   	install -m 644 restorecond.service $(DESTDIR)$(SYSTEMDDIR)/system/
>>   relabel: install
>>
diff mbox series

Patch

diff --git a/restorecond/Makefile b/restorecond/Makefile
index 8a0ada1f..6155ca4a 100644
--- a/restorecond/Makefile
+++ b/restorecond/Makefile
@@ -50,7 +50,7 @@  install: all
 	-mkdir -p $(DESTDIR)$(AUTOSTARTDIR)
 	install -m 644 restorecond.desktop $(DESTDIR)$(AUTOSTARTDIR)/restorecond.desktop
 	-mkdir -p $(DESTDIR)$(DBUSSERVICEDIR)
-	install -m 600 org.selinux.Restorecond.service  $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
+	install -m 644 org.selinux.Restorecond.service  $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
 	-mkdir -p $(DESTDIR)$(SYSTEMDDIR)/system
 	install -m 644 restorecond.service $(DESTDIR)$(SYSTEMDDIR)/system/
 relabel: install