| Message ID | fc43bfa2-4312-b52b-a749-e3e43e242a95@cogentembedded.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | sh_eth: implement simple RX checksum offload | expand |
On 27.01.2019 18:33, Sergei Shtylyov wrote: > Hello! > > Here's a set of 7 patches against DaveM's 'net-next.git' repo. I'm implemeting > the simple RX checksum offload (like was done for the 'ravb' driver by Simon > Horman); it was only tested on the R8A77980 SoC, the other SoCs should just > work (according to their manuals)... > > [1/7] sh_eth: rename sh_eth_cpu_data::hw_checksum > [2/7] sh_eth: RX checksum offload support > [3/7] sh_eth: offload RX checksum on R7S72100 > [4/7] sh_eth: offload RX checksum on R8A7740 > [5/7] sh_eth: offload RX checksum on R8A77980 > [6/7] sh_eth: offload RX checksum on SH7734 > [7/7] sh_eth: offload RX checksum on SH7763 > > MBR, Sergei > Hi Sergei, the formatting of the patch series isn't in line with the netdev standards. See here: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html - cover letter isn't generated by git - That's not ok --- *net-next.orig/*drivers/net/ethernet/renesas/sh_eth.h +++ *net-next/*drivers/net/ethernet/renesas/sh_eth.h - patches miss net / net-next annotation Heiner
Hello! On 01/27/2019 08:52 PM, Heiner Kallweit wrote: >> Here's a set of 7 patches against DaveM's 'net-next.git' repo. I'm implemeting >> the simple RX checksum offload (like was done for the 'ravb' driver by Simon >> Horman); it was only tested on the R8A77980 SoC, the other SoCs should just >> work (according to their manuals)... >> >> [1/7] sh_eth: rename sh_eth_cpu_data::hw_checksum >> [2/7] sh_eth: RX checksum offload support >> [3/7] sh_eth: offload RX checksum on R7S72100 >> [4/7] sh_eth: offload RX checksum on R8A7740 >> [5/7] sh_eth: offload RX checksum on R8A77980 >> [6/7] sh_eth: offload RX checksum on SH7734 >> [7/7] sh_eth: offload RX checksum on SH7763 >> >> MBR, Sergei >> > Hi Sergei, > > the formatting of the patch series isn't in line with the netdev standards. > See here: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html > > - cover letter isn't generated by git Sorry, I don't use git for development. However, I fail to see where this is requested in the above FAQ. > > - That's not ok > --- *net-next.orig/*drivers/net/ethernet/renesas/sh_eth.h > +++ *net-next/*drivers/net/ethernet/renesas/sh_eth.h > > - patches miss net / net-next annotation I noted the applicable repo in the cover letter. I know I should use the subject... but I just keep forgetting about this requirement. :-) > Heiner MBR, Sergei