| Message ID | 1536200965-121172-1-git-send-email-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: snoc: remove set but not used variable 'ar_snoc' | expand |
ping... On 2018/9/6 10:29, YueHaibing wrote: > From: Yue Haibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_tx_pipe_cleanup': > drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning: > variable 'ar_snoc' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > drivers/net/wireless/ath/ath10k/snoc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c > index fa1843a..2d6ae00 100644 > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -678,13 +678,11 @@ static void ath10k_snoc_tx_pipe_cleanup(struct ath10k_snoc_pipe *snoc_pipe) > { > struct ath10k_ce_pipe *ce_pipe; > struct ath10k_ce_ring *ce_ring; > - struct ath10k_snoc *ar_snoc; > struct sk_buff *skb; > struct ath10k *ar; > int i; > > ar = snoc_pipe->hif_ce_state; > - ar_snoc = ath10k_snoc_priv(ar); > ce_pipe = snoc_pipe->ce_hdl; > ce_ring = ce_pipe->src_ring; > > > . >
On Mon, Jan 28, 2019 at 9:53 PM YueHaibing <yuehaibing@huawei.com> wrote: > > ping... For some reason, your patch shows up as Deferred in patchwork: https://patchwork.kernel.org/patch/10589789/ So the maintainers have accidentally (?) ignored it. I'm not what the official suggestion is for that, but you might just resend. In any case... > On 2018/9/6 10:29, YueHaibing wrote: > > From: Yue Haibing <yuehaibing@huawei.com> > > > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_tx_pipe_cleanup': > > drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning: > > variable 'ar_snoc' set but not used [-Wunused-but-set-variable] > > > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> ...patch looks fine to me: Reviewed-by: Brian Norris <briannorris@chromium.org>
On 2019/1/30 2:12, Brian Norris wrote: > On Mon, Jan 28, 2019 at 9:53 PM YueHaibing <yuehaibing@huawei.com> wrote: >> >> ping... > > For some reason, your patch shows up as Deferred in patchwork: > > https://patchwork.kernel.org/patch/10589789/ > > So the maintainers have accidentally (?) ignored it. I'm not what the > official suggestion is for that, but you might just resend. Thank you for your review, I'll resend it. > > In any case... > >> On 2018/9/6 10:29, YueHaibing wrote: >>> From: Yue Haibing <yuehaibing@huawei.com> >>> >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_tx_pipe_cleanup': >>> drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning: >>> variable 'ar_snoc' set but not used [-Wunused-but-set-variable] >>> >>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > > ...patch looks fine to me: > > Reviewed-by: Brian Norris <briannorris@chromium.org> > >
Brian Norris <briannorris@chromium.org> writes: > On Mon, Jan 28, 2019 at 9:53 PM YueHaibing <yuehaibing@huawei.com> wrote: >> >> ping... > > For some reason, your patch shows up as Deferred in patchwork: > > https://patchwork.kernel.org/patch/10589789/ > > So the maintainers have accidentally (?) ignored it. Actually I put it deliberately to deferred as I wanted to apply Govind's QMI patches first and only then this. But unfortunately the deferred patches have been piled up by other patches so I haven't taken this patch yet. > I'm not what the official suggestion is for that, but you might just > resend. No need to resend, I can just change the state from Deferred to New. But I see that the patch was already resent so I'll drop this version now.
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index fa1843a..2d6ae00 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -678,13 +678,11 @@ static void ath10k_snoc_tx_pipe_cleanup(struct ath10k_snoc_pipe *snoc_pipe) { struct ath10k_ce_pipe *ce_pipe; struct ath10k_ce_ring *ce_ring; - struct ath10k_snoc *ar_snoc; struct sk_buff *skb; struct ath10k *ar; int i; ar = snoc_pipe->hif_ce_state; - ar_snoc = ath10k_snoc_priv(ar); ce_pipe = snoc_pipe->ce_hdl; ce_ring = ce_pipe->src_ring;