[26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT

Commit Message

Daniel Vetter Jan. 24, 2019, 4:58 p.m. UTC

It's 0.

Signed-off-by: Daniel Vetter <[e-mail]>
Cc: Inki Dae <[e-mail]>
Cc: Joonyoung Shim <[e-mail]>
Cc: Seung-Woo Kim <[e-mail]>
Cc: Kyungmin Park <[e-mail]>
Cc: Kukjin Kim <[e-mail]>
Cc: Krzysztof Kozlowski <[e-mail]>
Cc: Patrik Jakobsson <[e-mail]>
Cc: Ben Skeggs <[e-mail]>
Cc: Sandy Huang <[e-mail]>
Cc: "Heiko Stübner" <[e-mail]>
Cc: Thierry Reding <[e-mail]>
Cc: Jonathan Hunter <[e-mail]>
Cc: Hans de Goede <[e-mail]>
Cc: Greg Kroah-Hartman <[e-mail]>
Cc: Daniel Vetter <[e-mail]>
Cc: Bartlomiej Zolnierkiewicz <[e-mail]>
Cc: Alexander Kapshuk <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c     | 1 -
 drivers/gpu/drm/gma500/framebuffer.c          | 1 -
 drivers/gpu/drm/nouveau/nouveau_fbcon.c       | 4 ++--
 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 -
 drivers/gpu/drm/tegra/fb.c                    | 1 -
 5 files changed, 2 insertions(+), 6 deletions(-)

Comments

Emil Velikov Jan. 25, 2019, 3:02 p.m. UTC | #1

On Thu, 24 Jan 2019 at 17:00, Daniel Vetter <[e-mail]> wrote:
>
> It's 0.
>
I'd add a bit more information here. Feel free to reuse as much/little
of the following:

Both macros evaluate to 0. At the same time flag is already set to
zero since the struct is kzalloc'd in framebuffer_alloc().
As called by drm_fb_helper_alloc_fbi() in the DRM drivers.


-Emil

Thierry Reding Jan. 25, 2019, 3:14 p.m. UTC | #2

On Thu, Jan 24, 2019 at 05:58:31PM +0100, Daniel Vetter wrote:
> It's 0.
> 
> Signed-off-by: Daniel Vetter <[e-mail]>
> Cc: Inki Dae <[e-mail]>
> Cc: Joonyoung Shim <[e-mail]>
> Cc: Seung-Woo Kim <[e-mail]>
> Cc: Kyungmin Park <[e-mail]>
> Cc: Kukjin Kim <[e-mail]>
> Cc: Krzysztof Kozlowski <[e-mail]>
> Cc: Patrik Jakobsson <[e-mail]>
> Cc: Ben Skeggs <[e-mail]>
> Cc: Sandy Huang <[e-mail]>
> Cc: "Heiko Stübner" <[e-mail]>
> Cc: Thierry Reding <[e-mail]>
> Cc: Jonathan Hunter <[e-mail]>
> Cc: Hans de Goede <[e-mail]>
> Cc: Greg Kroah-Hartman <[e-mail]>
> Cc: Daniel Vetter <[e-mail]>
> Cc: Bartlomiej Zolnierkiewicz <[e-mail]>
> Cc: Alexander Kapshuk <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c     | 1 -
>  drivers/gpu/drm/gma500/framebuffer.c          | 1 -
>  drivers/gpu/drm/nouveau/nouveau_fbcon.c       | 4 ++--
>  drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 -
>  drivers/gpu/drm/tegra/fb.c                    | 1 -
>  5 files changed, 2 insertions(+), 6 deletions(-)

Acked-by: Thierry Reding <[e-mail]>

Daniel Vetter Jan. 29, 2019, 9:58 a.m. UTC | #3

On Fri, Jan 25, 2019 at 03:02:46PM +0000, Emil Velikov wrote:
> On Thu, 24 Jan 2019 at 17:00, Daniel Vetter <[e-mail]> wrote:
> >
> > It's 0.
> >
> I'd add a bit more information here. Feel free to reuse as much/little
> of the following:
> 
> Both macros evaluate to 0. At the same time flag is already set to
> zero since the struct is kzalloc'd in framebuffer_alloc().
> As called by drm_fb_helper_alloc_fbi() in the DRM drivers.

Added&merged, thanks for your review.
-Daniel

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index b2018961b9cf..00bfcd28e589 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -87,7 +87,6 @@  static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
 		return PTR_ERR(fbi);
 	}
 
-	fbi->flags = FBINFO_FLAG_DEFAULT;
 	fbi->fbops = &exynos_drm_fb_ops;
 
 	drm_fb_helper_fill_info(fbi, helper);
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index c7a5c29f9a69..3b59dbadfa63 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -401,7 +401,6 @@  static int psbfb_create(struct psb_fbdev *fbdev,
 
 	fbdev->psb_fb_helper.fb = fb;
 
-	info->flags = FBINFO_DEFAULT;
 	if (dev_priv->ops->accel_2d && pitch_lines > 8)	/* 2D engine */
 		info->fbops = &psbfb_ops;
 	else if (gtt_roll) {	/* GTT rolling seems best */
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 3a3d454b65e3..1136ee26005f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -370,9 +370,9 @@  nouveau_fbcon_create(struct drm_fb_helper *helper,
 	fbcon->helper.fb = &fb->base;
 
 	if (!chan)
-		info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_DISABLED;
+		info->flags = FBINFO_HWACCEL_DISABLED;
 	else
-		info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_COPYAREA |
+		info->flags = FBINFO_HWACCEL_COPYAREA |
 			      FBINFO_HWACCEL_FILLRECT |
 			      FBINFO_HWACCEL_IMAGEBLIT;
 	info->fbops = &nouveau_fbcon_sw_ops;
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
index d12164878e05..fed7d7698164 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
@@ -90,7 +90,6 @@  static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
 		goto out;
 	}
 
-	fbi->flags = FBINFO_FLAG_DEFAULT;
 	fbi->fbops = &rockchip_drm_fbdev_ops;
 
 	fb = helper->fb;
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 82348ddd0b83..ea82184073bd 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -255,7 +255,6 @@  static int tegra_fbdev_probe(struct drm_fb_helper *helper,
 	helper->fb = fb;
 	helper->fbdev = info;
 
-	info->flags = FBINFO_FLAG_DEFAULT;
 	info->fbops = &tegra_fb_ops;
 
 	drm_fb_helper_fill_info(info, helper);