| Message ID | 20190129111113.GA32222@bogon.m.sigxcpu.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] input: goodix - support Goodix gt5688 | expand |
On Tue, 2019-01-29 at 12:11 +0100, Guido Günther wrote: > From what I've seen in vendor trees it's fine to treat this as gt1x¹. > Tested on the Purism Librem 5 Devkit (Rocktech JH057N00900 panel). > > [1]: > https://github.com/TadiT7/android_kernel_mtk-4.4/tree/master/drivers/input/touchscreen/mediatek/GT5688 > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Not super fond of the casual commit message, but the code and explanation are fine. Reviewed-by: Bastien Nocera <hadess@hadess.net> > --- > Changes from v1: > * Add tested board to commit message > > Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + > drivers/input/touchscreen/goodix.c | 2 > ++ > 2 files changed, 3 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > index f7e95c52f3c7..57d3d8870a09 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > @@ -3,6 +3,7 @@ Device tree bindings for Goodix GT9xx series > touchscreen controller > Required properties: > > - compatible : Should be "goodix,gt1151" > + or "goodix,gt5688" > or "goodix,gt911" > or "goodix,gt9110" > or "goodix,gt912" > diff --git a/drivers/input/touchscreen/goodix.c > b/drivers/input/touchscreen/goodix.c > index f2d9c2c41885..47b1ced41576 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -216,6 +216,7 @@ static const struct goodix_chip_data > *goodix_get_chip_data(u16 id) > { > switch (id) { > case 1151: > + case 5688: > return >1x_chip_data; > > case 911: > @@ -942,6 +943,7 @@ MODULE_DEVICE_TABLE(acpi, goodix_acpi_match); > #ifdef CONFIG_OF > static const struct of_device_id goodix_of_match[] = { > { .compatible = "goodix,gt1151" }, > + { .compatible = "goodix,gt5688" }, > { .compatible = "goodix,gt911" }, > { .compatible = "goodix,gt9110" }, > { .compatible = "goodix,gt912" },
diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt index f7e95c52f3c7..57d3d8870a09 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt @@ -3,6 +3,7 @@ Device tree bindings for Goodix GT9xx series touchscreen controller Required properties: - compatible : Should be "goodix,gt1151" + or "goodix,gt5688" or "goodix,gt911" or "goodix,gt9110" or "goodix,gt912" diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index f2d9c2c41885..47b1ced41576 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -216,6 +216,7 @@ static const struct goodix_chip_data *goodix_get_chip_data(u16 id) { switch (id) { case 1151: + case 5688: return >1x_chip_data; case 911: @@ -942,6 +943,7 @@ MODULE_DEVICE_TABLE(acpi, goodix_acpi_match); #ifdef CONFIG_OF static const struct of_device_id goodix_of_match[] = { { .compatible = "goodix,gt1151" }, + { .compatible = "goodix,gt5688" }, { .compatible = "goodix,gt911" }, { .compatible = "goodix,gt9110" }, { .compatible = "goodix,gt912" },
From what I've seen in vendor trees it's fine to treat this as gt1x¹. Tested on the Purism Librem 5 Devkit (Rocktech JH057N00900 panel). [1]: https://github.com/TadiT7/android_kernel_mtk-4.4/tree/master/drivers/input/touchscreen/mediatek/GT5688 Signed-off-by: Guido Günther <agx@sigxcpu.org> --- Changes from v1: * Add tested board to commit message Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + drivers/input/touchscreen/goodix.c | 2 ++ 2 files changed, 3 insertions(+)