| Message ID | 1548843431-8162-1-git-send-email-vladimir.murzin@arm.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 49e30bd07df512cdc42e63c14235e6239e92d749 |
| Headers | show |
| Series | ARM: NOMMU: Limit visibility for CONFIG_FLASH_{MEM_BASE, SIZE} | expand |
On Wed, Jan 30, 2019 at 11:17 AM Vladimir Murzin <vladimir.murzin@arm.com> wrote: > > It looks like usage of CONFIG_FLASH_{MEM_BASE,SIZE} is limited with: > > arch/arm/mm/proc-arm740.S > arch/arm/mm/proc-arm940.S > arch/arm/mm/proc-arm946.S > > So it might look confusing to see the option for anything except these. > > Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> This looks correct, Acked-by: Arnd Bergmann <arnd@arndb.de> On a related note though, there is an old problem that we don't actually allow any platform to enable those three CPUs: the only supported machine that has it is integrator, and for the past five years since commit 68f3b875f784 ("ARM: integrator: make the Integrator multiplatform"), it has not been possible to build it for NOMMU. Arnd
On 1/30/19 9:25 PM, Arnd Bergmann wrote: > On Wed, Jan 30, 2019 at 11:17 AM Vladimir Murzin > <vladimir.murzin@arm.com> wrote: >> >> It looks like usage of CONFIG_FLASH_{MEM_BASE,SIZE} is limited with: >> >> arch/arm/mm/proc-arm740.S >> arch/arm/mm/proc-arm940.S >> arch/arm/mm/proc-arm946.S >> >> So it might look confusing to see the option for anything except these. >> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> > > This looks correct, > > Acked-by: Arnd Bergmann <arnd@arndb.de> Thanks! > > On a related note though, there is an old problem that we don't > actually allow any platform to enable those three CPUs: the only > supported machine that has it is integrator, and for the past five > years since commit 68f3b875f784 ("ARM: integrator: make the > Integrator multiplatform"), it has not been possible to build it > for NOMMU. Thant true, yet some people keep out of tree patches to undo multiplatform, not only for NOMMU, but for XIP as well. Cheers Vladimir > > Arnd >
diff --git a/arch/arm/Kconfig-nommu b/arch/arm/Kconfig-nommu index 1168a03..36c80d3 100644 --- a/arch/arm/Kconfig-nommu +++ b/arch/arm/Kconfig-nommu @@ -20,10 +20,12 @@ config DRAM_SIZE config FLASH_MEM_BASE hex 'FLASH Base Address' if SET_MEM_PARAM + depends on CPU_ARM740T || CPU_ARM946E || CPU_ARM940T default 0x00400000 config FLASH_SIZE hex 'FLASH Size' if SET_MEM_PARAM + depends on CPU_ARM740T || CPU_ARM946E || CPU_ARM940T default 0x00400000 config PROCESSOR_ID
It looks like usage of CONFIG_FLASH_{MEM_BASE,SIZE} is limited with: arch/arm/mm/proc-arm740.S arch/arm/mm/proc-arm940.S arch/arm/mm/proc-arm946.S So it might look confusing to see the option for anything except these. Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> --- arch/arm/Kconfig-nommu | 2 ++ 1 file changed, 2 insertions(+)