| Message ID | 20190131092410.28222-4-josephl@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add CPUidle support for Tegra210 | expand |
On Thu, Jan 31, 2019 at 05:24:06PM +0800, Joseph Lo wrote: > The tegra timer is necessary for Tegra210 to support CPU idle power-down > state. So select it by default. > > Signed-off-by: Joseph Lo <josephl@nvidia.com> > --- > v4: > * new added in this version > --- > drivers/soc/tegra/Kconfig | 1 + > 1 file changed, 1 insertion(+) So this technically depends on patch 2/7, so it would make sense for Daniel or Thomas to pick this up along with 2/7, but you didn't Cc them, so they're not aware of this. I think you need to either resend the series and Cc both Daniel and Thomas on all the patches in the series, or we have to make sure that this patch is not applied before patch 2/7, otherwise Kconfig will complain. If you decide to resend, this patch is: Acked-by: Thierry Reding <treding@nvidia.com> Thierry
On 1/31/19 7:26 PM, Thierry Reding wrote: > On Thu, Jan 31, 2019 at 05:24:06PM +0800, Joseph Lo wrote: >> The tegra timer is necessary for Tegra210 to support CPU idle power-down >> state. So select it by default. >> >> Signed-off-by: Joseph Lo <josephl@nvidia.com> >> --- >> v4: >> * new added in this version >> --- >> drivers/soc/tegra/Kconfig | 1 + >> 1 file changed, 1 insertion(+) > > So this technically depends on patch 2/7, so it would make sense for > Daniel or Thomas to pick this up along with 2/7, but you didn't Cc them, > so they're not aware of this. > > I think you need to either resend the series and Cc both Daniel and > Thomas on all the patches in the series, or we have to make sure that > this patch is not applied before patch 2/7, otherwise Kconfig will > complain. If you decide to resend, this patch is: Okay, will resend this series. Thanks for your review, Joseph > > Acked-by: Thierry Reding <treding@nvidia.com> > > Thierry >
diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig index fe4481676da6..a0b03443d8c1 100644 --- a/drivers/soc/tegra/Kconfig +++ b/drivers/soc/tegra/Kconfig @@ -76,6 +76,7 @@ config ARCH_TEGRA_210_SOC select PINCTRL_TEGRA210 select SOC_TEGRA_FLOWCTRL select SOC_TEGRA_PMC + select TEGRA_TIMER help Enable support for the NVIDIA Tegra210 SoC. Also known as Tegra X1, the Tegra210 has four Cortex-A57 cores paired with four Cortex-A53
The tegra timer is necessary for Tegra210 to support CPU idle power-down state. So select it by default. Signed-off-by: Joseph Lo <josephl@nvidia.com> --- v4: * new added in this version --- drivers/soc/tegra/Kconfig | 1 + 1 file changed, 1 insertion(+)