| Message ID | 20190202005610.24048-1-crosa@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Acceptance Tests: target architecture support | expand |
Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support Type: series Message-id: 20190202005610.24048-1-crosa@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 6655fa70df Boot Linux Console Test: add a test for alpha + clipper f6dd48f846 Boot Linux Console Test: add a test for s390x + s390-ccw-virtio 018f1969af Boot Linux Console Test: add a test for arm + virt 1b3a2357bc Boot Linux Console Test: add a test for aarch64 + virt a72b513a01 Boot Linux Console Test: add a test for ppc64 + pseries 53b6bd6a83 Boot Linux Console Test: add a test for mips64el + malta 9e99bc7ca7 Boot Linux Console Test: add a test for mips + malta ad537d2fcc scripts/qemu.py: support adding a console with the default serial device a90473b9e3 Boot Linux Console Test: refactor the console watcher into utility method 31e1e8e772 Boot Linux Console Test: increase timeout 71fd9a8546 Boot Linux Console Test: add common kernel command line options 1f01854455 Boot Linux Console Test: update the x86_64 kernel fd958acfdb Boot Linux Console Test: rename the x86_64 after the arch and machine 5353486417 Acceptance tests: look for target architecture in test tags first 0eec679cae Acceptance tests: use "arch:" tag to filter target specific tests d8bdead7f5 Acceptance tests: introduce arch parameter and attribute 68ac450c2b Acceptance tests: fix doc reference to avocado_qemu directory 4ef4e6bab1 Acceptance tests: improve docstring on pick_default_qemu_bin() 9255bba791 Acceptance tests: show avocado test execution by default 3401845f7e scripts/qemu.py: log QEMU launch command line === OUTPUT BEGIN === 1/20 Checking commit 3401845f7eb9 (scripts/qemu.py: log QEMU launch command line) 2/20 Checking commit 9255bba791a8 (Acceptance tests: show avocado test execution by default) 3/20 Checking commit 4ef4e6bab129 (Acceptance tests: improve docstring on pick_default_qemu_bin()) 4/20 Checking commit 68ac450c2b81 (Acceptance tests: fix doc reference to avocado_qemu directory) 5/20 Checking commit d8bdead7f506 (Acceptance tests: introduce arch parameter and attribute) 6/20 Checking commit 0eec679cae2b (Acceptance tests: use "arch:" tag to filter target specific tests) 7/20 Checking commit 5353486417ba (Acceptance tests: look for target architecture in test tags first) 8/20 Checking commit fd958acfdb06 (Boot Linux Console Test: rename the x86_64 after the arch and machine) 9/20 Checking commit 1f018544557b (Boot Linux Console Test: update the x86_64 kernel) 10/20 Checking commit 71fd9a85460e (Boot Linux Console Test: add common kernel command line options) 11/20 Checking commit 31e1e8e772d2 (Boot Linux Console Test: increase timeout) 12/20 Checking commit a90473b9e34b (Boot Linux Console Test: refactor the console watcher into utility method) 13/20 Checking commit ad537d2fcc3d (scripts/qemu.py: support adding a console with the default serial device) 14/20 Checking commit 9e99bc7ca7b3 (Boot Linux Console Test: add a test for mips + malta) 15/20 Checking commit 53b6bd6a83fb (Boot Linux Console Test: add a test for mips64el + malta) ERROR: line over 90 characters #61: FILE: tests/acceptance/boot_linux_console.py:116: + [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48 ERROR: line over 90 characters #62: FILE: tests/acceptance/boot_linux_console.py:117: + [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official total: 2 errors, 0 warnings, 49 lines checked Patch 15/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/20 Checking commit a72b513a0156 (Boot Linux Console Test: add a test for ppc64 + pseries) 17/20 Checking commit 1b3a2357bc57 (Boot Linux Console Test: add a test for aarch64 + virt) WARNING: line over 80 characters #51: FILE: tests/acceptance/boot_linux_console.py:170: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 31 lines checked Patch 17/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/20 Checking commit 018f1969af3b (Boot Linux Console Test: add a test for arm + virt) WARNING: line over 80 characters #48: FILE: tests/acceptance/boot_linux_console.py:190: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 30 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit f6dd48f84608 (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio) 20/20 Checking commit 6655fa70dfc9 (Boot Linux Console Test: add a test for alpha + clipper) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190202005610.24048-1-crosa@redhat.com Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190202005610.24048-1-crosa@redhat.com -> patchew/20190202005610.24048-1-crosa@redhat.com * [new tag] patchew/20190202011048.12343-1-jsnow@redhat.com -> patchew/20190202011048.12343-1-jsnow@redhat.com * [new tag] patchew/20190202072456.6468-1-yang.zhong@intel.com -> patchew/20190202072456.6468-1-yang.zhong@intel.com Switched to a new branch 'test' 6655fa7 Boot Linux Console Test: add a test for alpha + clipper f6dd48f Boot Linux Console Test: add a test for s390x + s390-ccw-virtio 018f196 Boot Linux Console Test: add a test for arm + virt 1b3a235 Boot Linux Console Test: add a test for aarch64 + virt a72b513 Boot Linux Console Test: add a test for ppc64 + pseries 53b6bd6 Boot Linux Console Test: add a test for mips64el + malta 9e99bc7 Boot Linux Console Test: add a test for mips + malta ad537d2 scripts/qemu.py: support adding a console with the default serial device a90473b Boot Linux Console Test: refactor the console watcher into utility method 31e1e8e Boot Linux Console Test: increase timeout 71fd9a8 Boot Linux Console Test: add common kernel command line options 1f01854 Boot Linux Console Test: update the x86_64 kernel fd958ac Boot Linux Console Test: rename the x86_64 after the arch and machine 5353486 Acceptance tests: look for target architecture in test tags first 0eec679 Acceptance tests: use "arch:" tag to filter target specific tests d8bdead Acceptance tests: introduce arch parameter and attribute 68ac450 Acceptance tests: fix doc reference to avocado_qemu directory 4ef4e6b Acceptance tests: improve docstring on pick_default_qemu_bin() 9255bba Acceptance tests: show avocado test execution by default 3401845 scripts/qemu.py: log QEMU launch command line === OUTPUT BEGIN === 1/20 Checking commit 3401845f7eb9 (scripts/qemu.py: log QEMU launch command line) 2/20 Checking commit 9255bba791a8 (Acceptance tests: show avocado test execution by default) 3/20 Checking commit 4ef4e6bab129 (Acceptance tests: improve docstring on pick_default_qemu_bin()) 4/20 Checking commit 68ac450c2b81 (Acceptance tests: fix doc reference to avocado_qemu directory) 5/20 Checking commit d8bdead7f506 (Acceptance tests: introduce arch parameter and attribute) 6/20 Checking commit 0eec679cae2b (Acceptance tests: use "arch:" tag to filter target specific tests) 7/20 Checking commit 5353486417ba (Acceptance tests: look for target architecture in test tags first) 8/20 Checking commit fd958acfdb06 (Boot Linux Console Test: rename the x86_64 after the arch and machine) 9/20 Checking commit 1f018544557b (Boot Linux Console Test: update the x86_64 kernel) 10/20 Checking commit 71fd9a85460e (Boot Linux Console Test: add common kernel command line options) 11/20 Checking commit 31e1e8e772d2 (Boot Linux Console Test: increase timeout) 12/20 Checking commit a90473b9e34b (Boot Linux Console Test: refactor the console watcher into utility method) 13/20 Checking commit ad537d2fcc3d (scripts/qemu.py: support adding a console with the default serial device) 14/20 Checking commit 9e99bc7ca7b3 (Boot Linux Console Test: add a test for mips + malta) 15/20 Checking commit 53b6bd6a83fb (Boot Linux Console Test: add a test for mips64el + malta) ERROR: line over 90 characters #61: FILE: tests/acceptance/boot_linux_console.py:116: + [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48 ERROR: line over 90 characters #62: FILE: tests/acceptance/boot_linux_console.py:117: + [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official total: 2 errors, 0 warnings, 49 lines checked Patch 15/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/20 Checking commit a72b513a0156 (Boot Linux Console Test: add a test for ppc64 + pseries) 17/20 Checking commit 1b3a2357bc57 (Boot Linux Console Test: add a test for aarch64 + virt) WARNING: line over 80 characters #51: FILE: tests/acceptance/boot_linux_console.py:170: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 31 lines checked Patch 17/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/20 Checking commit 018f1969af3b (Boot Linux Console Test: add a test for arm + virt) WARNING: line over 80 characters #48: FILE: tests/acceptance/boot_linux_console.py:190: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 30 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit f6dd48f84608 (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio) 20/20 Checking commit 6655fa70dfc9 (Boot Linux Console Test: add a test for alpha + clipper) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support Message-id: 20190202005610.24048-1-crosa@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190202005610.24048-1-crosa@redhat.com -> patchew/20190202005610.24048-1-crosa@redhat.com * [new tag] patchew/20190202011048.12343-1-jsnow@redhat.com -> patchew/20190202011048.12343-1-jsnow@redhat.com Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out '9b7ab2fa020341dee8bf9df6c9cf40003e0136df' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' 6655fa7 Boot Linux Console Test: add a test for alpha + clipper f6dd48f Boot Linux Console Test: add a test for s390x + s390-ccw-virtio 018f196 Boot Linux Console Test: add a test for arm + virt 1b3a235 Boot Linux Console Test: add a test for aarch64 + virt a72b513 Boot Linux Console Test: add a test for ppc64 + pseries 53b6bd6 Boot Linux Console Test: add a test for mips64el + malta 9e99bc7 Boot Linux Console Test: add a test for mips + malta ad537d2 scripts/qemu.py: support adding a console with the default serial device a90473b Boot Linux Console Test: refactor the console watcher into utility method 31e1e8e Boot Linux Console Test: increase timeout 71fd9a8 Boot Linux Console Test: add common kernel command line options 1f01854 Boot Linux Console Test: update the x86_64 kernel fd958ac Boot Linux Console Test: rename the x86_64 after the arch and machine 5353486 Acceptance tests: look for target architecture in test tags first 0eec679 Acceptance tests: use "arch:" tag to filter target specific tests d8bdead Acceptance tests: introduce arch parameter and attribute 68ac450 Acceptance tests: fix doc reference to avocado_qemu directory 4ef4e6b Acceptance tests: improve docstring on pick_default_qemu_bin() 9255bba Acceptance tests: show avocado test execution by default 3401845 scripts/qemu.py: log QEMU launch command line === OUTPUT BEGIN === 1/20 Checking commit 3401845f7eb9 (scripts/qemu.py: log QEMU launch command line) 2/20 Checking commit 9255bba791a8 (Acceptance tests: show avocado test execution by default) 3/20 Checking commit 4ef4e6bab129 (Acceptance tests: improve docstring on pick_default_qemu_bin()) 4/20 Checking commit 68ac450c2b81 (Acceptance tests: fix doc reference to avocado_qemu directory) 5/20 Checking commit d8bdead7f506 (Acceptance tests: introduce arch parameter and attribute) 6/20 Checking commit 0eec679cae2b (Acceptance tests: use "arch:" tag to filter target specific tests) 7/20 Checking commit 5353486417ba (Acceptance tests: look for target architecture in test tags first) 8/20 Checking commit fd958acfdb06 (Boot Linux Console Test: rename the x86_64 after the arch and machine) 9/20 Checking commit 1f018544557b (Boot Linux Console Test: update the x86_64 kernel) 10/20 Checking commit 71fd9a85460e (Boot Linux Console Test: add common kernel command line options) 11/20 Checking commit 31e1e8e772d2 (Boot Linux Console Test: increase timeout) 12/20 Checking commit a90473b9e34b (Boot Linux Console Test: refactor the console watcher into utility method) 13/20 Checking commit ad537d2fcc3d (scripts/qemu.py: support adding a console with the default serial device) 14/20 Checking commit 9e99bc7ca7b3 (Boot Linux Console Test: add a test for mips + malta) 15/20 Checking commit 53b6bd6a83fb (Boot Linux Console Test: add a test for mips64el + malta) ERROR: line over 90 characters #61: FILE: tests/acceptance/boot_linux_console.py:116: + [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48 ERROR: line over 90 characters #62: FILE: tests/acceptance/boot_linux_console.py:117: + [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official total: 2 errors, 0 warnings, 49 lines checked Patch 15/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/20 Checking commit a72b513a0156 (Boot Linux Console Test: add a test for ppc64 + pseries) 17/20 Checking commit 1b3a2357bc57 (Boot Linux Console Test: add a test for aarch64 + virt) WARNING: line over 80 characters #51: FILE: tests/acceptance/boot_linux_console.py:170: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 31 lines checked Patch 17/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/20 Checking commit 018f1969af3b (Boot Linux Console Test: add a test for arm + virt) WARNING: line over 80 characters #48: FILE: tests/acceptance/boot_linux_console.py:190: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 30 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit f6dd48f84608 (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio) 20/20 Checking commit 6655fa70dfc9 (Boot Linux Console Test: add a test for alpha + clipper) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190202005610.24048-1-crosa@redhat.com Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190202005610.24048-1-crosa@redhat.com -> patchew/20190202005610.24048-1-crosa@redhat.com * [new tag] patchew/20190202144531.5772-1-n54@gmx.com -> patchew/20190202144531.5772-1-n54@gmx.com Switched to a new branch 'test' 13c391b Boot Linux Console Test: add a test for alpha + clipper 273b9ac Boot Linux Console Test: add a test for s390x + s390-ccw-virtio 0a9b73c Boot Linux Console Test: add a test for arm + virt e070e1d Boot Linux Console Test: add a test for aarch64 + virt 86d4a09 Boot Linux Console Test: add a test for ppc64 + pseries d2b7457 Boot Linux Console Test: add a test for mips64el + malta 4f2bf45 Boot Linux Console Test: add a test for mips + malta 5d2bc37 scripts/qemu.py: support adding a console with the default serial device e93021f Boot Linux Console Test: refactor the console watcher into utility method 58cb1eb Boot Linux Console Test: increase timeout 8e8235f Boot Linux Console Test: add common kernel command line options 5034fd3 Boot Linux Console Test: update the x86_64 kernel 14bbc9f Boot Linux Console Test: rename the x86_64 after the arch and machine 3787369 Acceptance tests: look for target architecture in test tags first 69d1e10 Acceptance tests: use "arch:" tag to filter target specific tests 8494959 Acceptance tests: introduce arch parameter and attribute ae64545 Acceptance tests: fix doc reference to avocado_qemu directory 3ca6eaa Acceptance tests: improve docstring on pick_default_qemu_bin() 8960ff3 Acceptance tests: show avocado test execution by default e154b53 scripts/qemu.py: log QEMU launch command line === OUTPUT BEGIN === 1/20 Checking commit e154b53986c2 (scripts/qemu.py: log QEMU launch command line) 2/20 Checking commit 8960ff314a40 (Acceptance tests: show avocado test execution by default) 3/20 Checking commit 3ca6eaaa5580 (Acceptance tests: improve docstring on pick_default_qemu_bin()) 4/20 Checking commit ae645458d956 (Acceptance tests: fix doc reference to avocado_qemu directory) 5/20 Checking commit 84949598dc7a (Acceptance tests: introduce arch parameter and attribute) 6/20 Checking commit 69d1e10ba586 (Acceptance tests: use "arch:" tag to filter target specific tests) 7/20 Checking commit 37873698dc9e (Acceptance tests: look for target architecture in test tags first) 8/20 Checking commit 14bbc9fdbca8 (Boot Linux Console Test: rename the x86_64 after the arch and machine) 9/20 Checking commit 5034fd3690c5 (Boot Linux Console Test: update the x86_64 kernel) 10/20 Checking commit 8e8235fd2f21 (Boot Linux Console Test: add common kernel command line options) 11/20 Checking commit 58cb1eb0af81 (Boot Linux Console Test: increase timeout) 12/20 Checking commit e93021fae9d0 (Boot Linux Console Test: refactor the console watcher into utility method) 13/20 Checking commit 5d2bc37cd347 (scripts/qemu.py: support adding a console with the default serial device) 14/20 Checking commit 4f2bf45f1281 (Boot Linux Console Test: add a test for mips + malta) 15/20 Checking commit d2b7457492bd (Boot Linux Console Test: add a test for mips64el + malta) ERROR: line over 90 characters #61: FILE: tests/acceptance/boot_linux_console.py:116: + [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48 ERROR: line over 90 characters #62: FILE: tests/acceptance/boot_linux_console.py:117: + [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official total: 2 errors, 0 warnings, 49 lines checked Patch 15/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/20 Checking commit 86d4a092b14e (Boot Linux Console Test: add a test for ppc64 + pseries) 17/20 Checking commit e070e1db9f0f (Boot Linux Console Test: add a test for aarch64 + virt) WARNING: line over 80 characters #51: FILE: tests/acceptance/boot_linux_console.py:170: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 31 lines checked Patch 17/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/20 Checking commit 0a9b73c4cf58 (Boot Linux Console Test: add a test for arm + virt) WARNING: line over 80 characters #48: FILE: tests/acceptance/boot_linux_console.py:190: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 30 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit 273b9ac35793 (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio) 20/20 Checking commit 13c391bc2771 (Boot Linux Console Test: add a test for alpha + clipper) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support Type: series Message-id: 20190202005610.24048-1-crosa@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190202005610.24048-1-crosa@redhat.com -> patchew/20190202005610.24048-1-crosa@redhat.com Switched to a new branch 'test' 17035afa87 Boot Linux Console Test: add a test for alpha + clipper 664f768105 Boot Linux Console Test: add a test for s390x + s390-ccw-virtio af7932545d Boot Linux Console Test: add a test for arm + virt afe4751b4d Boot Linux Console Test: add a test for aarch64 + virt 34684e2787 Boot Linux Console Test: add a test for ppc64 + pseries 828dece1c0 Boot Linux Console Test: add a test for mips64el + malta eafeed88f9 Boot Linux Console Test: add a test for mips + malta 04af0c729d scripts/qemu.py: support adding a console with the default serial device cb969cd6fe Boot Linux Console Test: refactor the console watcher into utility method a446d2e9ba Boot Linux Console Test: increase timeout cbedab968c Boot Linux Console Test: add common kernel command line options 14bf9a0f17 Boot Linux Console Test: update the x86_64 kernel b41b04b466 Boot Linux Console Test: rename the x86_64 after the arch and machine d957397957 Acceptance tests: look for target architecture in test tags first e15cd2534a Acceptance tests: use "arch:" tag to filter target specific tests c558ad7dc5 Acceptance tests: introduce arch parameter and attribute 981c7f300d Acceptance tests: fix doc reference to avocado_qemu directory 19b5d68909 Acceptance tests: improve docstring on pick_default_qemu_bin() db08e24a7e Acceptance tests: show avocado test execution by default fe7c5846dc scripts/qemu.py: log QEMU launch command line === OUTPUT BEGIN === 1/20 Checking commit fe7c5846dca6 (scripts/qemu.py: log QEMU launch command line) 2/20 Checking commit db08e24a7ead (Acceptance tests: show avocado test execution by default) 3/20 Checking commit 19b5d6890978 (Acceptance tests: improve docstring on pick_default_qemu_bin()) 4/20 Checking commit 981c7f300d93 (Acceptance tests: fix doc reference to avocado_qemu directory) 5/20 Checking commit c558ad7dc50a (Acceptance tests: introduce arch parameter and attribute) 6/20 Checking commit e15cd2534a41 (Acceptance tests: use "arch:" tag to filter target specific tests) 7/20 Checking commit d95739795725 (Acceptance tests: look for target architecture in test tags first) 8/20 Checking commit b41b04b4662d (Boot Linux Console Test: rename the x86_64 after the arch and machine) 9/20 Checking commit 14bf9a0f170e (Boot Linux Console Test: update the x86_64 kernel) 10/20 Checking commit cbedab968cbf (Boot Linux Console Test: add common kernel command line options) 11/20 Checking commit a446d2e9baf6 (Boot Linux Console Test: increase timeout) 12/20 Checking commit cb969cd6fe2b (Boot Linux Console Test: refactor the console watcher into utility method) 13/20 Checking commit 04af0c729dfa (scripts/qemu.py: support adding a console with the default serial device) 14/20 Checking commit eafeed88f9b4 (Boot Linux Console Test: add a test for mips + malta) 15/20 Checking commit 828dece1c0ce (Boot Linux Console Test: add a test for mips64el + malta) ERROR: line over 90 characters #61: FILE: tests/acceptance/boot_linux_console.py:116: + [1] http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48 ERROR: line over 90 characters #62: FILE: tests/acceptance/boot_linux_console.py:117: + [2] https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official total: 2 errors, 0 warnings, 49 lines checked Patch 15/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/20 Checking commit 34684e2787d1 (Boot Linux Console Test: add a test for ppc64 + pseries) 17/20 Checking commit afe4751b4d91 (Boot Linux Console Test: add a test for aarch64 + virt) WARNING: line over 80 characters #51: FILE: tests/acceptance/boot_linux_console.py:170: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 31 lines checked Patch 17/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/20 Checking commit af7932545dc5 (Boot Linux Console Test: add a test for arm + virt) WARNING: line over 80 characters #48: FILE: tests/acceptance/boot_linux_console.py:190: + kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyAMA0' total: 0 errors, 1 warnings, 30 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit 664f768105fe (Boot Linux Console Test: add a test for s390x + s390-ccw-virtio) 20/20 Checking commit 17035afa8703 (Boot Linux Console Test: add a test for alpha + clipper) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190202005610.24048-1-crosa@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time make docker-test-mingw@fedora SHOW_ENV=1 J=14 === TEST SCRIPT END === Configure options: --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/tmp/qemu-test/install --python=/usr/bin/python3 --cross-prefix=x86_64-w64-mingw32- --enable-trace-backends=simple --enable-gnutls --enable-nettle --enable-curl --enable-vnc --enable-bzip2 --enable-guest-agent --with-sdlabi=2.0 ERROR: unknown option --with-sdlabi=2.0 Try '/tmp/qemu-test/src/configure --help' for more information # QEMU configure log Sun Feb 3 17:46:40 UTC 2019 # Configured with: '/tmp/qemu-test/src/configure' '--enable-werror' '--target-list=x86_64-softmmu,aarch64-softmmu' '--prefix=/tmp/qemu-test/install' '--python=/usr/bin/python3' '--cross-prefix=x86_64-w64-mingw32-' '--enable-trace-backends=simple' '--enable-gnutls' '--enable-nettle' '--enable-curl' '--enable-vnc' '--enable-bzip2' '--enable-guest-agent' '--with-sdlabi=2.0' --- funcs: do_compiler do_cc compile_object check_define main lines: 92 122 617 634 0 x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c config-temp/qemu-conf.c:2:2: error: #error __linux__ not defined #error __linux__ not defined ^~~~~ --- funcs: do_compiler do_cc compile_object check_define main lines: 92 122 617 686 0 x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c config-temp/qemu-conf.c:2:2: error: #error __i386__ not defined #error __i386__ not defined ^~~~~ --- funcs: do_compiler do_cc compile_object check_define main lines: 92 122 617 689 0 x86_64-w64-mingw32-gcc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -c -o config-temp/qemu-conf.o config-temp/qemu-conf.c config-temp/qemu-conf.c:2:2: error: #error __ILP32__ not defined #error __ILP32__ not defined ^~~~~ --- lines: 92 128 920 0 x86_64-w64-mingw32-gcc -mthreads -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -g -liberty /usr/lib/gcc/x86_64-w64-mingw32/8.2.0/../../../../x86_64-w64-mingw32/bin/ld: cannot find -liberty collect2: error: ld returned 1 exit status Failed to run 'configure' Traceback (most recent call last): File "./tests/docker/docker.py", line 563, in <module> The full log is available at http://patchew.org/logs/20190202005610.24048-1-crosa@redhat.com/testing.docker-mingw@fedora/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
The current acceptance tests don't provide any type of architecture information that can be used to influence the selection of the QEMU binary used on them[1]. If one is running tests on a x86_64 host, the default QEMU binary will be "x86_64-softmmu/qemu-system-x86_64". Given the nature of QEMU, some tests will be architecture agnostic, while others will be architecture dependent. The "check-qtest" and "check-qtest-TARGET" make targets exemplify that pattern. For the acceptance tests, the same requirement exists. Tests should be allowed to influence the binary used, and when they don't, a default selection mechanism should kick in[2]. The proposed solution here requires only that an Avocado tag is set, such as: class My(Test): def test_nx_cpu_flag(self): """ :avocado: tags=arch:x86_64 """ test_code() The value of the "arch" key, in this case, "x86_64" will be used when selecting the QEMU binary to use in the test. At the same time, if "x86_64-softmmu" is not a built target, the test will be filtered out by "make check-acceptance"[3]. Besides the convention explained above, where the binary will be selected from the "arch" tag, it's also possible to set an "arch" *parameter* that will also influence the QEMU binary selection: $ avocado run -p arch=aarch64 works-on-many-arches.py Finally, it's also posible to set the "qemu_bin" parameter, which will define (instead of just influencing) the QEMU binary to be used: $ avocado run -p qemu_bin=qemu-bin-aarch64 test.py As examples for the idea proposed here, a number of "boot linux console" tests have been added, for a number of different target architectures. When the build environment includes them (as it has been added to Travis CI jobs) the architecture specific tests will be automatically executed. As mentioned previously, this patch series include ideas present in other patch series, and from different authors. I tried by best to include the information about authorship, but if I missed any, please accept my apologies and let me know. --- [1] - The "boot_linux_console.py" contains a "x86_64" test tag, but that is informational only, in the sense that it's not consumed by the test itself, or used by "make check-acceptance" to filter out tests. [2] - This patch series doesn't attempt to change the default selection mechanism. Possible changes in this area may include looking for any one built binary first, no matter the host architecture. [3] - On a previous proposed version, the test class would look at the "arch" parameter given, and would cancel the test if there wasn't a match. --- Open issues on this version: ============================ * A possible race condition has been identified in the aarch64 target, when running on an environment with more than 1 CPUs (initially reported by Wainer). - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00192.html * The timeout change to 90s may not be necessary, or the best idea, given that a possible tcg+ppc64 performance regression has been identified. - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00338.html Changes from v1: ================ * On "Acceptance tests: introduce arch parameter and attribute": - Added explicit *host system architecture* to the "arch" parameter behavior documentation (Caio / Philippe) - Added explicit arch parameter name in call to pick_default_qemu_bin() (Caio) - Fixed the documentation about the value of the "arch" attribute when a parameter is not given (Wainer). * On "Acceptance tests: use "arch:" tag to filter target specific tests": - Updated "arch" tag on tests "linux_initrd.py" and "virtio_version.py" (Cornelia) - Fixed the documentation about the value of the "arch" attribute (Wainer) * On "Acceptance tests: look for target architecture in test tags first" - Fixed the documentation given that starting with this patch, the "arch" attribute can also be depend on the "arch:" tag (based on previous patch point raised by Wainer). * New patch "Boot Linux Console Test: add common kernel command line options" (Philippe) * New patch "Boot Linux Console Test: increase timeout" (based on reports from Alex) * On "scripts/qemu.py: support adding a console with the default serial device": - Removed all non-essential console device type defintions from CONSOLE_DEV_TYPES. At this point, setting the console will attempt to use "-serial" on all but the "s390-ccw-virtio*" machines (Philippe). - Updated documentation to make it clear that a specific device type will only be picked from CONSOLE_DEV_TYPES if the machine type is set, and a matching entry exists (Wainer). * On "Boot Linux Console Test: add a test for mips + malta": - Replaced "not easily reproducible kernel" for a kernel built and packaged by the Debian distro (Philippe, and previously Alex) - With the change to a kernel within a Debian package, and its use on another commit, added an utility function, "extract_from_deb()", to extract the kernel from the package (Philippe) - Switched to using common kernel command line options (Philippe) * On "Boot Linux Console Test: add a test for mips64el + malta": - Used the "extract_from_deb()" utility function introduced in the previous patch (Philippe) - Switched to using common kernel command line options (Philippe) - Fixed numbered references on the docstring (Wainer) - Fixed tag name on commit message (s/mips/mips64el/) (Wainer) * On "Boot Linux Console Test: add a test for ppc64 + pseries": - Switched to using common kernel command line options (Philippe) * On "Boot Linux Console Test: add a test for aarch64 + virt": - Switched to using common kernel command line options (Philippe) * On "Boot Linux Console Test: add a test for arm + virt" - Switched to using common kernel command line options (Philippe) * On "Boot Linux Console Test: add a test for s390x + s390-ccw-virtio": - Switched to using common kernel command line options (Philippe) * On "Boot Linux Console Test: add a test for alpha + clipper": - Switched to using common kernel command line options (Philippe) --- Git Info: - URI: https://github.com/clebergnu/qemu/tree/sent/target_arch_v2 - Remote: https://github.com/clebergnu/qemu - Branch: sent/target_arch_v2 Cleber Rosa (19): scripts/qemu.py: log QEMU launch command line Acceptance tests: show avocado test execution by default Acceptance tests: improve docstring on pick_default_qemu_bin() Acceptance tests: fix doc reference to avocado_qemu directory Acceptance tests: introduce arch parameter and attribute Acceptance tests: use "arch:" tag to filter target specific tests Acceptance tests: look for target architecture in test tags first Boot Linux Console Test: rename the x86_64 after the arch and machine Boot Linux Console Test: update the x86_64 kernel Boot Linux Console Test: add common kernel command line options Boot Linux Console Test: increase timeout Boot Linux Console Test: refactor the console watcher into utility method scripts/qemu.py: support adding a console with the default serial device Boot Linux Console Test: add a test for mips64el + malta Boot Linux Console Test: add a test for ppc64 + pseries Boot Linux Console Test: add a test for aarch64 + virt Boot Linux Console Test: add a test for arm + virt Boot Linux Console Test: add a test for s390x + s390-ccw-virtio Boot Linux Console Test: add a test for alpha + clipper Philippe Mathieu-Daudé (1): Boot Linux Console Test: add a test for mips + malta .travis.yml | 4 +- docs/devel/testing.rst | 24 ++- scripts/qemu.py | 40 ++-- tests/Makefile.include | 5 +- tests/acceptance/avocado_qemu/__init__.py | 23 ++- tests/acceptance/boot_linux_console.py | 226 ++++++++++++++++++++-- tests/acceptance/linux_initrd.py | 2 +- tests/acceptance/virtio_version.py | 2 +- tests/requirements.txt | 2 +- 9 files changed, 279 insertions(+), 49 deletions(-)