diff mbox series

[5/8] arm64: tegra: Enable xudc on Jetson TX1

Message ID 1546509899-5071-6-git-send-email-nkristam@nvidia.com (mailing list archive)
State New, archived
Headers show
Series Tegra XUSB gadget driver support | expand

Commit Message

Nagarjuna Kristam Jan. 3, 2019, 10:04 a.m. UTC 
Enable XUSB device mode driver for USB0 slot on Jetson TX1.

Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

JC Kuo Jan. 28, 2019, 8:36 a.m. UTC | #1 
Hi Nagarjuna,

avddio_usb-supply should be <&vdd_3v3_sys> .

hvdd_usb-supply should be <&vdd__1v8> .


Thanks,

JC

On 1/3/19 6:04 PM, Nagarjuna Kristam wrote:
> Enable XUSB device mode driver for USB0 slot on Jetson TX1.
>
> Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
> ---
>   arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> index 985777c..293b95f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> @@ -1325,6 +1325,21 @@
>   		status = "okay";
>   	};
>   
> +	extcon_usb: extcon_vbus {
> +		compatible = "linux,extcon-usb-gpio";
> +		vbus-gpio = <&gpio TEGRA_GPIO(Z, 0) 1>;
> +	};
> +
> +	xudc@700d0000 {
> +		phys = <&{/padctl@7009f000/pads/usb2/lanes/usb2-0}>;
> +		phy-names = "usb2";
> +		avddio_usb-supply = <&vdd_pex_1v05>;
> +		hvdd_usb-supply = <&vdd_3v3_sys>;
> +		avdd_pll_utmip-supply = <&vdd_1v8>;
> +		extcon = <&extcon_usb>;
> +		status = "okay";
> +	};
> +
>   	sata@70020000 {
>   		status = "okay";
>   		phys = <&{/padctl@7009f000/pads/sata/lanes/sata-0}>;
Thierry Reding Feb. 4, 2019, 12:40 p.m. UTC | #2 
On Thu, Jan 03, 2019 at 03:34:56PM +0530, Nagarjuna Kristam wrote:
> Enable XUSB device mode driver for USB0 slot on Jetson TX1.
> 
> Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> index 985777c..293b95f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> @@ -1325,6 +1325,21 @@
>  		status = "okay";
>  	};
>  
> +	extcon_usb: extcon_vbus {
> +		compatible = "linux,extcon-usb-gpio";
> +		vbus-gpio = <&gpio TEGRA_GPIO(Z, 0) 1>;
> +	};

This needs to go to the end of the file. The ordering should be:

	* all nodes with unit-address, sorted by unit-address
	* all nodes without unit-address, sorted alphabetically

Thierry
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
index 985777c..293b95f 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
@@ -1325,6 +1325,21 @@ 
 		status = "okay";
 	};
 
+	extcon_usb: extcon_vbus {
+		compatible = "linux,extcon-usb-gpio";
+		vbus-gpio = <&gpio TEGRA_GPIO(Z, 0) 1>;
+	};
+
+	xudc@700d0000 {
+		phys = <&{/padctl@7009f000/pads/usb2/lanes/usb2-0}>;
+		phy-names = "usb2";
+		avddio_usb-supply = <&vdd_pex_1v05>;
+		hvdd_usb-supply = <&vdd_3v3_sys>;
+		avdd_pll_utmip-supply = <&vdd_1v8>;
+		extcon = <&extcon_usb>;
+		status = "okay";
+	};
+
 	sata@70020000 {
 		status = "okay";
 		phys = <&{/padctl@7009f000/pads/sata/lanes/sata-0}>;