mbox series

[0/6] drm/drv: Remove drm_dev_unplug()

Message ID 20190203154200.61479-1-noralf@tronnes.org (mailing list archive)
Headers show
Series drm/drv: Remove drm_dev_unplug() | expand

Message

Noralf Trønnes Feb. 3, 2019, 3:41 p.m. UTC 
This series removes drm_dev_unplug() and moves the unplugged state
setting to drm_dev_unregister(). All drivers will now have access to the
unplugged state if they so desire.

The drm_device ref handling wrt to the last fd closed after unregister
have been simplified, which also fixed a double drm_dev_unregister()
situation.

Noralf.

Noralf Trønnes (6):
  drm: Fix drm_release() and device unplug
  drm/drv: Prepare to remove drm_dev_unplug()
  drm/amd: Use drm_dev_unregister()
  drm/udl: Use drm_dev_unregister()
  drm/xen: Use drm_dev_unregister()
  drm/drv: Remove drm_dev_unplug()

 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |  3 +-
 drivers/gpu/drm/drm_drv.c               | 48 ++++++++-----------------
 drivers/gpu/drm/drm_file.c              |  6 ++--
 drivers/gpu/drm/udl/udl_drv.c           |  3 +-
 drivers/gpu/drm/xen/xen_drm_front.c     |  7 ++--
 include/drm/drm_drv.h                   | 11 +++---
 6 files changed, 27 insertions(+), 51 deletions(-)

Comments

Daniel Vetter Feb. 4, 2019, 10:05 a.m. UTC | #1 
On Sun, Feb 03, 2019 at 04:41:54PM +0100, Noralf Trønnes wrote:
> This series removes drm_dev_unplug() and moves the unplugged state
> setting to drm_dev_unregister(). All drivers will now have access to the
> unplugged state if they so desire.
> 
> The drm_device ref handling wrt to the last fd closed after unregister
> have been simplified, which also fixed a double drm_dev_unregister()
> situation.

Nice. On the series:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

But definitely wait 1-2 weeks for some more driver acks I'd say before
applying this all.
-Daniel

> 
> Noralf.
> 
> Noralf Trønnes (6):
>   drm: Fix drm_release() and device unplug
>   drm/drv: Prepare to remove drm_dev_unplug()
>   drm/amd: Use drm_dev_unregister()
>   drm/udl: Use drm_dev_unregister()
>   drm/xen: Use drm_dev_unregister()
>   drm/drv: Remove drm_dev_unplug()
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |  3 +-
>  drivers/gpu/drm/drm_drv.c               | 48 ++++++++-----------------
>  drivers/gpu/drm/drm_file.c              |  6 ++--
>  drivers/gpu/drm/udl/udl_drv.c           |  3 +-
>  drivers/gpu/drm/xen/xen_drm_front.c     |  7 ++--
>  include/drm/drm_drv.h                   | 11 +++---
>  6 files changed, 27 insertions(+), 51 deletions(-)
> 
> -- 
> 2.20.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Christian König Feb. 4, 2019, 12:45 p.m. UTC | #2 
Adding Andrey who looked into cleaning this up a while ago as well.

Christian.

Am 03.02.19 um 16:41 schrieb Noralf Trønnes:
> This series removes drm_dev_unplug() and moves the unplugged state
> setting to drm_dev_unregister(). All drivers will now have access to the
> unplugged state if they so desire.
>
> The drm_device ref handling wrt to the last fd closed after unregister
> have been simplified, which also fixed a double drm_dev_unregister()
> situation.
>
> Noralf.
>
> Noralf Trønnes (6):
>    drm: Fix drm_release() and device unplug
>    drm/drv: Prepare to remove drm_dev_unplug()
>    drm/amd: Use drm_dev_unregister()
>    drm/udl: Use drm_dev_unregister()
>    drm/xen: Use drm_dev_unregister()
>    drm/drv: Remove drm_dev_unplug()
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |  3 +-
>   drivers/gpu/drm/drm_drv.c               | 48 ++++++++-----------------
>   drivers/gpu/drm/drm_file.c              |  6 ++--
>   drivers/gpu/drm/udl/udl_drv.c           |  3 +-
>   drivers/gpu/drm/xen/xen_drm_front.c     |  7 ++--
>   include/drm/drm_drv.h                   | 11 +++---
>   6 files changed, 27 insertions(+), 51 deletions(-)
>