[i-g-t,v5,0/6] igt: Add support for testing writeback connectors

Message

Liviu Dudau Jan. 15, 2019, 5:47 p.m. UTC

We're trying to introduce support for writeback connectors, a way to
expose in DRM the hardware functionality from display engines that
allows to write back into memory the result of the DE's composition
of supported planes.

Although this is a rebase of v4 with all the comments addressed, I'm not
expecting people to remember any of the previous versions, please review
this as if it is a new series.

Patches have been originally implemented by Brian, I've done the v3 and v4
updates to them.

Best regards,
Liviu

Changelog:
 - v5: Addressed comments from Brian Starkey. Old v4 changes are here:
   https://lists.freedesktop.org/archives/igt-dev/2018-November/006806.html
 
 - v4: Rebased on the latest i-g-t and switched to the igt_output_xxx()
   call as suggested by Maarten. v3 is here:
   https://lists.freedesktop.org/archives/intel-gfx/2018-March/157394.html
   Maarten's comments came a couple of months later :)
   https://lists.freedesktop.org/archives/intel-gfx/2018-June/169027.html
   
 - v3: I've now dropped all the changes that were trying to split the CRC
   functionality out of lib/igt_debugfs.c. v2 is here:
   https://lists.freedesktop.org/archives/intel-gfx/2017-July/133154.html
   
 - Added meson support for builting the kms_writeback test


Brian Starkey (6):
  lib/igt_kms: Add writeback support
  kms_writeback: Add initial writeback tests
  lib: Add function to hash a framebuffer
  kms_writeback: Add writeback-check-output
  lib/igt_kms: Add igt_output_clone_pipe for cloning
  kms_writeback: Add tests using a cloned output

 lib/igt_fb.c           |  66 ++++++
 lib/igt_fb.h           |   3 +
 lib/igt_kms.c          | 157 +++++++++----
 lib/igt_kms.h          |  11 +
 tests/Makefile.sources |   1 +
 tests/kms_writeback.c  | 492 +++++++++++++++++++++++++++++++++++++++++
 tests/meson.build      |   1 +
 7 files changed, 693 insertions(+), 38 deletions(-)
 create mode 100644 tests/kms_writeback.c

Comments

Brian Starkey Feb. 4, 2019, 1:36 p.m. UTC | #1

Hi Liviu,

On Tue, Jan 15, 2019 at 05:47:41PM +0000, Liviu Dudau wrote:
> We're trying to introduce support for writeback connectors, a way to
> expose in DRM the hardware functionality from display engines that
> allows to write back into memory the result of the DE's composition
> of supported planes.
> 
> Although this is a rebase of v4 with all the comments addressed, I'm not
> expecting people to remember any of the previous versions, please review
> this as if it is a new series.
> 
> Patches have been originally implemented by Brian, I've done the v3 and v4
> updates to them.
> 
> Best regards,
> Liviu
> 
> Changelog:
>  - v5: Addressed comments from Brian Starkey. Old v4 changes are here:
>    https://lists.freedesktop.org/archives/igt-dev/2018-November/006806.html

I just replied with two super minor things, but otherwise this looks
fine to me.

As we were just discussing, strangely it seems like we both never
received Maarten's v4 emails. His proposed changes sounded fine to me,
though, if you decide to roll them in.

Thanks,
-Brian

>  
>  - v4: Rebased on the latest i-g-t and switched to the igt_output_xxx()
>    call as suggested by Maarten. v3 is here:
>    https://lists.freedesktop.org/archives/intel-gfx/2018-March/157394.html
>    Maarten's comments came a couple of months later :)
>    https://lists.freedesktop.org/archives/intel-gfx/2018-June/169027.html
>    
>  - v3: I've now dropped all the changes that were trying to split the CRC
>    functionality out of lib/igt_debugfs.c. v2 is here:
>    https://lists.freedesktop.org/archives/intel-gfx/2017-July/133154.html
>    
>  - Added meson support for builting the kms_writeback test
> 
> 
> Brian Starkey (6):
>   lib/igt_kms: Add writeback support
>   kms_writeback: Add initial writeback tests
>   lib: Add function to hash a framebuffer
>   kms_writeback: Add writeback-check-output
>   lib/igt_kms: Add igt_output_clone_pipe for cloning
>   kms_writeback: Add tests using a cloned output
> 
>  lib/igt_fb.c           |  66 ++++++
>  lib/igt_fb.h           |   3 +
>  lib/igt_kms.c          | 157 +++++++++----
>  lib/igt_kms.h          |  11 +
>  tests/Makefile.sources |   1 +
>  tests/kms_writeback.c  | 492 +++++++++++++++++++++++++++++++++++++++++
>  tests/meson.build      |   1 +
>  7 files changed, 693 insertions(+), 38 deletions(-)
>  create mode 100644 tests/kms_writeback.c
> 
> -- 
> 2.20.1
>