| Message ID | 20190131211046.18603-2-gwan-gyeong.mun@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/dp: Preliminary support for DP YCbCr4:2:0 outputs | expand |
Op 31-01-2019 om 22:10 schreef Gwan-gyeong Mun: > Bspec describes that GEN10 only supports capability of YUV 4:2:0 output to > HDMI port and GEN11 supports capability of YUV 4:2:0 output to both DP and > HDMI ports. > > Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 681e88405ada..ad7382d3be86 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -6923,6 +6923,9 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, > connector->interlace_allowed = true; > connector->doublescan_allowed = 0; > > + if (INTEL_GEN(dev_priv) >= 11) > + connector->ycbcr_420_allowed = true; > + > intel_encoder->hpd_pin = intel_hpd_pin_default(dev_priv, port); > > intel_dp_aux_init(intel_dp); This should probably be done as last patch (6/6). Otherwise looks good. Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
On Fri, 2019-02-08 at 16:24 +0100, Maarten Lankhorst wrote: > Op 31-01-2019 om 22:10 schreef Gwan-gyeong Mun: > > Bspec describes that GEN10 only supports capability of YUV 4:2:0 > > output to > > HDMI port and GEN11 supports capability of YUV 4:2:0 output to both > > DP and > > HDMI ports. > > > > Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> > > --- > > drivers/gpu/drm/i915/intel_dp.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c > > b/drivers/gpu/drm/i915/intel_dp.c > > index 681e88405ada..ad7382d3be86 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -6923,6 +6923,9 @@ intel_dp_init_connector(struct > > intel_digital_port *intel_dig_port, > > connector->interlace_allowed = true; > > connector->doublescan_allowed = 0; > > > > + if (INTEL_GEN(dev_priv) >= 11) > > + connector->ycbcr_420_allowed = true; > > + > > intel_encoder->hpd_pin = intel_hpd_pin_default(dev_priv, port); > > > > intel_dp_aux_init(intel_dp); > > This should probably be done as last patch (6/6). Otherwise looks > good. > I will reorder this patch as last patch. Br, Gwan-gyeong. > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 681e88405ada..ad7382d3be86 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -6923,6 +6923,9 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, connector->interlace_allowed = true; connector->doublescan_allowed = 0; + if (INTEL_GEN(dev_priv) >= 11) + connector->ycbcr_420_allowed = true; + intel_encoder->hpd_pin = intel_hpd_pin_default(dev_priv, port); intel_dp_aux_init(intel_dp);
Bspec describes that GEN10 only supports capability of YUV 4:2:0 output to HDMI port and GEN11 supports capability of YUV 4:2:0 output to both DP and HDMI ports. Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 3 +++ 1 file changed, 3 insertions(+)