[v2,0/3] iolatency bug fix

Message

Liu Bo Jan. 25, 2019, 12:12 a.m. UTC

This set is to fix a hang case if blk-iolatency is in use.

The 1st patch explains the hang problem with more details and provides
a fix.
The 2nd patch adds a warning for unexpected inflight counter.
The 3rd patch is a cleanup of blk_mq_freeze_queue.

v2: reorder the actual fix to the first patch.

Liu Bo (3):
  blk-iolatency: fix IO hang due to negative inflight counter
  Blk-iolatency: warn on negative inflight IO counter
  blk-mq: remove duplicated definition of blk_mq_freeze_queue

 block/blk-iolatency.c | 56 ++++++++++++++++++++++++++++++++++++-------
 block/blk-mq.h        |  1 -
 2 files changed, 48 insertions(+), 9 deletions(-)

Comments

Liu Bo Feb. 8, 2019, 7:14 p.m. UTC | #1

Ping?

thanks,
liubo

On Thu, Jan 24, 2019 at 4:14 PM Liu Bo <[e-mail]> wrote:
>
> This set is to fix a hang case if blk-iolatency is in use.
>
> The 1st patch explains the hang problem with more details and provides
> a fix.
> The 2nd patch adds a warning for unexpected inflight counter.
> The 3rd patch is a cleanup of blk_mq_freeze_queue.
>
> v2: reorder the actual fix to the first patch.
>
> Liu Bo (3):
>   blk-iolatency: fix IO hang due to negative inflight counter
>   Blk-iolatency: warn on negative inflight IO counter
>   blk-mq: remove duplicated definition of blk_mq_freeze_queue
>
>  block/blk-iolatency.c | 56 ++++++++++++++++++++++++++++++++++++-------
>  block/blk-mq.h        |  1 -
>  2 files changed, 48 insertions(+), 9 deletions(-)
>
> --
> 2.20.1.2.gb21ebb6
>

Jens Axboe Feb. 8, 2019, 7:42 p.m. UTC | #2

On 1/24/19 5:12 PM, Liu Bo wrote:
> This set is to fix a hang case if blk-iolatency is in use.
> 
> The 1st patch explains the hang problem with more details and provides
> a fix.
> The 2nd patch adds a warning for unexpected inflight counter.
> The 3rd patch is a cleanup of blk_mq_freeze_queue.

Applied for 5.0, thanks.